From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MNzrEfLxyV9HBgAA0tVLHw (envelope-from ) for ; Fri, 04 Dec 2020 08:23:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ICjcDfLxyV8GDAAAbx9fmQ (envelope-from ) for ; Fri, 04 Dec 2020 08:23:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13E4A9402A8 for ; Fri, 4 Dec 2020 08:23:14 +0000 (UTC) Received: from localhost ([::1]:36180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kl6Mz-0006Gf-2T for larch@yhetil.org; Fri, 04 Dec 2020 03:23:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kl6Ks-0004Tm-Na for guix-patches@gnu.org; Fri, 04 Dec 2020 03:21:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kl6Ks-0001Pa-EL for guix-patches@gnu.org; Fri, 04 Dec 2020 03:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kl6Ks-00088z-A2 for guix-patches@gnu.org; Fri, 04 Dec 2020 03:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45018] [PATCH 3/6] daemon: Factorize substituter agent spawning. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Dec 2020 08:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45018 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 45018@debbugs.gnu.org Received: via spool by 45018-submit@debbugs.gnu.org id=B45018.160707000231127 (code B ref 45018); Fri, 04 Dec 2020 08:21:02 +0000 Received: (at 45018) by debbugs.gnu.org; 4 Dec 2020 08:20:02 +0000 Received: from localhost ([127.0.0.1]:42510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl6Jt-00085v-PG for submit@debbugs.gnu.org; Fri, 04 Dec 2020 03:20:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl6Jr-00085a-U0 for 45018@debbugs.gnu.org; Fri, 04 Dec 2020 03:20:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33479) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kl6Jl-0000tO-Uu; Fri, 04 Dec 2020 03:19:53 -0500 Received: from [2a01:e0a:19b:d9a0:ec50:e664:fea6:2900] (port=34136 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kl6Jl-0000Vy-0l; Fri, 04 Dec 2020 03:19:53 -0500 From: Mathieu Othacehe References: <20201203101930.11210-1-ludo@gnu.org> <20201203101930.11210-3-ludo@gnu.org> Date: Fri, 04 Dec 2020 09:19:51 +0100 In-Reply-To: <20201203101930.11210-3-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 3 Dec 2020 11:19:27 +0100") Message-ID: <871rg6oue0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.79 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 13E4A9402A8 X-Spam-Score: -2.79 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: yxCrMvXvSKmK Hey Ludo, > + const std::map env = { { "_NIX_OPTIONS", settings.pack() } }; > + runningSubstituter = std::make_shared(settings.guixProgram, args, env); The only owner of this Agent is LocalStore, so why not using make_unique? This function could return a const reference to the Agent instead. Thanks, Mathieu