From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OKWZH9i6cmAD9AAAgWs5BA (envelope-from ) for ; Sun, 11 Apr 2021 11:01:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mESMGdi6cmAGKQAA1q6Kng (envelope-from ) for ; Sun, 11 Apr 2021 09:01:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 26CDD255FB for ; Sun, 11 Apr 2021 11:01:12 +0200 (CEST) Received: from localhost ([::1]:52836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVVxv-0000Sq-5X for larch@yhetil.org; Sun, 11 Apr 2021 05:01:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVVxm-0000RY-8c for guix-patches@gnu.org; Sun, 11 Apr 2021 05:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVVxm-000189-0T for guix-patches@gnu.org; Sun, 11 Apr 2021 05:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVVxl-00046f-UZ for guix-patches@gnu.org; Sun, 11 Apr 2021 05:01:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47608] adds emacs-lockstep Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Apr 2021 09:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47608 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 47608@debbugs.gnu.org Cc: rdes@protonmail.com X-Debbugs-Original-To: rdes via Guix-patches via X-Debbugs-Original-Cc: 47608@debbugs.gnu.org, rdes Received: via spool by submit@debbugs.gnu.org id=B.161813164715755 (code B ref -1); Sun, 11 Apr 2021 09:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Apr 2021 09:00:47 +0000 Received: from localhost ([127.0.0.1]:53984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVVxX-000463-8w for submit@debbugs.gnu.org; Sun, 11 Apr 2021 05:00:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:54154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVVxU-00045u-3f for submit@debbugs.gnu.org; Sun, 11 Apr 2021 05:00:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVVxT-0000KV-S6 for guix-patches@gnu.org; Sun, 11 Apr 2021 05:00:43 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:12847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVVxR-0000ox-Hu for guix-patches@gnu.org; Sun, 11 Apr 2021 05:00:43 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 3FA2F240008; Sun, 11 Apr 2021 09:00:34 +0000 (UTC) From: Nicolas Goaziou References: <9mcgTSrn2rNFyA9Pf_V8_dMVTY7brHQTHqGiBo-fKqnjT5UbR8jmj2Y3Q0lEAv6dX9JuFLRiTLMEXqtjSQxERh2zutObssHHl0uj7DJ42CU=@protonmail.com> Date: Sun, 11 Apr 2021 11:00:32 +0200 In-Reply-To: <9mcgTSrn2rNFyA9Pf_V8_dMVTY7brHQTHqGiBo-fKqnjT5UbR8jmj2Y3Q0lEAv6dX9JuFLRiTLMEXqtjSQxERh2zutObssHHl0uj7DJ42CU=@protonmail.com> (rdes via Guix-patches via's message of "Tue, 06 Apr 2021 02:18:03 +0000") Message-ID: <871rbhrya7.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.193; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618131672; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=HY/tu0NENpjrWi86cIrAFTvn82q5VSVwj7+t50eeXAU=; b=mnTJ3M+ATXF5SFXnoHnuPhhUitFxNSHJhXbejVaHIgglSefH25/fAOCtKq58LmqXaSfNMv HfVguNjlvJoiMFcKozLzsBdh2JhxMQ3GROc4e/GbzeZIMVQwEbrbCg6ONrPzpIYdhIqOpc HFDiFLzlFAR57+yoEM1JHxOhUAVHB2clkkyVvaekGW5vtZF6REP5fIzHxv/5cbRYUJvQ6a UxGFMV1Z0w1mZgfMZB1mwZQ//fmXfH3WR7TnVewt86zQNn9Iw+NhZdTdIO/CEpAl6KyrwJ agU1Medn/hCejTwpWHQtI8omDXe2W1Iet3HeLGs5Nmi4SJcsZ4stt6lk/AgoEQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618131672; a=rsa-sha256; cv=none; b=SioGvVPLrRWWIP37NWPT3fKaXgId+4QJYRxxfljOtSJIdInBDPAK3UZx/tuLclfIydnrCO NWGEraRo7X1iM+bjBhY38AdSnmCnRJAw/jLeRN4LGmixuh5gn1iL8dl6q6vOZbcLhFr9j9 9dgsGT1w6FWl3fM5sdKcHgq8rbT9mjskmkKHd/lZeBlYXKwBQY2B4XsXdiVBIF9L+Saode VbWUrxzwjFZhyG4z3V8Azipbc2kWPnlRvAwLOo0fKwL15X5ix5rWr1ovBglX4e4MeKBhUB e2Y0tO0Wo9i0IXS9se3L5yHoGMXsoJCF16992kp+QXfPqVVaBZEf6HrRV6+B3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 26CDD255FB X-Spam-Score: -0.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: Tc6GGBn1SubW Hello, rdes via Guix-patches via writes: > The attached patch adds emacs-lockstep. Thank you. Some comments follow. > +(define-public emacs-lockstep > + (let ((commit "5fe78e94533c4a050d3fce23685040ac754c2e54")) A comment should explain why we're using a commit hash instead of a tag. > + (package > + (name "emacs-lockstep") > + (version "0.1") This is not the correct version. Actually, I couldn't find any reference to a version at all in the file, so it should be "0", with a comment. > + (synopsis > + "Pair program in Emacs") Nitpick: Pair programming in Emacs > + (description > + "Lockstep is a package for pair programming in Emacs. It synchronizes > +the windows and points of two or more Emacs frames, so that a team of > +programmers can share an editing session. > + > +BE CAREFUL: any programmer in the session will be able to control the Emacs > +process running as the user who started the Emacs server.") Nitpick: Be careful! All programmers see the same buffers and live edits, and any programmer can take over the editing session. > + (license license:gpl3+)))) Unfortunately, I see no reference whatsoever to a license in the code base. I don't think we can infer this is GPL3+. What makes you think so? Regards, -- Nicolas Goaziou