From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 47608@debbugs.gnu.org
Cc: rdes@protonmail.com
Subject: [bug#47608] adds emacs-lockstep
Date: Sun, 11 Apr 2021 11:00:32 +0200 [thread overview]
Message-ID: <871rbhrya7.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <9mcgTSrn2rNFyA9Pf_V8_dMVTY7brHQTHqGiBo-fKqnjT5UbR8jmj2Y3Q0lEAv6dX9JuFLRiTLMEXqtjSQxERh2zutObssHHl0uj7DJ42CU=@protonmail.com> (rdes via Guix-patches via's message of "Tue, 06 Apr 2021 02:18:03 +0000")
Hello,
rdes via Guix-patches via <guix-patches@gnu.org> writes:
> The attached patch adds emacs-lockstep.
Thank you. Some comments follow.
> +(define-public emacs-lockstep
> + (let ((commit "5fe78e94533c4a050d3fce23685040ac754c2e54"))
A comment should explain why we're using a commit hash instead of a tag.
> + (package
> + (name "emacs-lockstep")
> + (version "0.1")
This is not the correct version. Actually, I couldn't find any reference
to a version at all in the file, so it should be "0", with a comment.
> + (synopsis
> + "Pair program in Emacs")
Nitpick: Pair programming in Emacs
> + (description
> + "Lockstep is a package for pair programming in Emacs. It synchronizes
> +the windows and points of two or more Emacs frames, so that a team of
> +programmers can share an editing session.
> +
> +BE CAREFUL: any programmer in the session will be able to control the Emacs
> +process running as the user who started the Emacs server.")
Nitpick:
Be careful! All programmers see the same buffers and live edits, and
any programmer can take over the editing session.
> + (license license:gpl3+))))
Unfortunately, I see no reference whatsoever to a license in the code
base. I don't think we can infer this is GPL3+. What makes you think so?
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2021-04-11 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 2:18 [bug#47608] adds emacs-lockstep rdes via Guix-patches via
2021-04-11 9:00 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rbhrya7.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=47608@debbugs.gnu.org \
--cc=rdes@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).