From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sIJjHhZLumAYmQAAgWs5BA (envelope-from ) for ; Fri, 04 Jun 2021 17:47:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AzasGRZLumADEwAAbx9fmQ (envelope-from ) for ; Fri, 04 Jun 2021 15:47:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE0D1197A8 for ; Fri, 4 Jun 2021 17:47:33 +0200 (CEST) Received: from localhost ([::1]:39830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpC2m-0007lk-Vq for larch@yhetil.org; Fri, 04 Jun 2021 11:47:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpC2I-0007IH-EB for guix-patches@gnu.org; Fri, 04 Jun 2021 11:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpC2I-0003yj-6G for guix-patches@gnu.org; Fri, 04 Jun 2021 11:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpC2I-0000R1-3O for guix-patches@gnu.org; Fri, 04 Jun 2021 11:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48721] [PATCH v2] gnu: gcc-8: Make static libs reproducible Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Jun 2021 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48721 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Carl Dong Cc: cmmarusich@gmail.com, 48721@debbugs.gnu.org Received: via spool by 48721-submit@debbugs.gnu.org id=B48721.16228215781542 (code B ref 48721); Fri, 04 Jun 2021 15:47:02 +0000 Received: (at 48721) by debbugs.gnu.org; 4 Jun 2021 15:46:18 +0000 Received: from localhost ([127.0.0.1]:47768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpC1Z-0000Oo-Of for submit@debbugs.gnu.org; Fri, 04 Jun 2021 11:46:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpC1X-0000OK-SJ for 48721@debbugs.gnu.org; Fri, 04 Jun 2021 11:46:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38648) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpC1S-0003CD-A9; Fri, 04 Jun 2021 11:46:10 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43764 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpC1S-0006MQ-12; Fri, 04 Jun 2021 11:46:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87lf7x79hp.fsf@gnu.org> <20210603200518.1125690-1-contact@carldong.me> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 Prairial an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 04 Jun 2021 17:46:08 +0200 In-Reply-To: <20210603200518.1125690-1-contact@carldong.me> (Carl Dong's message of "Thu, 3 Jun 2021 16:05:19 -0400") Message-ID: <871r9hpr9b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622821654; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=2oj5yS/z39snW79FnAG+zng9Cdj7ioPNxUptTauVbb0=; b=TeXHPt795tETXlC2G20oZtGTV19B3rzQ4Oc7tdrSHp8H67KtoJW3J1LscETjyGUvY2y7mt DP9xKIQRSaPWUckFpOuryHkxx58bdYm5GryHdyIPmLEV1sbO4Wwe8UZjZEg0cbx5Ix0R9N YgeFUOQImUskOQrUrvpo25tz15jIZmk2AA9Yqp1QG/MujTrJ9VoXh0SXtSC5iMByORliKU chf7fQI0Hw273jdaUmnr81mAVTwZQOEF6tQZ7V+qQwfpvFfofNSOeeaznoEIeE9HsAlHsE MgR568gu2DRMsgTo7UX60mjjP2NLw7fzHkhvcH4yPZpB82Mtz3Q/bEsryCdINg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622821654; a=rsa-sha256; cv=none; b=vAAwFTZKd9++FJjI99lomxZKxEoOR6KiSNTG1SBV72QSPOqxR7dyWEPADBNFIe1pFmKJI3 vrrkPCaqqeZTR2v/SK3PT7nEGjlji0Wo4QBbrPyq25KM8h/WONqME7OpN0KUlzwSR9I6F3 ouXc7zag+t+3m20HVXkzab7L9gImR5Ir22Qxk0PyH7wCpLlyGtc4ZGpyWC01tOHGNIwVc3 E37cJnwabWo4XTZbWgy3+cCaniGa/OsUAKWoccWl3W0v7qtb6gh7uk8Jw/WgA7ZC18uI9v wpAaMFOOCkbX/MMTLT9NM5BVo1Bk9fS+13BgWavMQ3BN33i5+Al2oT1IVwhNQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DE0D1197A8 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: Rt/aG2dRUPAT Hi Carl, Carl Dong skribis: >> Well done. Did you observe it in practice? (On =E2=80=98core-updates= =E2=80=99 maybe?) > > Thanks! Yes, we observed it when switching back from gcc-9 to gcc-8 for > compiling Bitcoin Core. We use -static-libstdc++, which means that any > non-reproducibility in libstdc++.a propagates into our produced binaries = as > well. OK. > To be clear, I was only able to identify the problem and fix thanks to yo= ur > patch here: > https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/patches/dico= -libtool-deterministic.patch?h=3Db6094b1f0a6760b9f5296364cf5edb8a2e64953c Oh. (I suppose GCC doesn=E2=80=99t have a single =E2=80=98ltmain.sh=E2=80= =99 that we could patch instead of all these =E2=80=98configure=E2=80=99 scripts, right?) >> I=E2=80=99m surprised that this is still an issue since this was fixed in >> Libtool proper long ago, probably before GCC 8 was released. > > Right, unfortunately GCC maintains their own version of libtool, which ha= sn't > been synced with upstream for a while. I documented the details here: htt= ps://reproducible-builds.org/docs/archives/#gnu-libtool Great that you documented it! > This fixes the nonreproducibility in gcc documented here: > https://reproducible-builds.org/docs/archives/#gnu-libtool > > * gnu/packages/patches/gcc-8-sort-libtool-find-output.patch: New patch. > * gnu/local.mk (dist_patch_DATA): Register it. > * gnu/packages/gcc.scm (gcc-8)[source]: Apply it. > --- > gnu/local.mk | 1 + > gnu/packages/gcc.scm | 3 +- > .../gcc-8-sort-libtool-find-output.patch | 399 ++++++++++++++++++ LGTM and OK for =E2=80=98master=E2=80=99. Thanks! Ludo=E2=80=99.