unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Tropin <andrew@trop.in>
To: Leo Prikler <leo.prikler@student.tugraz.at>, 49284@debbugs.gnu.org
Subject: [bug#49284] [PATCH] gnu: Add fheroes2
Date: Wed, 30 Jun 2021 13:20:37 +0300	[thread overview]
Message-ID: <871r8jvekq.fsf@trop.in> (raw)
In-Reply-To: <215bf43c7f10fbca3dfe08f5b10c176662cd4798.camel@student.tugraz.at>

[-- Attachment #1: Type: text/plain, Size: 2718 bytes --]

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> Am Mittwoch, den 30.06.2021, 08:49 +0300 schrieb Andrew Tropin:
>> * gnu/packages/games.scm (fheroes2): New variable.
>> ---
>>  There are no tests in the project, so they are disabled.
> #:tests? #f should always be documented inside the code
>>  gnu/packages/games.scm | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>> 
>> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
>> index 83cb738b9c..7a87123df3 100644
>> --- a/gnu/packages/games.scm
>> +++ b/gnu/packages/games.scm
>> @@ -12511,3 +12511,33 @@ wreckage.  You're stranded on a desert
>> island and have to survive.  In order to
>>  do so you need to explore the island, find food, build a shelter and
>> try to
>>  get attention, so you get found.")
>>        (license license:cc-by4.0))))
>> +
>> +(define-public fheroes2
>> +  (package
>> +    (name "fheroes2")
>> +    (version "0.9.4")
>> +    (build-system cmake-build-system)
>> +    (arguments
>> +     `(#:tests? #f
> Add a comment here along the lines of "no tests" or "no check target".
>> +       #:make-flags '("FHEROES2_STRICT_COMPILATION=1"
>> +                      "RELEASE=1")))
>> +    (native-inputs
>> +     `(("gettext" ,gettext-minimal)))
>> +    (inputs
>> +     `(("zlib" ,zlib)
>> +       ("libpng" ,libpng)
>> +       ("sdl" ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-
>> ttf)))))
>> +    (source (origin
>> +              (method git-fetch)
>> +              (uri (git-reference
>> +                    (url "https://github.com/ihhub/fheroes2")
>> +                    (commit version)))
>> +              (file-name (git-file-name name version))
>> +              (sha256
>> +               (base32
>> +                "0a3xi3k7ngp0byhmg7wq22l1hix3jwr68prk2y6frqhzbfskrvy
>> g"))))
>> +    (home-page "https://ihhub.github.io/fheroes2/")
>> +    (synopsis "Turn-based strategy game engine")
>> +    (description "Free implementation of Heroes of Might and Magic
>> II (aka
>> +HOMM2) game engine.")
>> +    (license license:gpl2)))
> The description is a bit lacking in information.  Is this engine
> usable?  If so, how?  We ought not to steer users towards non-free
> software.

Yep, it's usable.  It requires game resources (assets like music, maps,
sprites), the assets from original game is not distributed with it
because of legal reasons I suppose, but AFAIK nothing stops people from
creating their own set of assets to use with this game engine.  Also,
taking only assets from original game and using them with this engine
will help people not to use unfree software.

Added comment, updated description.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

  parent reply	other threads:[~2021-06-30 10:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30  5:49 [bug#49284] [PATCH] gnu: Add fheroes2 Andrew Tropin
2021-06-30  9:03 ` Leo Prikler
2021-06-30 10:17   ` [bug#49284] [PATCH v2] " Andrew Tropin
2021-06-30 10:20   ` Andrew Tropin [this message]
2021-06-30 10:48     ` [bug#49284] [PATCH] " Leo Prikler
2021-06-30 11:22       ` Andrew Tropin
2021-07-02  9:11         ` Nicolas Goaziou
     [not found] ` <handler.49284.B.16250321759695.ack@debbugs.gnu.org>
2021-09-08  9:34   ` [bug#49284] [PATCH v3] " Andrew Tropin
2021-09-13 20:25     ` bug#49284: " Nicolas Goaziou
2021-09-14  6:27       ` [bug#49284] " Andrew Tropin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r8jvekq.fsf@trop.in \
    --to=andrew@trop.in \
    --cc=49284@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).