unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Tropin <andrew@trop.in>
To: zimoun <zimon.toutoune@gmail.com>,
	Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 49457@debbugs.gnu.org
Subject: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch.
Date: Thu, 08 Jul 2021 13:14:34 +0300	[thread overview]
Message-ID: <871r893yet.fsf@trop.in> (raw)
In-Reply-To: <86bl7d2mny.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]

zimoun <zimon.toutoune@gmail.com> writes:

> Hi,
>
> (Sorry for this naive question.)
>
> On Thu, 08 Jul 2021 at 09:41, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> Andrew Tropin <andrew@trop.in> writes:
>>> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>
>>>> Thank you. However, notmuch should be an input, there's no reason to
>>>> propagate it into user's profile.
>>>
>>> There is a (require 'notmuch) in consult-notmuch code, so we need
>>> notmuch.el on the load-path, sadly, but we don't have a separate
>>> emacs-notmuch package for it and therefore we have to propagate the
>>> whole notmuch package here :(
>>
>> Duh! You're right, of course.
>
> For my personal understanding because I am not familiar with Emacs
> packages and package propagation.  The package ’emacs-magit’ has ’git’
> as inputs and AFAIK it does not work without Git installed in the
> profile.  Why is it different?

The magit package itself will be loaded correctly, because its emacs
package requirements are satisfied and even some functions will work,
for example magit-dispatch will show a transient interface.  Other
functions that rely on git binary will throw an error and there are two
solutions for that: make a git a propagated input or set
`magit-git-executable` to a path to the git binary inside store, which
will make magit work with git as a regular input.

notmuch in contrast to git provides not only notmuch binary, but also
notmuch.el.  consult-notmuch requires only notmuch.el, which have to be
propagated and doesn't depend on notmuch binary, but because notmuch.el
is a part of notmuch package the binary will be propagated too.  The
possible solution here is to split notmuch into two packages: notmuch and
emacs-notmuch, so we will be able to set `notmuch-command` variable for
notmuch.el and have notmuch as an input, but not installed in the profile.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

  parent reply	other threads:[~2021-07-08 10:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 13:59 [bug#49457] [PATCH] gnu: Add emacs-consult-notmuch Andrew Tropin
2021-07-07 14:12 ` [bug#49457] [PATCH v2] " Andrew Tropin
2021-07-07 14:18   ` Nicolas Goaziou
2021-07-07 14:33     ` Andrew Tropin
2021-07-08  7:41       ` Nicolas Goaziou
2021-07-08  9:13         ` zimoun
2021-07-08  9:41           ` Nicolas Goaziou
2021-07-08 11:28             ` Kyle Meyer
2021-07-08 11:38               ` Nicolas Goaziou
2021-07-09  0:13                 ` Kyle Meyer
2021-07-08 10:14           ` Andrew Tropin [this message]
2021-07-08  7:40   ` bug#49457: " Nicolas Goaziou
2021-07-08 10:22     ` [bug#49457] " Andrew Tropin
2021-07-08 10:32       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r893yet.fsf@trop.in \
    --to=andrew@trop.in \
    --cc=49457@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).