From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QKajKmvl72D6jwAAgWs5BA (envelope-from ) for ; Thu, 15 Jul 2021 09:36:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CASsJGvl72BpRQAA1q6Kng (envelope-from ) for ; Thu, 15 Jul 2021 07:36:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5578764F0 for ; Thu, 15 Jul 2021 09:36:11 +0200 (CEST) Received: from localhost ([::1]:44520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3vuk-00089h-D8 for larch@yhetil.org; Thu, 15 Jul 2021 03:36:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3vuc-00089Y-MV for guix-patches@gnu.org; Thu, 15 Jul 2021 03:36:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3vuc-0002nJ-Ep for guix-patches@gnu.org; Thu, 15 Jul 2021 03:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3vuc-00070A-DS for guix-patches@gnu.org; Thu, 15 Jul 2021 03:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49482] [PATCH 3/3] ci: Properly construct URLs. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Jul 2021 07:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49482 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 44906@debbugs.gnu.org, 49482@debbugs.gnu.org Received: via spool by 49482-submit@debbugs.gnu.org id=B49482.162633454426877 (code B ref 49482); Thu, 15 Jul 2021 07:36:02 +0000 Received: (at 49482) by debbugs.gnu.org; 15 Jul 2021 07:35:44 +0000 Received: from localhost ([127.0.0.1]:46675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3vuK-0006zP-Ld for submit@debbugs.gnu.org; Thu, 15 Jul 2021 03:35:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3vuJ-0006zA-8m; Thu, 15 Jul 2021 03:35:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39612) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3vuD-0002PG-CE; Thu, 15 Jul 2021 03:35:37 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=34772 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3vu8-0005j1-Vf; Thu, 15 Jul 2021 03:35:36 -0400 From: Mathieu Othacehe References: Date: Thu, 15 Jul 2021 09:35:31 +0200 In-Reply-To: (Hartmut Goebel's message of "Fri, 9 Jul 2021 10:38:40 +0200") Message-ID: <871r80do70.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626334571; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=DfiML/r9sw4jOJQdQTIEb6a7/GaPza/GMtzbFv2EUt8=; b=uusKxlAdALwatmfYlL9T7OxfwEhkLmM8v12J6UDOnmxqHEmSkywq4aTxLLbJdxXGuTktGs +GQYSQjyXkkZq35Kn6O9nsxJUMkreNAoicF/nGXebnDubrzjbTPCgrmbhs1SDYJSrmpyuz GmA5yIJeBrtzrHAtixpv9ommpYAN1fcxKVTHG98BV9OtfKP2XYFaKgmdWT1iwexhJGGPbv RLSDQtOAh3qAXPW3t+fzUv/UWlBlSKC+klopu0oDULkycbXX3PtZ732YJY7LOguuITIjC/ wB2eMel9FfwIaY9APpCiqfebeIvhiCg5tAWGDWzQ6EBZdfpyWRHLMq7IHJdv+Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626334571; a=rsa-sha256; cv=none; b=QXI/hvMsb5BNfma5ZVun6GShK0pXQWMBjVtJX2rUnt2d9nCv6qjn/EffvVXLg7mWMZCCMg h8GQoKNX7ri4PdxAAvi0bm5Aw47dNAwR+d0OhlERwM46ggx/xoiTlpongJ7xaU4KtlddX7 +8zYBqs/HaCglD7cCSSvus5mnW3CxBBQkv4LD71R/ZUl/27PbIF/pkfZjO5is9SYU0t198 PKpW/xTAMzRttZI48rgWCuE2VO3uyPzzSFaw+myLDqR50TGg3B8lGLaXzSGnVG2BmAkAXE PCncpefsyxYpPIKqFmpIq6mJoIQrSbu5OSY9UU1JMFaFUUCr68E+WVNgPLT9NQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5578764F0 X-Spam-Score: -2.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: a79yNTMFhGII Hello Hartmut, Thanks for this patchset! > +(define* (api-url base-url path #:rest query) > + "Build a proper API url, taking into account BASE_URL's trailing slashes." s/BASE_URL/BASE-URL/ You could also indicate what is the expect format for query: '("name" "value") lists. > + (((_ #f) . rest) (lp rest acc)) > + (((name val) . rest) > + (lp rest (cons* > + name "=" > + (if (string? val) (uri-encode val) (number->string val)) What about booleans? False is filtered above but true will throw an exception. > + (resolve-uri-reference ref base))) > + > + There's an extra new line here. > +(define* (json-api-fetch base-url path #:rest query) > + (json-fetch (apply api-url base-url path query))) > + > + Here also. Otherwise, it looks nice :) Thanks, Mathieu