unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Collin J. Doering" <collin@rekahsoft.ca>
To: "Adolfo De Unánue" <adolfo@unanue.mx>
Cc: 50374@debbugs.gnu.org
Subject: [bug#50374] (no subject)
Date: Thu, 16 Sep 2021 09:38:31 -0400	[thread overview]
Message-ID: <871r5ohbxj.fsf@rekahsoft.ca> (raw)
In-Reply-To: <875yv5sr0z.fsf@unanue.mx>

Hi Adolfo,

I am not a guix expert either and am relatively new to the project. I
actually asked about this topic on guix IRC, where folks there suggested
splitting it into another package. I see very little difference between
including the org-roam-extensions as a separate package output, or as a
standalone package. I feel that having it as an additional output is
more "pure", but found that many packages already use a standalone
package for extensions, and I found that doing it in this way made both
packages themselves easier to define. You can see this for yourself with
a query like this `guix package -s '.*-extensions$' | recsel -CP name`.

Hope this helps, and kind regards!

On 12 Sep 2021 at 11:19, Adolfo De Unánue <adolfo@unanue.mx> wrote:

> Hi
>
> I am the author of the patch https://issues.guix.gnu.org/50333 (my first
> patch, so I am a newbie on this).
>
> Could you help me to understand why your proposal is a better solution?
> I want to learn how to approach to this matters in the future.
>
> My rationale is that the extensions folder *is* part of org-roam, that's
> why I *added* them to the original package.
>
> Also, Do we need to do something in order to get this patch (or mine)
> approved?
> (again, just asking because this workflow is new for me)
>
> Thanks in advance for your time


-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca




  reply	other threads:[~2021-09-16 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-04 16:12 [bug#50374] [PATCH 0/1] Add org-roam-extensions package Collin J. Doering
2021-09-04 16:19 ` [bug#50374] [PATCH 1/1] gnu: Add emacs-org-roam-extensions Collin J. Doering
2021-09-12 16:19 ` [bug#50374] (no subject) Adolfo De Unánue
2021-09-16 13:38   ` Collin J. Doering [this message]
2021-09-14 12:30 ` [bug#50374] [PATCH 0/1] Add org-roam-extensions package zimoun
2021-09-16 13:48   ` Collin J. Doering
2022-01-16 23:31 ` bug#50374: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r5ohbxj.fsf@rekahsoft.ca \
    --to=collin@rekahsoft.ca \
    --cc=50374@debbugs.gnu.org \
    --cc=adolfo@unanue.mx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).