From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cAkaAwYWr2GYXwAAgWs5BA (envelope-from ) for ; Tue, 07 Dec 2021 09:06:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CM6tOgUWr2GbGgAA1q6Kng (envelope-from ) for ; Tue, 07 Dec 2021 08:06:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C5ADD3A293 for ; Tue, 7 Dec 2021 09:06:29 +0100 (CET) Received: from localhost ([::1]:46946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muVUa-00009T-Uk for larch@yhetil.org; Tue, 07 Dec 2021 03:06:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muVUA-000082-Bl for guix-patches@gnu.org; Tue, 07 Dec 2021 03:06:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muVUA-0003Ig-3H for guix-patches@gnu.org; Tue, 07 Dec 2021 03:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1muVU9-0000xn-Qu for guix-patches@gnu.org; Tue, 07 Dec 2021 03:06:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52283] [PATCH 02/10] transformations: Add '--tune'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Dec 2021 08:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52283 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thiago Jung Bauermann Cc: 52283@debbugs.gnu.org Received: via spool by 52283-submit@debbugs.gnu.org id=B52283.16388643083634 (code B ref 52283); Tue, 07 Dec 2021 08:06:01 +0000 Received: (at 52283) by debbugs.gnu.org; 7 Dec 2021 08:05:08 +0000 Received: from localhost ([127.0.0.1]:36277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muVTH-0000wX-6m for submit@debbugs.gnu.org; Tue, 07 Dec 2021 03:05:07 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:14152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muVTD-0000vv-Eo for 52283@debbugs.gnu.org; Tue, 07 Dec 2021 03:05:05 -0500 IronPort-Data: A9a23:Gfxdr6qPo79ckWM0Ej0kdHaWOb9eBmIzZxIvgKrLsJaIsI5as4F+vjMfX23TPqyDMTT3f9EjYY6/8R5VuJfRnYRiTlRp+yk3QiMRo6IpJ/zJdxaqZ3v6wu7rFR88sZ1GMrEsFC2FJ5Pljk/F3oPJ8D8sislkepKmULSdY3opGlc9IMscoUkLd9AR09cAbeeRU1vlVePa+6UzCXf9s9JGGjp8B5Gr9HuDiM/PVAYw5TTSUxzkUGj2zBH5BLpHTU24wuCRroN8RoZWTM6bpF21E/+wwvsjNj+luu6TnkwiWL/YNw+I4pZUc/Hz2V4f/mpri/59baBEAatUo2zhc9RZzMhBsoKxQkEiObDWhOkGexheCSB3e6NckFPCCSju7ZXNlxGun3zEhq8G4FsNFdBCoLYsKW1D//YFJytLYRaeweWsz9qTQOBxi94mJc/tFIAYvnhqyzbGS/0hRPj+rw/ijTND9G5h3YYTRbCHPpJfMGA3BCksqiZnYj8/YK/SVs/x7pUnTwBllQ== IronPort-HdrOrdr: A9a23:9owgCKzASbmVgkLPh/0GKrPw9L1zdoMgy1knxilNoH1uA7WlfqWV9oVi6faasl0ssR0b9exoe5PwJk80jKQFg7X5ZI3SOTUO21HYSr2Kj7GC/9SIIUSXygc678hdmsNFZuEYY2IWsS5hizPId+oI8Z2Kzajtuf3T1B5WPGJXQpAl4zpwTgySFlR/RAdAbKBYKKah X-IronPort-AV: E=Sophos;i="5.87,293,1631570400"; d="scan'208";a="8941604" Received: from unknown (HELO ribbon) ([193.50.110.120]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2021 09:04:57 +0100 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211204204924.15581-1-ludo@gnu.org> <20211204204924.15581-2-ludo@gnu.org> <7364829.rrRS6mQaNJ@popigai> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 Frimaire an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 07 Dec 2021 09:04:56 +0100 In-Reply-To: <7364829.rrRS6mQaNJ@popigai> (Thiago Jung Bauermann's message of "Mon, 06 Dec 2021 20:18:51 -0300") Message-ID: <871r2olu1j.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638864389; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=uJ4OWQYQiCYg4OP+chfA//Mcgy7zGS5DOj9kASWaMFQ=; b=Bk4h9kybFh8SxY/86JiwFxVYHKu4f6dPqwfQZ4sEVqNxSEmMm48594lY/Zppe3YhzIyUum JSrrSGZ6jXedjwfiMw0BF8nUCsqKftStaqW3il60/1RxWtombhrTdfeEPbq0CCGQXtdH1q Xt11YbXjokShtzA7OVp0OT1FWf+44TGDW88Vrj5jiOu+umOjZc8oosi06MFHjE3nRvpELp On6JNhWWGuhrLZueOHq3F4JK5WOcVmq1WEO3rm2bfqV097Z2MhVEDDyWDAw4cYfv4Z7OVT AuCNhuf2sJO8Xk95P64i1sXD3RSPMTFHltSIKDJwk8MLYKjOT1aFofIvBBI8Sg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638864389; a=rsa-sha256; cv=none; b=c/0aNpVCh9Ol8mDjYGwRfmNtMQwJWEC0iXrTW03TyEe+EyPZwndPCHwTL9vss3lvG9eVNY TGfMvu6fMfkuFghxOKl+SVIWGIniDffL3vaBMKRsgoVruXTs/hsLBIxeLAcrHnKQuXELRj +dSm1jl3oK0uyF4emLh4qkopamfAxQcmMLWthNOF6U6eWdke7Dn4HqLugNvqbaUFIucYPh UzVQ5o5FDd5VvQd9xYHBJ0S5S3ObufoQfpIk+fJq23YNQvhkKqzfUDN/w5uPNcJdOJWcsn Yythg9HOSOXvSySPC+9bGGjVJImeNu3WR+IDwPQ5Nt5d2vG4mh3VJwCO6KCb1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.14 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C5ADD3A293 X-Spam-Score: -3.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZURe0+A+NhAd Hi Thiago, Thiago Jung Bauermann skribis: > Em s=C3=A1bado, 4 de dezembro de 2021, =C3=A0s 17:49:16 -03, Ludovic Cour= t=C3=A8s=20 > escreveu: >> +Tuned packages are @emph{grafted} onto packages that depend on them >> +(@pxref{Security Updates, grafts}). Thus, using @option{--no-grafts} >> +annihilates the effect of @option{--tune}. > > Perhaps this is because English isn=E2=80=99t my first language, but anni= hilation=20 > seems like a violent and dramatic effect in a package transformation. :-) > > Perhaps reword as =E2=80=9Ccancels=E2=80=9D, =E2=80=9Cinvalidates=E2=80= =9D or "nullifies"? Not a native speaker either but yes, =E2=80=9Ccancels=E2=80=9D sounds bette= r; I=E2=80=99ll change that. >> +(define (tuned-package p micro-architecture) >> + "Return package P tuned for MICRO-ARCHITECTURE." >> + (define compiler >> + (tuning-compiler micro-architecture)) >> + >> + (package >> + (inherit p) >> + (native-inputs >> + ;; Arrange so that COMPILER comes first in $PATH. >> + `(("tuning-compiler" ,compiler) >> + ,@(package-native-inputs p))) >> + (arguments >> + (substitute-keyword-arguments (package-arguments p) >> + ((#:tests? _ #f) #f))) > > Perhaps I=E2=80=99m reading this wrong, but it looks like tuned packages = don=E2=80=99t run=20 > their testsuites? If so, this is a surprising side-effect and thus it wou= ld=20 > be nice to have it mentioned in the manual, possibly also in a comment=20 > here. It would be nice to also mention the rationale for disabling the=20 > tests (not sure whether only in a comment here or if in the manual as=20 > well). I assume it=E2=80=99s for convenience, but I=E2=80=99m not sure. I agree, a comment and maybe a sentence in the manual would be welcome. The reason the test suite is skipped is because we cannot know for sure whether the machine that hosts the daemon is able to run code for this specific micro-architecture. The test suite runs in the =E2=80=9Cbaseline=E2=80=9D package build anyway,= so assuming the compiler works fine, skipping the test suite on tuned builds is okay. Thanks for your feedback! Ludo=E2=80=99.