unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Taiju HIGASHI <higashi@taiju.info>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 52576@debbugs.gnu.org
Subject: [bug#52576] [PATCH] gnu: ibus-anthy: Update to 1.15.12
Date: Thu, 23 Dec 2021 14:44:29 +0900	[thread overview]
Message-ID: <871r23c1tu.fsf@taiju.info> (raw)
In-Reply-To: <871r24z3hp.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 22 Dec 2021 23:20:02 +0100")

Ludovic Courtès <ludo@gnu.org> writes:

Hi Lidovic,

Thank you for the response.

> Would it be possible to arrange to skip only the test(s) that expect to
> run interactively?  It would be more robust than skipping all the
> tests.

I've been working on a fix for the last few days that would allow me to
avoid skipping tests, but it's very difficult for me.

I tried to refer to how the major distributions implement it, but all of
the following seem to skip the test.

Arch:
https://github.com/archlinux/svntogit-community/blob/dce2fe2721db394fdf91cea5268dc9d636df0249/trunk/PKGBUILD

Gentoo:
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-i18n/ibus-anthy/ibus-anthy-1.5.13.ebuild?id=fc38e3f625d2aee08a90e2eb19a80ccadf945094

Debian:
http://deb.debian.org/debian/pool/main/i/ibus-anthy/ibus-anthy_1.5.13-1.debian.tar.xz

The reason for skipping the tests in the Debian build process was described as follows.

> we do not make test for now since it needs a running ibus-daemon instance.

It is my understanding that the tests run by `make check` require `make install`.

> Hi,
>
> Taiju HIGASHI <higashi@taiju.info> skribis:
>
>> I'm using GNOME (40.4) with Guix, and version 1.5.9 of ibus-anthy had
>> a problem with ibus-anthy not being able to save settings.
>>
>> I'm assuming this is the cause, since the release notes say that
>> ibus-anthy version 1.5.10 includes a fix for migrating from dConf to
>> GSettings.
>
> Good.
>
>> 1.5.10 adds a test, but I skipped running the test.  I wish I had a
>> better solution, but the fix including the test was difficult for me.
>> It also included tests for users to enter values in dialogs and to
>> update files under their home directories, so I thought it would be
>> better to skip the tests.
>
> Would it be possible to arrange to skip only the test(s) that expect to
> run interactively?  It would be more robust than skipping all the tests.
>
> Other than that the change LGTM.
>
> BTW current ‘master’ has GNOME 41; it would be good to see how things
> work now.
>
> Thanks,
> Ludo’.




  reply	other threads:[~2021-12-23  5:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 13:40 [bug#52576] [PATCH] gnu: ibus-anthy: Update to 1.15.12 Taiju HIGASHI
2021-12-17 16:54 ` Taiju HIGASHI
2021-12-22 22:20 ` Ludovic Courtès
2021-12-23  5:44   ` Taiju HIGASHI [this message]
2021-12-24  9:25   ` Taiju HIGASHI
2021-12-24  9:33   ` Taiju HIGASHI
2021-12-24 23:18 ` [bug#52576] [PATCH v2] gnu: ibus-anthy: Update to 1.5.14 Taiju HIGASHI
2022-02-06 15:56 ` [bug#52576] About the upgrade of ibus-anthy Taiju HIGASHI
2022-02-06 20:51   ` Liliana Marie Prikler
2022-02-07  3:03     ` Taiju HIGASHI
2022-02-07 14:50       ` Julien Lepiller
2022-02-07 15:51         ` Taiju HIGASHI
2022-06-24  2:53         ` bug#52576: [PATCH] gnu: ibus-anthy: Update to 1.15.12 Maxim Cournoyer
2022-06-24  3:10           ` [bug#52576] " Taiju HIGASHI
2022-06-24  4:21           ` Liliana Marie Prikler
2022-06-24 14:50             ` Maxim Cournoyer
2022-06-28  8:43 ` Alice BRENON
2022-06-29  8:50   ` Taiju HIGASHI
2022-06-29  9:25     ` Taiju HIGASHI
2022-06-29 13:46       ` Alice BRENON
2022-06-29 14:06         ` Taiju HIGASHI
2022-06-29 14:19           ` Taiju HIGASHI
2022-06-29 14:35             ` Alice BRENON
2022-06-29 14:49               ` Taiju HIGASHI
2022-06-29 14:56                 ` Taiju HIGASHI
2022-06-30  2:25               ` Maxim Cournoyer
2022-06-30 20:15                 ` Alice BRENON
2022-07-01  4:22                 ` Liliana Marie Prikler
2022-07-02  0:14                   ` Liliana Marie Prikler
2022-07-03  1:13                     ` Dominic Martinez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r23c1tu.fsf@taiju.info \
    --to=higashi@taiju.info \
    --cc=52576@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).