From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eGDgD/bc3WHzQAEAgWs5BA (envelope-from ) for ; Tue, 11 Jan 2022 20:39:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mBR9CPbc3WHJ5wAAG6o9tA (envelope-from ) for ; Tue, 11 Jan 2022 20:39:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C64993940B for ; Tue, 11 Jan 2022 20:39:33 +0100 (CET) Received: from localhost ([::1]:35982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7MzU-0007yz-V0 for larch@yhetil.org; Tue, 11 Jan 2022 14:39:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7Mz3-0007vL-1M for guix-patches@gnu.org; Tue, 11 Jan 2022 14:39:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34488) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7Mz0-0005vR-Je for guix-patches@gnu.org; Tue, 11 Jan 2022 14:39:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7Mz0-00070x-G2 for guix-patches@gnu.org; Tue, 11 Jan 2022 14:39:02 -0500 Subject: bug#53034: [PATCH] shell: Cache profiles even when using package specs. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 11 Jan 2022 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53034 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53034-done@debbugs.gnu.org Mail-Followup-To: 53034@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 53034-done@debbugs.gnu.org id=D53034.164192988326794 (code D ref 53034); Tue, 11 Jan 2022 19:39:02 +0000 Received: (at 53034-done) by debbugs.gnu.org; 11 Jan 2022 19:38:03 +0000 Received: from localhost ([127.0.0.1]:55623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7My3-0006y6-AI for submit@debbugs.gnu.org; Tue, 11 Jan 2022 14:38:03 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:35394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7My0-0006xT-5J for 53034-done@debbugs.gnu.org; Tue, 11 Jan 2022 14:38:02 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AB6F86E6 for <53034-done@debbugs.gnu.org>; Tue, 11 Jan 2022 20:37:53 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XH3euaBEL5_0 for <53034-done@debbugs.gnu.org>; Tue, 11 Jan 2022 20:37:53 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id BBE66F2 for <53034-done@debbugs.gnu.org>; Tue, 11 Jan 2022 20:37:52 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220105184500.12171-1-ludo@gnu.org> Date: Tue, 11 Jan 2022 20:37:52 +0100 In-Reply-To: <20220105184500.12171-1-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 5 Jan 2022 19:45:00 +0100") Message-ID: <871r1et65r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: AB6F86E6 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[53034-done@debbugs.gnu.org]; RCPT_COUNT_ONE(0.00)[1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641929973; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=+sXnjTpprUvCSpknhCG4YsY1Cj8E1TTFcUftDcQcGFI=; b=YtEy+DE9rErU/RQOqNTUl4UwJYr52iJS+z3o+PwbpdvklzTrG0PsH8+xEagTaBOqqLUWKt jkVZ4a5fKZp8iq+1U7HgQT5aZxrq8fOgjWs1+a/LowkDVMqEOWsQ11bnGMt6YEk8NTNkdZ Of4HDX7U3EOEGkAeMsWRGSVTnZa/doXoU0zQJUq6/ucawYarp6rK/8jQ+pt53m7KA1j1TN Gtfks/PNTZWnN/9VAwZ9f9xBhBkfiibi7Lr6G0QmN6gLxixWrZrv8PXoYz2chSnNwidrsO eCVk7+5pqqH4EjO5829T9hiXxNKKxF9Jzd88+wiuAymnkjfteJESA+elIQo/TQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641929973; a=rsa-sha256; cv=none; b=lSx6HPr3/ElTnOjjujndJN3qgrL26J92RU46CLTW3clNeoiab8MawIi7KXdjI/hGCNA+WG cv1OfklxnIGQXHcqE/UEdDXif3NklBZdmD9+wtocKR9hNwwrK9VrPl4UgvGlenQckkD/ws bCP6+BsVwXLnEr+SNzIN+ajacgdmwsbArCFzCDGHHju5VsBuMwISwFboszaSOQYd96/UYJ ce6sulGNV+4gU+pDTg84NPcq9LOzKTEz3F0Li/R0Fe/GISs+mS00S39cGDhLkGSmXznu0j /yI+O4KJUHM2cXIG1GBFN58L78eqP5NI95X/yp6nWuuMGICnVFntJzVA6UqMIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.62 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C64993940B X-Spam-Score: -3.62 X-Migadu-Scanner: scn1.migadu.com X-TUID: eivFmDdl6Mti Ludovic Court=C3=A8s skribis: > This enables profile caching not just when '-m' or '-f' is used, but > also when package specs are passed on the command line, as in: > > guix shell -D guix git > > It also changes profile cache keys to include the system type, which was > previously ignored. > > * guix/scripts/shell.scm (options-with-caching)[single-file-for-caching]: > Remove. > Call 'profile-cached-gc-root' instead; adjust to accept two values. > (profile-cache-primary-key): New procedure. > (profile-cache-key): Remove. > (profile-file-cache-key, profile-spec-cache-key): New procedures. > (profile-cached-gc-root): Rewrite to include functionality formally in > 'single-file-for-caching', but extend to handle package specs. > * gnu/packages.scm (cache-is-authoritative?): Export. > * guix/transformations.scm (transformation-option-key?): New procedure. Pushed as 0552dcb294bbfed76d7a495f5e368c53f20b852a. I adjusted doc/guix.texi, which I had forgotten to do in the patch I posted. Please let me how caching works for you! Ludo=E2=80=99.