From: "Ludovic Courtès" <ludo@gnu.org>
To: Jack Hill <jackhill@jackhill.us>
Cc: 55253@debbugs.gnu.org
Subject: [bug#55253] nginx-rtmp-module not compatible with nginx
Date: Mon, 23 May 2022 14:57:58 +0200 [thread overview]
Message-ID: <871qwk8kyx.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220522055157.31807-1-jackhill@jackhill.us> (Jack Hill's message of "Sun, 22 May 2022 01:51:56 -0400")
Hi Jack,
Jack Hill <jackhill@jackhill.us> skribis:
> * gnu/packages/web.scm (nginx-rtmp-module)[arguments]: Simplify copying
> of arguments from nginx and augment #:configure-flags from nginx
> rather than overwriting.
> ---
> gnu/packages/web.scm | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 600ef0c895..50401c07e1 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -785,12 +785,9 @@ (define-public nginx-rtmp-module
> `(("nginx-sources" ,(package-source nginx))
> ,@(package-inputs nginx)))
> (arguments
> - (substitute-keyword-arguments
> - `(#:make-flags '("modules")
> - #:modules ((guix build utils)
> - (guix build gnu-build-system))
> - ,@(package-arguments nginx)
> - #:configure-flags '("--add-dynamic-module=."))
> + (substitute-keyword-arguments (package-arguments nginx)
> + ((#:configure-flags flags)
> + #~(cons "--add-dynamic-module=." #$flags))
If I’m not mistaken, #:make-flags and #:modules are lost here, no?
Or were they unnecessary in the first place?
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-05-23 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.21.2205040013230.11587@marsh.hcoop.net>
2022-05-22 5:50 ` [bug#55253] [PATCH 0/2] nginx-rtmp-module use nginx's #:configure-flags and update to gexps in phases Jack Hill
2022-05-22 5:51 ` [bug#55253] [PATCH 1/2] gnu: nginx-rtmp-module: Use #:configure-flags from nginx Jack Hill
2022-05-22 5:51 ` [bug#55253] [PATCH 2/2] gnu: nginx-rtmp-module: Use gexps in phases Jack Hill
2022-05-23 12:57 ` Ludovic Courtès [this message]
2022-05-23 14:11 ` [bug#55253] nginx-rtmp-module not compatible with nginx Jack Hill
2022-05-27 2:02 ` Jack Hill
2022-05-27 2:04 ` [bug#55253] [PATCH v2 1/2] gnu: nginx-rtmp-module: Use #:configure-flags from nginx Jack Hill
2022-05-27 2:04 ` [bug#55253] [PATCH v2 2/2] gnu: nginx-rtmp-module: Use gexps in phases Jack Hill
2022-05-27 13:01 ` Christopher Baines
2022-05-27 21:47 ` bug#55253: " Jack Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qwk8kyx.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=55253@debbugs.gnu.org \
--cc=jackhill@jackhill.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).