From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mBUJAxox0mKEGgEAbAwnHQ (envelope-from ) for ; Sat, 16 Jul 2022 05:31:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SF/xAhox0mJhuQAA9RJhRA (envelope-from ) for ; Sat, 16 Jul 2022 05:31:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A1C43AC8C for ; Sat, 16 Jul 2022 05:31:37 +0200 (CEST) Received: from localhost ([::1]:36868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCYWm-0005am-Jo for larch@yhetil.org; Fri, 15 Jul 2022 23:31:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCYWE-0005Z7-6t for guix-patches@gnu.org; Fri, 15 Jul 2022 23:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCYWD-00010B-To for guix-patches@gnu.org; Fri, 15 Jul 2022 23:31:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCYWD-0005Vq-Ph for guix-patches@gnu.org; Fri, 15 Jul 2022 23:31:01 -0400 Subject: bug#56455: gnu: Drop emacs-transient, emacs-project input from four packages Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 16 Jul 2022 03:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 56455 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: "Jorge P. de Morais Neto" Cc: 56455-done@debbugs.gnu.org Mail-Followup-To: 56455@debbugs.gnu.org, maxim.cournoyer@gmail.com, jorge+git@disr.it Received: via spool by 56455-done@debbugs.gnu.org id=D56455.165794222121118 (code D ref 56455); Sat, 16 Jul 2022 03:31:01 +0000 Received: (at 56455-done) by debbugs.gnu.org; 16 Jul 2022 03:30:21 +0000 Received: from localhost ([127.0.0.1]:42635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCYVY-0005UX-As for submit@debbugs.gnu.org; Fri, 15 Jul 2022 23:30:20 -0400 Received: from mail-qv1-f48.google.com ([209.85.219.48]:40656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCYVU-0005UE-NB for 56455-done@debbugs.gnu.org; Fri, 15 Jul 2022 23:30:18 -0400 Received: by mail-qv1-f48.google.com with SMTP id g9so5002344qvq.7 for <56455-done@debbugs.gnu.org>; Fri, 15 Jul 2022 20:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=3L8h0uz9MPa38jo4YRbqJucEB9CPhRbGq1FThZs+OAE=; b=XPj8SBdtA7vO5FjwGuxtFIlSfF+ua4bUg/PN+bedM/oc+QiiZKhd/LKQ4LMtNsVwli CRhQEjixLaXJ3/7UfFgc9uMPdoHcnhlkK6Y8P4rcVZV+gke5gk3sQqguqPk+BD/6EaOl z761HOL8I0ejWHigKZGv+WznTdKNmHE7K2jD8gm+CMcHu35NIOKmFaTUW5B0DQNCyGJS 3ar7j5LrZK9Lof7qtiw1eiy4j7D7Ey/TQ9fHyvRKj4P+OLzousiu4TF7ehcYa8regJRe YbYNcKKicEdMoiig4Ef5pHdhoPK49MdxOGw7vuiu8D+TD+0CFNXbObdWFkOYD7Ljr3EC bGMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3L8h0uz9MPa38jo4YRbqJucEB9CPhRbGq1FThZs+OAE=; b=44y+GJwZ4wyRV9RosBoZP1ltAqnHxnlxJ5vdzmz8kgxQ96OrgFA7XR1/LKuIscHlxv ol7ezCaWCJolrg0hk59lDv3wiyXhCI4CrFVDfRoIUbir4hNmWB9SirFZWVNiiYc/Yv9r U4MSgcP6QFzTt9e0dfkEza2tfV4mCMWDVErltJh8//0OCjsNwhvR3MLs5fPMHt1sNi5W De5W3M1+o3trBPaG6uegY+/ByXD4pls+xiO8tjivKZ8nXdI2xxQkUh57vqoS0JIbuvm8 TsEamVwQ4JExzc4OPYjmvAwA1HyT/ofHdeOPaopn8iVWpVPnAGVY2j8YbMGiFG8suQwF 7rmQ== X-Gm-Message-State: AJIora/TClFAFDQab4DoCkUiQFqTMe9f+gX/o221zR/BCSOHSrbikTLq AruTXPnwNxhdEnR2+cKD9QL11FvVOh4iIzS+ X-Google-Smtp-Source: AGRyM1vRkc1TPWRVF5foJIXZCAwl+yrKG0AoptNkJNtkGQfUJ5OtItSLpMAhxGsQlqSi635TJPc2SA== X-Received: by 2002:a0c:a9d2:0:b0:472:f1c5:f309 with SMTP id c18-20020a0ca9d2000000b00472f1c5f309mr13988313qvb.35.1657942210723; Fri, 15 Jul 2022 20:30:10 -0700 (PDT) Received: from hurd (dsl-205-233-125-176.b2b2c.ca. [205.233.125.176]) by smtp.gmail.com with ESMTPSA id r5-20020ac85c85000000b0031ec83851ccsm3954712qta.38.2022.07.15.20.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 20:30:10 -0700 (PDT) From: Maxim Cournoyer References: <87ilo73gua.fsf@disr.it> Date: Fri, 15 Jul 2022 23:30:09 -0400 In-Reply-To: <87ilo73gua.fsf@disr.it> (Jorge P. de Morais Neto's message of "Fri, 08 Jul 2022 09:54:21 -0300") Message-ID: <871qulspj2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657942297; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3L8h0uz9MPa38jo4YRbqJucEB9CPhRbGq1FThZs+OAE=; b=YDSijVDLbx+bidg7diK/iqZi8v5KYLjbCkhVrwMuqtlSVeYL5/5+gLv5IEeJxOLfO1V+vh iG73Y/WH5GdZEzJVRQmtds/xkwVvq2bxxUYXyVyoTVvjTlkZpqXpFakoYMiNN6QtHpVK0G fn7g1L23ayo7BnGTDgsaJCb3OzeMIN5xUqrlQ4M0tduGhHkq0NzEcV27uoOifyDV7/w/HH MQnm9buyxVJQSBpomBY6El4t+F9X4cyVdPFAtbiy71CpqmlPhYfdxA/b91uRHqfpfcnh7d 0fXXO4k+Fw45XnWQd0Y8hLITscT5mcvXjEQxMgKDy+8S+2L0UvXf89+EkxQVHA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657942297; a=rsa-sha256; cv=none; b=DG7qNqiq5NdJxbpKVxXK9Ixj5/WZU/sYDgsnhz/oFW66MJV0EMa9vqypnwIHnKsO32VvVR +OZ3EyUvWf+88uoNnR5hu2CcS3oosWjWYMR5nG0M9AMfi2oy8rVAlm2qKZyfkC1CMYI1Zl mSCnhwiG50biJwyuIWFY6eXU5Lw25sa3TgGtfFml0ZnVGGvimmoLj7UDzf9791fd0dcFTp ktsnLgJ17pYFqq1riTubhX8cMgzPZfZHyQj39Zlcb8VjaUDXwXOVqtvoqWhzcj9JzLHFUO j37hexj4I5mctkj5hmTGMut9f/tLmcM2EyNHzGcglQC1ATvUzIP6SWT2Pagb4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=XPj8SBdt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=XPj8SBdt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8A1C43AC8C X-Spam-Score: 4.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: a8U15sNxMhLq Hi Jorge, "Jorge P. de Morais Neto" writes: > Hi. I apologize for any mistakes and welcome feedback. This is my > first patch to Guix; let's hope that many others will follow! I see low > hanging fruits: including the several other Emacs packages still > unnecessarily pulling emacs-transient, emacs-project and other Elisp > libraries that are now builtin. Thanks for this first patch of yours :-). > I have been using these modified packages. I have also checked this > patch with ~guix lint~ and ~guix build --check~. The four packages > build well; the only warning messages were: > > In git-timemachine-completing-read-fn: > git-timemachine.el:101:8: Warning: docstring wider than 80 characters > > In git-timemachine--find-new-current-line: > git-timemachine.el:259:8: Warning: docstring wider than 80 characters > > In git-timemachine--get-cursor-position: > git-timemachine.el:294:8: Warning: docstring wider than 80 characters > > In git-timemachine--set-cursor-position: > git-timemachine.el:300:8: Warning: docstring wider than 80 characters > git-timemachine.el:347:1: Warning: =E2=80=98define-transient-command=E2= =80=99 is an obsolete > alias (as of Transient 0.3.0); use =E2=80=98transient-define-prefix= =E2=80=99 instead. > > In end of data: > git-timemachine.el:247:19: Warning: the function =E2=80=98erm-reset-buffe= r=E2=80=99 is not > known to be defined. > > geiser-autodoc.el:69:12: Warning: =E2=80=98eldoc-message=E2=80=99 is an o= bsolete function (as > of eldoc-1.1.0); use =E2=80=98eldoc-documentation-functions=E2=80=99 = instead. > > git-commit-pkg.el:1:2: Warning: the function =E2=80=98define-package=E2= =80=99 is not known to > be defined. I suppose they run fine as well? The patch seems reasonable to me. I'll offer a few cosmetic comments below to adjust for some conventions. >>>From a0a682e6e4b53282e9e45703c870132310764f3c Mon Sep 17 00:00:00 2001 > From: "Jorge P. de Morais Neto" > Date: Fri, 8 Jul 2022 09:23:29 -0300 > Subject: [PATCH] gnu: Drop emacs-transient, emacs-project input from four > packages > > Drop emacs-transient (and emacs-project) propagated input from: > - emacs-git-timemachine > - emacs-ytdl > - emacs-geiser > - emacs-magit > > I use Guix package manager (manually installed) atop Debian bullseye. My > Emacs is from Guix package emacs-next with a package transformation optio= n to > pull from current Git master. When trying to use the new emoji commands = on > the "C-x 8e" prefix, I got an error message about transient. I solved it= by > modifying Guix recipes to not pull emacs-transient as propagated input of= some > Emacs packages I installed via Guix. > > Guix packages Emacs 28.1 and emacs-next 29.0.50, and both have Transient > built-in. Therefore, pulling transient external package it as propagated > input of other packages is wasteful redundancy, and, worse, causes errors. > >>>From emacs-geiser also drop emacs-project (also builtin on Emacs 28.1). > > For emacs-ytdl also add the required emacs-dash dependency. > > See email message ID 87sfnhalvo.fsf@disr.it on guix-devel mailing list. > > Several other unnecessary dependencies on builtin Emacs libraries (includ= ing > transient and project) probably remain on emacs-xyz. If you look at other git logs using "git log" on the repository, you'll see that most changes are authored in the GNU ChangeLog style, which is summarily described in the GNU standards document, which can be installed with 'guix install gnu-standards' and consulted with info "(standards) Change Logs". > --- > gnu/packages/emacs-xyz.scm | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 2e259287b8..b68a15bc4a 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -278,8 +278,6 @@ (define-public emacs-geiser > "-o" "geiser.info" "geiser.texi"))))))) > (native-inputs > (list texinfo)) > - (propagated-inputs > - (list emacs-project emacs-transient)) > (home-page "https://www.nongnu.org/geiser/") > (synopsis "Collection of Emacs modes for Scheme hacking") > (description > @@ -1005,7 +1003,7 @@ (define-public emacs-magit > (inputs > (list git perl)) > (propagated-inputs > - (list emacs-dash emacs-transient emacs-with-editor)) > + (list emacs-dash emacs-with-editor)) > (home-page "https://magit.vc/") > (synopsis "Emacs interface for the Git version control system") > (description > @@ -4646,8 +4644,6 @@ (define-public emacs-git-timemachine > (base32 > "1pz4l1xnq6s67w5yq9107vm8dg7rqf8n9dmbn90jys97c722g70n")))) > (build-system emacs-build-system) > - (propagated-inputs > - (list emacs-transient)) > (home-page "https://gitlab.com/pidu/git-timemachine") > (synopsis "Step through historic versions of Git-controlled files") > (description "This package enables you to step through historic vers= ions > @@ -23308,7 +23304,7 @@ (define-public emacs-ytdl > (inputs > (list youtube-dl)) > (propagated-inputs > - (list emacs-async emacs-transient)) > + (list emacs-async emacs-dash)) > (home-page "https://gitlab.com/tuedachu/ytdl") > (synopsis "Emacs interface for youtube-dl") > (description Packaging changes in Guix are usually prepared per package, that is, one commit per package touched, something like this: --8<---------------cut here---------------start------------->8--- gnu: emacs-geiser: Use builtin project and transient libraries. These libraries are now included in Emacs 28. * gnu/packages/emacs-xyz.scm (emacs-geiser)[propagated-inputs]: Delete fiel= d. 1 file changed, 2 deletions(-) gnu/packages/emacs-xyz.scm | 2 -- modified gnu/packages/emacs-xyz.scm @@ -278,8 +278,6 @@ (define-public emacs-geiser "-o" "geiser.info" "geiser.texi"))))))) (native-inputs (list texinfo)) - (propagated-inputs - (list emacs-project emacs-transient)) (home-page "https://www.nongnu.org/geiser/") (synopsis "Collection of Emacs modes for Scheme hacking") (description --8<---------------cut here---------------end--------------->8--- and: --8<---------------cut here---------------start------------->8--- gnu: emacs-magit: Use builtin transient library. The transient library is now included in Emacs 28. * gnu/packages/emacs-xyz.scm (emacs-magit) [propagated-inputs]: Delete emacs-transient. Signed-off-by: Maxim Cournoyer 1 file changed, 1 insertion(+), 1 deletion(-) gnu/packages/emacs-xyz.scm | 2 +- modified gnu/packages/emacs-xyz.scm @@ -1008,7 +1008,7 @@ (define-public emacs-magit (inputs (list git perl)) (propagated-inputs - (list emacs-dash emacs-transient emacs-with-editor)) + (list emacs-dash emacs-with-editor)) (home-page "https://magit.vc/") (synopsis "Emacs interface for the Git version control system") (description --8<---------------cut here---------------end--------------->8--- etc. I've made these adjustments for you since it's your first commit, and pushed the master branch; you can see your change partitioned as 4 commits with: --8<---------------cut here---------------start------------->8--- $ git log 6ff3fe86b5f72c982b59cd4c8b7fc3295961a9a7^..82fa1a38e7fab036c62ca9= cfc396286ca007e456 --8<---------------cut here---------------end--------------->8--- Thank you for this first contribution! I look forward to see more :-). Maxim