From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KHD0LByo62IPEQAAbAwnHQ (envelope-from ) for ; Thu, 04 Aug 2022 13:06:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CDMGLRyo62LyTwAA9RJhRA (envelope-from ) for ; Thu, 04 Aug 2022 13:06:04 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5619D38D6A for ; Thu, 4 Aug 2022 13:06:04 +0200 (CEST) Received: from localhost ([::1]:58278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJYfz-0006db-CH for larch@yhetil.org; Thu, 04 Aug 2022 07:06:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJYf0-0006Sf-RY for guix-patches@gnu.org; Thu, 04 Aug 2022 07:05:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJYf0-00040a-Ax for guix-patches@gnu.org; Thu, 04 Aug 2022 07:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJYf0-0001Zk-6f for guix-patches@gnu.org; Thu, 04 Aug 2022 07:05:02 -0400 Subject: bug#54439: [PATCH core-updates] gnu: rust: Use rust-1.60.0 Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 04 Aug 2022 11:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54439 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jim Newsome , 54439-done@debbugs.gnu.org, Maxime Devos Cc: paul@unnservice.com, kiasoc5@tutanota.com, Efraim Flashner , Felipe Balbi , Pierre Langlois , 56684-done@debbugs.gnu.orgPaulAlesius Mail-Followup-To: 54439@debbugs.gnu.org, marius@gnu.org, paul@unnservice.com Received: via spool by 54439-done@debbugs.gnu.org id=D54439.16596110676007 (code D ref 54439); Thu, 04 Aug 2022 11:05:01 +0000 Received: (at 54439-done) by debbugs.gnu.org; 4 Aug 2022 11:04:27 +0000 Received: from localhost ([127.0.0.1]:51408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJYeI-0001Yd-QD for submit@debbugs.gnu.org; Thu, 04 Aug 2022 07:04:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJYeD-0001YM-7f for 54439-done@debbugs.gnu.org; Thu, 04 Aug 2022 07:04:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38114) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJYe6-0003u1-8N; Thu, 04 Aug 2022 07:04:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=mJPKJhLSCxGyf9PzU5fak63EWjWWzcuTeraOdxUDWnU=; b=JfwQrIbqBVcLYbyXdJLX sDqx1cBLE43i9kjPwgfXWfALSSS1Wx2ia2AWtZUKHpfnvsydvlJKQJ2CeXvia17bTYQlfQeIMqt8r iusl/H0SbbjXodK9p2nT9JmQ4eds3Crr+USuTgWR0T143gra2zduJi7fsnnpVMmeXCQPLZI8pIQc3 VwuCgVltykLFsrKZm/TOajNuGR6KHBEanhLAu9LKhpjGwSQkxGOAM9QXr7Ir+FR1haV0Bnd7S2bA3 4adWxN94ZUJH8tqwjnrm3TMhyvoaXx8QhNOBzMBnhOuAWDvYkhQ4BGxV6zMnl5haHzU3neHwfmEXm syKL4WCZ65hA7A==; Received: from 2a02-25e8-18-f3d0-52eb-71ff-fe49-3a13.ip6.vitnett.no ([2a02:25e8:18:f3d0:52eb:71ff:fe49:3a13]:48816 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJYe5-0000Yr-CQ; Thu, 04 Aug 2022 07:04:06 -0400 From: Marius Bakke In-Reply-To: <20220804014716.785308-1-jim@jimnewsome.net> References: <20220804014716.785308-1-jim@jimnewsome.net> Date: Thu, 04 Aug 2022 13:03:57 +0200 Message-ID: <871qtwqnhe.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659611164; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=mJPKJhLSCxGyf9PzU5fak63EWjWWzcuTeraOdxUDWnU=; b=H5l6LfXEu++EjedW/12fjHTETr41aLxd64Rsj/h5SlvJIbX35BTO6DPXIriAhca8HwkBjR 6lM/VgYMNlVpjplI3z8MDJMktYoPOU4XzmYYDWcuw8bUT8Pb84vvOJnZagmCE2gEs/uZUI mDBYarvDbABGqlYGDzhOGkhKjQXzH4z0mbVN14HVr4CezYP4SATgJN6JfMigTLgh6UrdEw YOqmTM45+xSlkmmnygYuGzE2nYA79tTAoBYmI/sgJeJb7TMAygyjQG+EdE4rFIM9jAe7IG YiTlTMMlEeRLr7APly3LGWHrZ9QlGPhGF6rOaNB8dhtsCeKLDvUuQGHIpDmpdw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659611164; a=rsa-sha256; cv=none; b=j+Z8WO52ByRAYaKYki0FFZ/OxgGihiAEH3NZgUfAaV/mueVC9OzuUP4D1scW6W/7pl6fEN zf7eqCcnvs64byqPQz3XeYKopj3Q20kmoIY/NaEtUn9EbTFuzsNFll4AZaIsqaT5lI/DQS 4RIlS++6JtcbAgubPpbxr/oA5nyo3oRuPqe/cDIzcu/+ycjfuhTSFdGkDFTDL/fLXpb8iR eSeIoSqv32nHhWsRp4V6Fl4++VNYErIZOW2whipwHX/3AyUek8qHzdw6jK9vi0sVQsLdMC cDR+PLPRuZ3FeA32RrcIaaqEp2eKHgo5pPMJyf7uoX9DLL6UA0Z858h4ty73Lg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JfwQrIbq; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JfwQrIbq; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5619D38D6A X-Spam-Score: -4.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3H5an99YLVB6 --=-=-= Content-Type: text/plain Jim Newsome skriver: > Hi, I'm new to this project and this code-review workflow, so please bear with me :). Welcome! You are doing great. :-) > It looks like there have been a few attempts here at updating Rust, including [Paul's], [Felipe's], and [my own]. > > [Paul's]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54439#5 > [Felipe's]: https://issues.guix.gnu.org/54475#0 > [my own]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56684 Indeed. :-/ > There's some discussion in this thread about using an updated mrustc and using that to cut out some earlier steps of the bootstrap chain. I propose leaving that out for the moment. It seems both nontrivial and orthogonal, so IMO would make more sense as its own thread / patch-set, which could be reviewed and merged independently, before or after this one. This has recently been done on the 'staging' branch courtesy of Efraim. > I think there's some confusion about where and how tests are enabled/disabled. IIUC in the current baseline, they are disabled in `rust-1.55`, which is the first version built with an earlier "official" rust: > > ``` > ;; Only the final Rust is tested, not the intermediate bootstrap ones, > ;; for performance and simplicity. > #:tests? #f > ``` > > and subsequent versions inherit that via the `rust-bootstrapped-package` function. > > The latest and public version (currently `rust-1.57`) re-enables most of the tests and fixes up some things so that the tests pass. > > So I think the approach here when adding versions is to change the current latest (1.57) to the simpler form that keeps tests disabled, add any additional necessary steps, and have the test-reenabling code again in the latest version. That is my understanding too. > 2 patches included: > > * First is a pure refactor to decouple "rust-1.57" from "rust" to help avoid confusion in the future. > * Second adds 1.58, 1.59, and 1.60, and makes rust-1.60 the new rust. > > In the latter patch I also tried building each version with a Rust 2 versions back instead of just 1 version back, to see if any can be left out. Unfortunately they couldn't. I'm including some of the errors in the comments for reference. LGTM, I've pushed both patches to the 'staging' branch since Rust was already patched there and it has not started evaluating yet. Note: I also added a copyright line for you, hope that was okay. Closing the issue, but feel free to continue the discussion. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYuunnQ8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHdyxAEA2qeNz4D8O/38ro1BbaMZ7v2VSx0Ldbc071Tg frdEbAEA/RvEoGHBqKVOPLJD0K/0v/UcX6A7RkAy9EjqTKplAm4F =hZQj -----END PGP SIGNATURE----- --=-=-=--