From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eAbGAR6e62IwIgAAbAwnHQ (envelope-from ) for ; Thu, 04 Aug 2022 12:23:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uKjFAR6e62K0FQEA9RJhRA (envelope-from ) for ; Thu, 04 Aug 2022 12:23:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC5672D451 for ; Thu, 4 Aug 2022 12:23:25 +0200 (CEST) Received: from localhost ([::1]:57162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJY0h-0000J0-Gf for larch@yhetil.org; Thu, 04 Aug 2022 06:23:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJXvX-0004Li-AP for guix-patches@gnu.org; Thu, 04 Aug 2022 06:18:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJXvX-0004qJ-0f for guix-patches@gnu.org; Thu, 04 Aug 2022 06:18:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJXvV-00008P-O4 for guix-patches@gnu.org; Thu, 04 Aug 2022 06:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56831] [PATCH] gnu: mumps: Update to 5.5.1 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Aug 2022 10:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56831 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?FEL=C5=A0=C3=96CI?= Marek Cc: 56831@debbugs.gnu.org Received: via spool by 56831-submit@debbugs.gnu.org id=B56831.1659608249465 (code B ref 56831); Thu, 04 Aug 2022 10:18:01 +0000 Received: (at 56831) by debbugs.gnu.org; 4 Aug 2022 10:17:29 +0000 Received: from localhost ([127.0.0.1]:51347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJXuz-00007R-HW for submit@debbugs.gnu.org; Thu, 04 Aug 2022 06:17:29 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:29485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJXut-000077-Qh for 56831@debbugs.gnu.org; Thu, 04 Aug 2022 06:17:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=yOh5pqmCbu/R3+5KCQc4r8VYpfs/uY9YexO7YVDSxv4=; b=JxHt9MM3ArN8DMPXJNO0uSUUQkhKCxaYwxjeEaCcf/31HXTkY1/K/LpF UQ3x0vGD4R8zJae3SNz2jF3q6L/bi8PZ9qpdf6sVHnO3lhBJY1xTDMoKV Q1eFcUnv/Omz93qESwSirDx6zDFd6U7UeBkgsTbj0G74CoosSpWm8VRmA 8=; X-IronPort-AV: E=Sophos;i="5.93,215,1654552800"; d="scan'208";a="20774084" Received: from unknown (HELO ribbon) ([193.50.110.201]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2022 12:17:17 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220729154411.8017-1-marek@felsoci.sk> Date: Thu, 04 Aug 2022 12:17:16 +0200 In-Reply-To: <20220729154411.8017-1-marek@felsoci.sk> ("=?UTF-8?Q?FEL=C5=A0=C3=96CI?= Marek"'s message of "Fri, 29 Jul 2022 17:44:11 +0200") Message-ID: <871qtwnwib.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659608605; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yOh5pqmCbu/R3+5KCQc4r8VYpfs/uY9YexO7YVDSxv4=; b=YJLt1hC1DD+NU/oIqbbvsIKr2bOZs+S5MhA35dry07NuLnkgNurhUPY/cheNJlLBC+ZhL4 O23tQh/6m4iwMOnbrDjl/ONLE2CM9kgJ+B7L2kteOMwxQ+xiN1q05VfUwYiPx2RzBLrDMY hXaS2W6+c/zp08ze5M31UdjIG5ZDak0bpjzFiNZl5WV8uJnK+ddK7BYV/BmIkgb/C+QDo1 UkLmGSzUPjuYh2N7yZWlwbNOnUR2f7OALdHcgHZ0DxiELeEdde+PszKNHfzYQzX1QVWvcj 6FXKLgBMe6+lrNFhInpA2/F3PiF4DayR0C2rFXwoflCTWKgkvDk1QRvMDI0ddg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659608605; a=rsa-sha256; cv=none; b=ptiQl3oLVCh8o/hvTQ72Z68oL5p5tfPQOOXhEIaY6mkK/Zy9KItNUTY8eBH6Bzn0NFkDxx 7IoMburJ8v53+sL6MN8PSIsj642h6X6ah6M6dlY18JW/SDXDDQaXsyAPPGbgzHVvmG89+G NNrslwvwzQPPxz+8yFaekof79d4iQ387cAsZ8b4L0yvBEEsBB0cSHiNH6m6pokDzqkI51x Pnpzo/Pu+g66yjif4aOe73XmUwcRxX53gwifCFjCbsTktRgghSJDG+EjEdiaaRIUAf2Ki9 PdR0+mFqkPf2uG7GN7yCNMKyvWOAHLFAmqZ9TOtNfGcbZV4NE+ES3/diqVlAWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=JxHt9MM3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.09 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=JxHt9MM3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CC5672D451 X-Spam-Score: 7.09 X-Migadu-Scanner: scn0.migadu.com X-TUID: KgWNZAiE/kXv Hi Marek, FEL=C5=A0=C3=96CI Marek skribis: > - (patches (search-patches "mumps-build-parallelism.patch" > - "mumps-shared-libseq.patch" > - "mumps-shared-mumps.patch" > - "mumps-shared-pord.patch")))) Good to see them go. :-) Could you please also remove the files and remove them from =E2=80=98gnu/local.mk=E2=80=99? > - `(#:modules ((ice-9 match) > - (ice-9 popen) > - (srfi srfi-1) > - ,@%gnu-build-system-modules) > + `(#:modules > + ((ice-9 match) > + (ice-9 popen) > + (srfi srfi-1) > + ,@%gnu-build-system-modules) This is unnecessary; if you could avoid it, that=E2=80=99d be great: it=E2= =80=99d make the important changes more visible. > #:phases > (modify-phases %standard-phases > (replace 'configure > - (lambda* (#:key inputs #:allow-other-keys) > - (call-with-output-file "Makefile.inc" > - (lambda (port) Looks like this hunk is mostly reformatting as well? > + (assoc-ref inputs "openblas") > + (->bool ;; OpenBLAS or MKL? > + (file-exists? > + (string-append > + (assoc-ref inputs "openblas") > + "/include/mkl_cblas.h"))) I understand the intent and that=E2=80=99s fine, but I would prefer a solut= ion that does not explicitly refer to MKL. Perhaps we could devise a solution that, more generally, allows users to swap one BLAS for another, but maybe that=E2=80=99s beyond the scope of this patch. Could you send a v2 of the patch that addresses these comments? Bonus points if you can provide a commit log that follows the ChangeLog style: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html :-) Thank you, Ludo=E2=80=99.