From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: "FELŠÖCI Marek" <marek@felsoci.sk>
Cc: 56831@debbugs.gnu.org
Subject: [bug#56831] [PATCH] gnu: mumps: Update to 5.5.1
Date: Thu, 04 Aug 2022 12:17:16 +0200 [thread overview]
Message-ID: <871qtwnwib.fsf@gnu.org> (raw)
In-Reply-To: <20220729154411.8017-1-marek@felsoci.sk> ("FELŠÖCI Marek"'s message of "Fri, 29 Jul 2022 17:44:11 +0200")
Hi Marek,
FELŠÖCI Marek <marek@felsoci.sk> skribis:
> - (patches (search-patches "mumps-build-parallelism.patch"
> - "mumps-shared-libseq.patch"
> - "mumps-shared-mumps.patch"
> - "mumps-shared-pord.patch"))))
Good to see them go. :-)
Could you please also remove the files and remove them from
‘gnu/local.mk’?
> - `(#:modules ((ice-9 match)
> - (ice-9 popen)
> - (srfi srfi-1)
> - ,@%gnu-build-system-modules)
> + `(#:modules
> + ((ice-9 match)
> + (ice-9 popen)
> + (srfi srfi-1)
> + ,@%gnu-build-system-modules)
This is unnecessary; if you could avoid it, that’d be great: it’d make
the important changes more visible.
> #:phases
> (modify-phases %standard-phases
> (replace 'configure
> - (lambda* (#:key inputs #:allow-other-keys)
> - (call-with-output-file "Makefile.inc"
> - (lambda (port)
Looks like this hunk is mostly reformatting as well?
> + (assoc-ref inputs "openblas")
> + (->bool ;; OpenBLAS or MKL?
> + (file-exists?
> + (string-append
> + (assoc-ref inputs "openblas")
> + "/include/mkl_cblas.h")))
I understand the intent and that’s fine, but I would prefer a solution
that does not explicitly refer to MKL. Perhaps we could devise a
solution that, more generally, allows users to swap one BLAS for
another, but maybe that’s beyond the scope of this patch.
Could you send a v2 of the patch that addresses these comments?
Bonus points if you can provide a commit log that follows the ChangeLog
style:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
:-)
Thank you,
Ludo’.
next prev parent reply other threads:[~2022-08-04 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 15:44 [bug#56831] [PATCH] gnu: mumps: Update to 5.5.1 FELŠÖCI Marek
2022-08-04 10:17 ` Ludovic Courtès [this message]
2022-08-04 17:08 ` [bug#56831] [PATCH v2] " FELŠÖCI Marek
2022-08-05 13:30 ` bug#56831: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qtwnwib.fsf@gnu.org \
--to=ludovic.courtes@inria.fr \
--cc=56831@debbugs.gnu.org \
--cc=marek@felsoci.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).