unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Andrew Tropin <andrew@trop.in>
Cc: 56777@debbugs.gnu.org
Subject: [bug#56777] [PATCH] Use absolute path for home activation script.
Date: Mon, 29 Aug 2022 23:24:02 +0200	[thread overview]
Message-ID: <871qsy68wd.fsf@gnu.org> (raw)
In-Reply-To: <87tu74z479.fsf@trop.in> (Andrew Tropin's message of "Fri, 14 Jan 2022 09:16:32 +0300")

Hi Andrew,

Andrew Tropin <andrew@trop.in> skribis:

> * gnu/home/services.scm (compute-activation-script): Use absolute path for
> home activation script.
>
> ---
>  gnu/home/services.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/home/services.scm b/gnu/home/services.scm
> index b05ec53e2a..6d5e4308a0 100644
> --- a/gnu/home/services.scm
> +++ b/gnu/home/services.scm
> @@ -418,7 +418,7 @@ (define (compute-activation-script init-gexp gexps)
>              (new-home-env (getenv "GUIX_NEW_HOME"))
>              (new-home (or new-home-env
>                            ;; Path of the activation file if called interactively
> -                          (dirname (car (command-line)))))
> +                          (canonicalize-path (dirname (car (command-line))))))

Just wondering: what’s the rationale?

This is harmless-looking and perhaps it’s all fine, but IME calling
‘canonicalize-path’ might sometimes paper over problems related to file
name handling.

Thanks,
Ludo’.




  reply	other threads:[~2022-08-29 21:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14  6:16 [bug#56777] [PATCH] Use absolute path for home activation script Andrew Tropin
2022-08-29 21:24 ` Ludovic Courtès [this message]
2022-08-30  7:01   ` Andrew Tropin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qsy68wd.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=56777@debbugs.gnu.org \
    --cc=andrew@trop.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).