From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WHwPIS+2EWPfzgAAbAwnHQ (envelope-from ) for ; Fri, 02 Sep 2022 09:52:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sMAdIS+2EWOCSQEAauVa8A (envelope-from ) for ; Fri, 02 Sep 2022 09:52:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D8882A974 for ; Fri, 2 Sep 2022 09:52:15 +0200 (CEST) Received: from localhost ([::1]:51996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oU1TJ-0005IV-UE for larch@yhetil.org; Fri, 02 Sep 2022 03:52:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU1T9-00057r-C0 for guix-patches@gnu.org; Fri, 02 Sep 2022 03:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oU1T9-0002FI-3X for guix-patches@gnu.org; Fri, 02 Sep 2022 03:52:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oU1T8-0000cm-WD for guix-patches@gnu.org; Fri, 02 Sep 2022 03:52:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57513] [PATCH] installer: Fix segfault on double logical partition removal. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 02 Sep 2022 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 57513-done@debbugs.gnu.org Received: via spool by 57513-done@debbugs.gnu.org id=D57513.16621050632292 (code D ref 57513); Fri, 02 Sep 2022 07:52:02 +0000 Received: (at 57513-done) by debbugs.gnu.org; 2 Sep 2022 07:51:03 +0000 Received: from localhost ([127.0.0.1]:44757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU1SA-0000au-Ub for submit@debbugs.gnu.org; Fri, 02 Sep 2022 03:51:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU1S7-0000aN-7i for 57513-done@debbugs.gnu.org; Fri, 02 Sep 2022 03:51:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU1S1-0001rS-VT; Fri, 02 Sep 2022 03:50:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fZxPReGtFuzSaHI3WPxzc6UHyKdTCO8EavlfHA/jh9Q=; b=Oz2S2pZXCwirxA2Sxazt eUclGki+E7FrniItcZf6C+0Ygc6R6yYnKu4zLYI1QHI/H6kvejEs+tiJ3DOGM6eUpB4FetaoRuEtn OwrOvSUNL/3MkkL0PbyoFpYsOrAqdX2ah+Ix32Hr7H3EzUU803XFAyRwCCuO18az78OthOI31lpL+ hEovPVKhy6/Plsd6u6mtZ+9J8uX2b/o77Whf7ugfqVGFqDGCIAlkMMkCAMCdg5Zo2Gk4YoUrmgI1n odZYreJ2/st4bM1vXWBjM9rMEnLoMdsGA/K7q/Kc+2hlnba++tT+OPG6R6iW2r7kvNNkXmJNN+hQV c9Zvx8trgPtzaQ==; Received: from pop.92-184-117-132.mobile.abo.orange.fr ([92.184.117.132]:39248 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU1S1-0008Hd-EF; Fri, 02 Sep 2022 03:50:53 -0400 From: Mathieu Othacehe References: <87y1v32g7g.fsf@gnu.org> <87tu5qzz0t.fsf@jpoiret.xyz> Date: Fri, 02 Sep 2022 09:50:51 +0200 In-Reply-To: <87tu5qzz0t.fsf@jpoiret.xyz> (Josselin Poiret's message of "Thu, 01 Sep 2022 21:16:02 +0200") Message-ID: <871qsub4f8.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662105135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=fZxPReGtFuzSaHI3WPxzc6UHyKdTCO8EavlfHA/jh9Q=; b=cxas/dBbt/Hop4gqtqU8RvP4N3dQh4EVUolgYdCeoxCJNrPYxPeUL6jnZW93+Q7ZH/nFIK Y5Nw8puwhoFjNx548J9TJlZomjMYLGmkV6U5aN8f0MDP1rUQBsqhNK9MShff3eK0pLJodj 73EhmPD3h79sfRzvNCmK11iQ86AcKm8Z3SSJWRDUEKANBh3/HqgQ2cyr4qjMyowOxOtH5J pXFMeRy6kKfsyjiVC6nF+uljPUIt29LyO3SsY/RapXzJjrVAL0jWH9lNDomdsh7jHcP54/ z23VWAGVSqb+GBZg7U69keRrZlQuBbAKJP1j+Gt3hsrICZ/rX2oK5AgW4HVeCw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662105135; a=rsa-sha256; cv=none; b=EDl8pz5uAm168aoVQp6TAEoWSlsu25pDPhmQe71xTk8GnoiBtTgSz00+eh4Vz+OTw4EAV4 oUG2lY+rWWGt1IiQh7vXPE7w67FdVVBBAv4bFEXr8delvcOZeqO0VUapF13lOKNYBrJuIv Q5WYCRp+N7sl4+VnbGGsGZzrmsZ2r9cTqz9+j/TTJAfauyGSS2Kdzfksl2kkvBMFcIOQxj ycZzEJ5+9+CQBdOCt+LaJA4I5hUsYSBYi8oY58wIJBVaqKAntP43Wy5GQUPcLbv3Jvsuow Vd9L4ErduKJtO7f56MDLUDnOoI90rptVpOMhCx7vBXzPQvxAF0icvGbIrl1Ilg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Oz2S2pZX; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Oz2S2pZX; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5D8882A974 X-Spam-Score: -2.17 X-Migadu-Scanner: scn1.migadu.com X-TUID: wV0gl+YK1qQl Hey, > I have to thank KE0VVT on IRC, who provided a core dump file! This was > surprisingly easier to debug than I thought, for those interested, I > built the installer using the same Guix commit, and loaded the guile > core dump file in gdb. I then used `guix build parted > --with-debug-info=parted` and loaded the resulting libparted.so library > using `info sections` to find out where the .text of libparted.so was > loaded in the core file, and `add-symbol-file > /gnu/store/path/to/libparted.so 0xaddress` to load the symbols. That > way, I could see that ped_disk_remove_partition was invoked for a disk > that had an empty partition list, hence leading me to this double remove > problem! I remember resorting to way less convenient solutions in the past to achieve something similar. Feel free to add this little memo to the documentation or as a code comment if you have the opportunity :). Thanks again, Mathieu