From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uPMIFBsOImMEhAEAbAwnHQ (envelope-from ) for ; Wed, 14 Sep 2022 19:23:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uAUGFBsOImN10gAA9RJhRA (envelope-from ) for ; Wed, 14 Sep 2022 19:23:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 042C138D6E for ; Wed, 14 Sep 2022 19:23:38 +0200 (CEST) Received: from localhost ([::1]:56814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYW6r-0002uq-GK for larch@yhetil.org; Wed, 14 Sep 2022 13:23:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYVG2-00071t-SO for guix-patches@gnu.org; Wed, 14 Sep 2022 12:29:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYVG2-0007Tv-JN for guix-patches@gnu.org; Wed, 14 Sep 2022 12:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYVG2-00055b-E6 for guix-patches@gnu.org; Wed, 14 Sep 2022 12:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify Resent-From: Trev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Sep 2022 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 57756@debbugs.gnu.org Received: via spool by 57756-submit@debbugs.gnu.org id=B57756.166317292319525 (code B ref 57756); Wed, 14 Sep 2022 16:29:02 +0000 Received: (at 57756) by debbugs.gnu.org; 14 Sep 2022 16:28:43 +0000 Received: from localhost ([127.0.0.1]:55883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYVFj-00054r-4a for submit@debbugs.gnu.org; Wed, 14 Sep 2022 12:28:43 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:39735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYVFh-00054e-L2 for 57756@debbugs.gnu.org; Wed, 14 Sep 2022 12:28:42 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5719D32009E2; Wed, 14 Sep 2022 12:28:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 14 Sep 2022 12:28:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trevdev.ca; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1663172914; x= 1663259314; bh=e7Tz2yGeoCOOWtpEPZzR+ISLU1+fZxrvDzwaBb1vdOM=; b=o W1H1hXWUVAwhzTgd1R2iO1gYEF7StiiS/6ncBDXZPY2C/xR23flYs0kxqmlMBkqg fORoA6sA525PhsrKYa7I5OkNKwB0Qd6H4rE8e+sAziQdagANgMcI9FS0rgMCQS8Q 6GjNS1XECFeyFDHvZUQjld+HR+rQ3c/7YBDwQVVbUaXokrxcSZn+q5wggKv4pCPf QIZLAg584nfhDAisnSyw1ox4Sv7uVBK6LSZmbA/qA0BQDTV2YHBtwWTb7MFhHktA utGSmsxba1X0wM1qdObAQiTueBk3vGEMErBPjBsoMbRtVDx/Lbb9GgR8chSP9qXH jXQXihI+CoLMSTLD4SLIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663172914; x= 1663259314; bh=e7Tz2yGeoCOOWtpEPZzR+ISLU1+fZxrvDzwaBb1vdOM=; b=d X7BqIFv4i3c2cjKR4wkQBPc/a/OB0TbgYOsFkSupFQP0/yYG/oFZWEVAD7seQOKe YH8YOy01nB5JZX8IfvDy2k+yrETXgsOglgtlLrz+l93noaYtjHSBTIWF5p9ZdaLc vBDWCSeEehb0Gy8xfsXPqmZAH30YPXuexmjcY9BpXOeg3J0KCf18pNxxT+M3j8Dz WlvWmnk4FfMhh4UWsaSG27qHj2B0RsvorzQlwP/rg2MZY+CQaZZKLDxmz/QnUJ0W 8cYISLP7S0+3qfYU4LS5npkVLBrS3+PtTio9Mp8iUOlNX3oscTnX7qMYpdwoBfnD /YyAFYW7Fus+P/j1/89ZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffgffkfggtgfgse htqhertddtreejnecuhfhrohhmpefvrhgvvhcuoehtrhgvvhesthhrvghvuggvvhdrtggr qeenucggtffrrghtthgvrhhnpeetfedtueffkeethfevtdehkeehiedvfeelheehvdeuvd egfeeuueelveegheetkeenucffohhmrghinhepghhnuhdrohhrghdpghhithhhuhgsrdgt ohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hrvghvsehtrhgvvhguvghvrdgtrg X-ME-Proxy: Feedback-ID: i762946f9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 12:28:34 -0400 (EDT) From: Trev In-Reply-To: <87r10e8jwt.fsf@cbaines.net> References: <87r10e8jwt.fsf@cbaines.net> User-Agent: Notmuch/0.36 (https://notmuchmail.org) Emacs/28.1 (x86_64-pc-linux-gnu) Date: Wed, 14 Sep 2022 09:28:32 -0700 Message-ID: <871qsddiof.fsf@codinator.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663176219; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=e7Tz2yGeoCOOWtpEPZzR+ISLU1+fZxrvDzwaBb1vdOM=; b=oe072s7pzNOl7ySM3a3UDqJGmQqXJTxfoCnuZw9x5X7bkv6hBs8tyBjGIfd8T24OKa4CYB Qoo/kKvqaf/YfyNh6kI8fco03dJbChheIOHaeETwsC8jmFEmPe9HUhq8Euyiv8NGT49dGv qLNukRsXdxdI6yXUCuDvEgrEzIfUvnCcuANAedTNPVfBTcNaAQDczmJJF3LfOfxVb9/8pi cbLLhFcFKfldLimAQe3u+Fn8SIyyuZlXoEJTOvvovdrCdiXFZjX3+puR80dXDAziz3pbmV 83kY1Ob4tWQk1b85OCHid/HINotSrK3eKKl0e2ejcchy4RWejOtJejzP86D3lg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663176219; a=rsa-sha256; cv=none; b=UhnKAusJotZktRoA6Nhac+MiQHIbxucodvj8j570lqJKdztECixWQo3kyPSNSZZ2Ua6ST1 nJZ5aWB3ctLZ/B+hD54lTeUtoXBnPMywbx76PhNYvZ/3Dg0f05vdEae/HmmXIo4NECHHNW yuM2BgwGh5PUTDZdJCKKaWKlxlHMSvt5H9DQoY6p0ONksbl+2QwgEIK8q01ZSceGkZZETX msHaNq3TYWiqlWZWYdU0cTEn7IuLEzjrbDZHem/6l+pB/I9aQY6eUr9cdK+w88CdcJfcCh 1ejeRUhawOiakS/WnvjGue3SNbl9o1Q68iKOYFBsSWIPP+gOZjm7lPhncgCcdg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trevdev.ca header.s=fm3 header.b="o W1H1hX"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="d X7BqIF"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trevdev.ca header.s=fm3 header.b="o W1H1hX"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="d X7BqIF"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 042C138D6E X-Spam-Score: 1.08 X-Migadu-Scanner: scn1.migadu.com X-TUID: Hwy1NPB/lrLo Christopher Baines writes: >> --- >> gnu/packages/wm.scm | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) > > Hi Trevor, > > The commit message for adding a package like this one would generally > look like: > > gnu: Add sbcl-stumpwm-notify. > > * gnu/packages/wm.scm (sbcl-stumpwm-notify): New variable. > > > You're mostly there. > Thank you for this feedback! I had been following the guidelines described in the documentation: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html It states to write patches in the "changelog" format described here: https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs Is there documentation somewhere that might help me adapt my strategy for future contributions? I do prefer the tighter format you're asking for :) >> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm >> index 451dfce516..6ae0135a64 100644 >> --- a/gnu/packages/wm.scm >> +++ b/gnu/packages/wm.scm >> @@ -56,6 +56,7 @@ >> ;;; Copyright =C2=A9 2022 Maxim Cournoyer >> ;;; Copyright =C2=A9 2022 muradm >> ;;; Copyright =C2=A9 2022 Elais Player >> +;;; Copyright =C2=A9 2022 Trevor Richards >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -2256,6 +2257,29 @@ (define-public sbcl-stumpwm-screenshot >> PNG files.") >> (license license:gpl3+))) >>=20=20 >> +(define-public sbcl-stumpwm-notify >> + (package >> + (inherit stumpwm-contrib) >> + (name "sbcl-stumpwm-notify") >> + (build-system asdf-build-system/sbcl) >> + (inputs >> + `(("stumpwm" ,stumpwm "lib") >> + ("xml-emitter" ,sbcl-xml-emitter) >> + ("dbus" ,sbcl-dbus) >> + ("bordeaux-threads" ,sbcl-bordeaux-threads))) >> + (arguments >> + '(#:asd-systems '("notify") >> + #:tests? #f > > Why aren't the tests being run? If they can be run, that would be > good. If there's a reason why they can't or shouldn't be run, it would > be good to note that in a comment. > I flagged them off while testing the build in my own channel and forgot to put them back on. Oops! They pass if they exist. I can submit an update. >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'chdir >> + (lambda _ (chdir "util/notify") #t))))) >> + (home-page "https://github.com/stumpwm/stumpwm-contrib") >> + (synopsis "Notifications server for StumpWM") >> + (description "Implements org.freedesktop.Notifications >> +interface[fn:dbus-spec]. Shows notifications using stumpwm:message by d= efault.") >> + (license license:gpl3))) >> + >> (define-public lemonbar >> (package >> (name "lemonbar") > --=20 Trev : 0FB7 D06B 4A2A F07E AD5B 1169 183B 6306 8AA1 D206