From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gDWeGq+/WmN8lwAAbAwnHQ (envelope-from ) for ; Thu, 27 Oct 2022 19:28:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MFm2Gq+/WmOm6gAA9RJhRA (envelope-from ) for ; Thu, 27 Oct 2022 19:28:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1FE964ED7 for ; Thu, 27 Oct 2022 19:28:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo6bs-0007So-Ed; Thu, 27 Oct 2022 13:24:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6bq-0007Qx-R2 for guix-patches@gnu.org; Thu, 27 Oct 2022 13:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo6bq-00089V-JD for guix-patches@gnu.org; Thu, 27 Oct 2022 13:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo6bq-0003LS-6J for guix-patches@gnu.org; Thu, 27 Oct 2022 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58587] [PATCH 04/14] build-system: Add pyproject-build-system. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 27 Oct 2022 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 58587@debbugs.gnu.org, Lars-Dominik Braun Received: via spool by 58587-submit@debbugs.gnu.org id=B58587.166689141112810 (code B ref 58587); Thu, 27 Oct 2022 17:24:02 +0000 Received: (at 58587) by debbugs.gnu.org; 27 Oct 2022 17:23:31 +0000 Received: from localhost ([127.0.0.1]:59199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6bL-0003KY-13 for submit@debbugs.gnu.org; Thu, 27 Oct 2022 13:23:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6bJ-0003KI-Ix for 58587@debbugs.gnu.org; Thu, 27 Oct 2022 13:23:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6bD-000874-FK; Thu, 27 Oct 2022 13:23:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=MGMLETve4Ivaosh3rxiICmEaWQbg+2jmYJRtEXYhVsE=; b=cKaFJg1QFoVzBAyXe34t 24Vbsn3RHPzxb1NHWB/f5E1Pu8hyuHoqBLYoLQqI1Ig8164i51wgkyEVDFmpn1k4otIE8BwC3nxim /yxduhECmNRL8hFw9ExEnubxpiwV+UV+Ts2ozwY7fwNVHHEn8cA3lVvu3BrEY7MB8Ti76PaUHRaP7 R5H/IAc8nHE4Cboj6+qnRXZhzN5jLbYqCYpPmfQFcnmhUPoUdBjvpydL3JGGcBajAcygqFim8jqtV ycpxF3SM9d1fx/vpa0V5QzUMT/byROsP1PqzLDxGFD2O0YVcqB3cU6sEdEYO4/eCi10KM/kEv2d8K oQocmcSPQbaeVg==; Received: from [84.214.173.6] (helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6bC-0003s9-CB; Thu, 27 Oct 2022 13:23:23 -0400 From: Marius Bakke In-Reply-To: <87zgdhjqgr.fsf@gmail.com> References: <20221017200624.4076-1-marius@gnu.org> <20221017201201.4808-1-marius@gnu.org> <20221017201201.4808-4-marius@gnu.org> <87zgdhjqgr.fsf@gmail.com> Date: Thu, 27 Oct 2022 19:23:18 +0200 Message-ID: <871qqttc3d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666891695; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=MGMLETve4Ivaosh3rxiICmEaWQbg+2jmYJRtEXYhVsE=; b=R5YefsKh/1bIKCPECceWT/b+8JMGlX/lzzkYxuWLBc34jKKVssutbUY/B4tKaVY3JM0dWq I3i3KAF24NX3i6CR9LkzOpChu+jAHvro8gF5c9KzWScH/6qTfxBRN3ES9L3lzi+otTBsHn LTekwsgYwZd8WY/Ly8kgG2VgZtpMw8ZOG0eXuDWWYpZPbDkMCZyfUAhcrDXBcBWbmfzAVA nzqENlYQEMsPocQEl1KXVlx+wDZAOhApItVPugB13wu3am5mObcIY/55TMrzV5a6Elypig BpbNGCIvXeBGtn4nlMrqJi1DmpDkR7HgCl4Epg5EVfmxzFl6ATvtWHfHCwWZmw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666891695; a=rsa-sha256; cv=none; b=WN9Wx4rQJbR3seAaYsc4ygwaZcnogIi8R6smuJZmh0qBdRTXH2RPepiJkGlvnjnv4ph5Ar 6/Flxh91iG5Si2zOn5W5NIOhwlSaKivMFTX5xgKqNUH6DY48tmQDtIOR5oFzN+u9LqAryU RoyXOYBG7LhL+hZoLdBM0DHs4/pKSQT1HEpvKmTMD3mefTosD0feHYm2WifDxoHYFdYFsh XuP16zdcfcVaj1kC7BSc5wPvpw2FV5A1bI/r2RrcW/aSuy2+SYc1nrSrkgjUC78vBWPgLo Gg//szbSogzO7Mi3lQihvCjJXWOz2XHt0rI4wfnGbjXb46BsKBIi4fkcRgpysQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cKaFJg1Q; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cKaFJg1Q; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1FE964ED7 X-Spam-Score: -4.42 X-Migadu-Scanner: scn1.migadu.com X-TUID: ZubzX+TUd+1A --=-=-= Content-Type: text/plain Maxim Cournoyer skriver: > Hello, > > Marius Bakke writes: > >> From: Lars-Dominik Braun >> >> This is an experimental build system based on python-build-system >> that implements PEP 517-compliant builds. >> >> * guix/build-system/pyproject.scm, >> guix/build/pyproject-build-system.scm, >> gnu/packages/aux-files/python/sanity-check-next.py, > > I know this file is temporary, but I'd keep the copyright/license > notices header anyway, less it may be forgotten in the future. Makes sense; done. >> gnu/packages/python-commencement.scm: New files. >> * Makefile.am (MODULES): Register the new build systems. >> * gnu/local.mk (GNU_SYSTEM_MODULES): Add python-commencement.scm. > > Seems this could be merged into gnu/packages/python-build.scm instead of > creating a new module. I think you reviewed an old revision; the latest revision adds python-toolchain straight into python.scm. We may have to bring back python-commencement.scm for bootstrapping setuptools and friends at a later core-updates cycle though. >> + ;; Prefer pytest >> + (if pytest 'pytest #f) >> + (if nosetests 'nose #f) >> + (if nose2 'nose2 #f) >> + ;; But fall back to setup.py, which should work for most >> + ;; packages. XXX: would be nice not to depend on setup.py here? fails >> + ;; more often than not to find any tests at all. Maybe we can run >> + ;; `python -m unittest`? >> + (if have-setup-py 'setup.py #f)))) >> + (format #t "Using ~a~%" use-test-backend) >> + (match use-test-backend >> + ('pytest >> + (apply invoke (cons pytest (or test-flags '("-vv"))))) >> + ('nose >> + (apply invoke (cons nosetests (or test-flags '("-v"))))) >> + ('nose2 >> + (apply invoke (cons nose2 (or test-flags '("-v" "--pretty-assert"))))) > > I think I'd leave the defaults in and document it that way. By leave, you mean: (apply invoke "pytest" "-vv" test-flags) ? >> +(define* (set-SOURCE-DATE-EPOCH #:rest _) > > Perhaps name this set-SOURCE-DATE-EPOCH* to hint that it's not the same > thing duplicated. Done; although in the latest revision nothing is duplicated as it inherits a bunch from python-build-system. Plans for the immediate core-updates cycle: * merge sanity-check-next.py into sanity-check.py * set SOURCE_DATE_EPOCH to ~1980 also in python-build-system (and inherit in pyproject-build-system) * move the compile-bytecode phase into python-build-system (currently python-build-system does this during install, hence duplication) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCY1q+hw8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHeKgQD+PB21Eb1COjHfGjFxC8E+FllZ0/c+Y9aAsIX3 AraIdDsBALhq0Ye49mk10xx1p3SM7gbNWrf4/8wpNwgMH1j9Bo0F =3G68 -----END PGP SIGNATURE----- --=-=-=--