From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gOvSL0PCfGPiYQAAbAwnHQ (envelope-from ) for ; Tue, 22 Nov 2022 13:36:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yBa1L0PCfGM81QAA9RJhRA (envelope-from ) for ; Tue, 22 Nov 2022 13:36:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7605C11876 for ; Tue, 22 Nov 2022 13:36:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxSVS-00014B-TI; Tue, 22 Nov 2022 07:36:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxSVP-00013Z-F7 for guix-patches@gnu.org; Tue, 22 Nov 2022 07:36:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxSVP-0004zB-5e for guix-patches@gnu.org; Tue, 22 Nov 2022 07:36:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxSVP-0005Z8-0T for guix-patches@gnu.org; Tue, 22 Nov 2022 07:36:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#58174] [PATCH 1/3] gnu: Add ocaml-domain-name. Resent-From: Csepp Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Nov 2022 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58174 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Christopher Baines Cc: 58174@debbugs.gnu.org, raingloom@riseup.net X-Debbugs-Original-Cc: 58174@debbugs.gnu.org, Csepp , guix-patches@gnu.org Received: via spool by 58174-submit@debbugs.gnu.org id=B58174.166912051821327 (code B ref 58174); Tue, 22 Nov 2022 12:36:02 +0000 Received: (at 58174) by debbugs.gnu.org; 22 Nov 2022 12:35:18 +0000 Received: from localhost ([127.0.0.1]:50120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxSUf-0005Xv-RA for submit@debbugs.gnu.org; Tue, 22 Nov 2022 07:35:18 -0500 Received: from mx0.riseup.net ([198.252.153.6]:49022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxSUc-0005XW-5K for 58174@debbugs.gnu.org; Tue, 22 Nov 2022 07:35:16 -0500 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4NGkHJ5Z61z9s6t; Tue, 22 Nov 2022 12:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1669120508; bh=eqgZuxyoistX0k6JqzzXtnuq7qZrDRe5y5GOrkvSd3k=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=MWI7uFztyCGqu5HJPCizTcmZCAgRIhggqs9gwgG3iRokKKtb7j/GzBHxxBvc7dDGt CJ8EUB4zU46xzJIoUMhlsCEgz48I2qOPd0NZONEkPUB//S8t8LR9i4z/YFYYE3qdK7 ZSS0C0uOHhYXEdQCveAUG0FUu7LMP4hkqA0qvuX0= X-Riseup-User-ID: E1A8A57623AE3132C1772E18E17A62300C577A3E21AF3BF86707A24292F56BF1 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4NGkHJ0Pffz1yBb; Tue, 22 Nov 2022 12:35:07 +0000 (UTC) References: <20220929164718.16973-1-raingloom@riseup.net> <875yf8v2gv.fsf@cbaines.net> <875yf8mdol.fsf@riseup.net> <878rk3s3vi.fsf@cbaines.net> From: Csepp Date: Tue, 22 Nov 2022 13:30:00 +0100 In-reply-to: <878rk3s3vi.fsf@cbaines.net> Message-ID: <871qpvmakq.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669120579; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=eqgZuxyoistX0k6JqzzXtnuq7qZrDRe5y5GOrkvSd3k=; b=GSPfgl5u9g2BVvv8Gs4cDVyp5Su1tnaGMaUiEurlgkJ1Fi+6oFRdggsgm06oqfTNeAoblU pezEp0yo/qnq1D3cq6wAfoZlRSk8H5atFNszQCP0REhwy5nzIcokWTH/tP/fpQKBkwFh6X 3/Dp0Cc4mu23EJ7IAnqrTN/BnQN473uOBfaIjIcrQEmBpwIEBXg/ztDth2YFr2I5w/zCSS J1in49IzPv5XbPScSzPz0zX/OgOr4O9fBuPZ+tce22ff/xDZNX9zbgsKoC5eWa2q3x2RLs iTStSUoWeSjj5L1oj5XcFyEnEWSjhW/yLJeq+Hx61XkWTpfdgMzzDMlhHQ78Aw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669120579; a=rsa-sha256; cv=none; b=Z+vNn1m2ffOfDWX5/YFUM910RnlytEG7a2oFTaQhBlo/jK8JTkKlKPoi6+QcqmfuRyUEgC 0TK98VfX3tOZmZvlbMm4rChnb+VogcDJUB2qUatztU/qPAIbgHipREjKULZITnbR04jOEx T5zzAJAvXcZTvL2M2fM99A3eewx10BPkslYl6lJeiUAI4L7URwR/Q5a0J79daIgbwdR8Jw f3k8vyYHgqarGWJap7FrcheD18bp3gIfoQdOuztmwuX2FtMQRLqvySEwjMnU3WJWSz5gsE uLew7v2ycWpwQAKkn+T82MRZju/m263CbmDJU8W1GFV9/ClkfwGExJv/T1x49g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=MWI7uFzt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=MWI7uFzt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7605C11876 X-Spam-Score: 5.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: lAwBLfe0ExsD Christopher Baines writes: > [[PGP Signed Part:Undecided]] > > Csepp writes: > >> Christopher Baines writes: >> >>> [[PGP Signed Part:Undecided]] >>> >>> Thanks for the patches. I don't think there's a need for another module >>> though, and if there is, it should probably have a more general topic >>> than mirage (e.g. networking). >>> >>> So yeah, would you be able to move these packages to the ocaml module >>> and send an updated patch series? >>> >>> Thanks, >>> >>> Chris >>> >>> [[End of PGP Signed Part]] >> >> I have a lot more packages in it (40-ish), a lot of them mirage >> specific. Working in a separate file made rebasing and sorting commits >> much easier. >> But if it's a problem, I can move them to the main ocaml file, but I'd >> like to avoid it becoming a monolith like gtk.scm, if for no other >> reason than because I don't want to waste my time waiting for GUILEC to >> recompile a bunch of expression I did not touch. > > I'm fine with mirage specific stuff going in a mirage module, my issue > is that these first packages are not mirage specific, so I'd like to see > the separate module be more general (e.g. about networking), or for them > to just go in the ocaml module. > > [[End of PGP Signed Part]] I'd rather not bikeshed this further, so whatever, it can go to ocaml.scm.