unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#59578] [PATCH] gnu: Add guile-fibers-latest.
@ 2022-11-25 17:01 Christopher Baines
  2022-11-25 19:07 ` zimoun
  2022-11-28 21:06 ` Ludovic Courtès
  0 siblings, 2 replies; 4+ messages in thread
From: Christopher Baines @ 2022-11-25 17:01 UTC (permalink / raw)
  To: 59578

* gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.
---
 gnu/packages/guile-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index b1620618eb..6505798f27 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -707,6 +707,25 @@ (define-public guile-fibers-1.1
     (properties '((upstream-name . "fibers")))
     (license license:lgpl3+)))
 
+(define-public guile-fibers-latest
+  (let ((commit "0fa712ecd85c65d7d11ce0c897f068fba4e6ef3f")
+        (revision "0"))
+    (package
+      (inherit guile-fibers-1.1)
+      (name "guile-fibers-latest")
+      (version (git-version (package-version guile-fibers-1.1)
+                            revision
+                            commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/wingo/fibers")
+                      (commit commit)))
+                (file-name (git-file-name "guile-fibers" version))
+                (sha256
+                 (base32
+                  "0vfq4dkdq2szi5f99ywm856vll397c1x42a55rpxya61rrws8s9r")))))))
+
 (define-public guile-fibers
   (package
     (inherit guile-fibers-1.1)
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#59578] [PATCH] gnu: Add guile-fibers-latest.
  2022-11-25 17:01 [bug#59578] [PATCH] gnu: Add guile-fibers-latest Christopher Baines
@ 2022-11-25 19:07 ` zimoun
  2022-11-28 21:06 ` Ludovic Courtès
  1 sibling, 0 replies; 4+ messages in thread
From: zimoun @ 2022-11-25 19:07 UTC (permalink / raw)
  To: Christopher Baines, 59578

Hi Chris,

On Fri, 25 Nov 2022 at 17:01, Christopher Baines <mail@cbaines.net> wrote:
> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.

From my understanding, the convention seems ’-next’ and not ’-latest’.

--8<---------------cut here---------------start------------->8---
45 candidates:
./gnu/packages/freedesktop.scm:1210:(define-public wayland-protocols-next
./gnu/packages/bioconductor.scm:13526:(define-public r-cistopic-next

[...]

./gnu/packages/emacs-xyz.scm:25239:(define-public emacs-spaceline-next
--8<---------------cut here---------------end--------------->8---

Although, 6 packages are using ’-latest’. :-)

--8<---------------cut here---------------start------------->8---
6 candidates:
./gnu/packages/guile-xyz.scm:1359:(define-public guile-email-latest
./gnu/packages/bioinformatics.scm:4161:(define-public java-htsjdk-latest
./gnu/packages/tls.scm:333:(define-public gnutls-latest
./gnu/packages/guile.scm:391:(define-public guile-3.0-latest
./gnu/packages/perl.scm:5493:(define-public perl-inc-latest
./gnu/packages/ruby.scm:5378:(define-public ruby-latest-ruby
--8<---------------cut here---------------end--------------->8---

Well, since this appears in the name, it appears to me better to have
the same convention; for discover-ability, for instance.


Cheers,
simon








^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#59578] [PATCH] gnu: Add guile-fibers-latest.
  2022-11-25 17:01 [bug#59578] [PATCH] gnu: Add guile-fibers-latest Christopher Baines
  2022-11-25 19:07 ` zimoun
@ 2022-11-28 21:06 ` Ludovic Courtès
  2022-12-06 11:30   ` bug#59578: " Christopher Baines
  1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2022-11-28 21:06 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 59578

Hi Christopher,

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.

I agree with zimoun that this should be “-next” but otherwise LGTM.

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#59578: [PATCH] gnu: Add guile-fibers-latest.
  2022-11-28 21:06 ` Ludovic Courtès
@ 2022-12-06 11:30   ` Christopher Baines
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2022-12-06 11:30 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 59578-done

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Christopher Baines <mail@cbaines.net> skribis:
>
>> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.
>
> I agree with zimoun that this should be “-next” but otherwise LGTM.

Thanks both for looking at this, I've changed -next to -latest and
pushed this to master as ef2fba6fe3d020adfc95481fbd6958a62892aa45.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-12-06 11:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 17:01 [bug#59578] [PATCH] gnu: Add guile-fibers-latest Christopher Baines
2022-11-25 19:07 ` zimoun
2022-11-28 21:06 ` Ludovic Courtès
2022-12-06 11:30   ` bug#59578: " Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).