From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cPFAEu7srWPVqwAAbAwnHQ (envelope-from ) for ; Thu, 29 Dec 2022 20:39:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gAEwEu7srWMk8QAA9RJhRA (envelope-from ) for ; Thu, 29 Dec 2022 20:39:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 09A641BCCB for ; Thu, 29 Dec 2022 20:39:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAyk4-0005OG-NU; Thu, 29 Dec 2022 14:39:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAyk3-0005Nn-C2 for guix-patches@gnu.org; Thu, 29 Dec 2022 14:39:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAyk3-0006HW-29 for guix-patches@gnu.org; Thu, 29 Dec 2022 14:39:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAyk2-0003cD-QX for guix-patches@gnu.org; Thu, 29 Dec 2022 14:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59761] [PATCH 0/2] Add u-boot-ts7970-q-2g-1000mhz-c. References: <20221202052903.10475-1-maxim.cournoyer@gmail.com> In-Reply-To: <20221202052903.10475-1-maxim.cournoyer@gmail.com> Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 29 Dec 2022 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59761 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59761@debbugs.gnu.org Received: via spool by 59761-submit@debbugs.gnu.org id=B59761.167234273213848 (code B ref 59761); Thu, 29 Dec 2022 19:39:02 +0000 Received: (at 59761) by debbugs.gnu.org; 29 Dec 2022 19:38:52 +0000 Received: from localhost ([127.0.0.1]:32944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAyjr-0003bH-QR for submit@debbugs.gnu.org; Thu, 29 Dec 2022 14:38:52 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAyjp-0003b4-O4 for 59761@debbugs.gnu.org; Thu, 29 Dec 2022 14:38:50 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1672342727; cv=none; d=zohomail.com; s=zohoarc; b=BHwjV9hDv66l1+8Hv/XsNzkyclhkZOf/ZJ7MYRfg8AwgnKJE1mGypv1DZrQq8Xsng3mVCs/c/iuArZNa1+Q7WtZy0V2+HrxWIpJUPrrc+YpZlloXDYrRkjo3BwOlLGFfEnHLJGIF0vm7Axb4r5c/mNXsPgvZuRytLvAlKy2iAVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672342727; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=pbbrbqLi1/lMeRmjAMBFWj4doBgMEMMGN2XL168Qau4=; b=bn8B8o6xNWbTslHSZqCTF1iQQGm2cGcISk/MiHbagbSZnWyXkWtGJzqkTBrKJFDTAm3/4B4KFDYlLIc2aGZUSHTrbSkZz64AkkH9Ns+zT3FeKgAbI/pXV6tP4lEjJ2Ogb0M/Qru7hTrAf1s/KNIZ7oq+2LF3SfzWhDdUt60Go/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1672342727; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=pbbrbqLi1/lMeRmjAMBFWj4doBgMEMMGN2XL168Qau4=; b=GhQmjTl+mE38W/E/9VAA0cT+nFZaahjteVV+XlNzTBXhPohF6jgSvIdqQ9/RzduO DWN3qmM05JTXA83fREH8tQXJs2d3NWgr3uzaxXsZrUiegR4RGPo7CRAz0+rxAcI0UH+ qcalPe5EHzoRMBmZTX7PX3zt22NUiozgumV15gGM= Received: from localhost (1-108-142-46.pool.kielnet.net [46.142.108.1]) by mx.zohomail.com with SMTPS id 16723427259997.328192017408924; Thu, 29 Dec 2022 11:38:45 -0800 (PST) User-agent: mu4e 1.8.13; emacs 28.2 From: Ricardo Wurmus Date: Thu, 29 Dec 2022 20:33:16 +0100 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <871qoi9f0b.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672342766; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pbbrbqLi1/lMeRmjAMBFWj4doBgMEMMGN2XL168Qau4=; b=rnLizOslbO9QMEQkP1yn0C3yAFLUKWN5byySUYpqWnfCwxURs9KCQAs21ndqSH+NyJ19YL Fr9RRHn1YQTzFKzuMTpPVHr8zh1qtIk9EaEHjj0pCP7ZFhS8uAMA2ot55BHD65vi+n5RLY h0nW+44IqlN/koO3h7SD54FTpcyVgion4LGXzqc24oOOYbnfWCTtT0JRkgQkLnlooYQDp3 XFodGQLumzATgaKQoBsI9pzByDheGekdv6/fKcKmmXUzn5Ed9fjVI05Mwvroslhewhff2O 1qp11RXspo3BFUvDETjh76gdkZQtb7zjwpO7JP6YUU/RK5oEQPv+d33NBDGz5Q== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=GhQmjTl+; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=2; s=key1; d=yhetil.org; t=1672342766; a=rsa-sha256; cv=fail; b=cM7a0SBDor8bsWl/quwChGJfdZA5iLZxvK9Yzhq8k+yHr+RboxCLlsNbG4cledun028qD7 VxanSOYyViUgJMq1s48R1BmsBRt4o0lAxjb7qjLNDZnl3k0m1LGwbysD9FFUVrEtqJk4Ww ZGkt8rzZ7+GCuFsyDw33w/d33Ty3k+uKwaRKtkDewTrH36CVTgYlxYReBMQfjSUlywkMyZ HX2zrjRXIjYWRPL3pcmXoKAW+PwxqiwJpKfJAAVtdxrTiBJNjboYq7n21Ujq6W2Jt3RrqY uLxWjlEKFHmJYbrCP1/zsyiTFBRwXaX3rxyA/2XznItPXXs9B1ythzQqeBuZ2g== X-Spam-Score: 3.47 X-Migadu-Queue-Id: 09A641BCCB Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=GhQmjTl+; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: 3.47 X-TUID: n5XV4kDc0A+E Hi Maxim, there seems to be some overlap between this and https://issues.guix.gnu.org/60224. Looking just at v4 I only have one comment. In your substitute* replacements it=E2=80=99s better not to use string-appe= nd. You can include real line breaks in a string and escape line breaks with \. This is preferable to gluing strings together. For something as long as the replacements in this package consider using a patch file instead. This has the added advantage of failing the build when the patch cannot be applied cleanly. The rest looks good to me. --=20 Ricardo