From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eHmRGOaxtGNwBwAAbAwnHQ (envelope-from ) for ; Tue, 03 Jan 2023 23:53:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QPmZGOaxtGNAVgEA9RJhRA (envelope-from ) for ; Tue, 03 Jan 2023 23:53:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1599A340C7 for ; Tue, 3 Jan 2023 23:53:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCq9X-00046E-8A; Tue, 03 Jan 2023 17:53:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCq9W-000466-6c for guix-patches@gnu.org; Tue, 03 Jan 2023 17:53:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCq9V-0003qq-P7 for guix-patches@gnu.org; Tue, 03 Jan 2023 17:53:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCq9V-0004oI-LM for guix-patches@gnu.org; Tue, 03 Jan 2023 17:53:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60341] [PATCH Home] home: services: environment-variables: Add support for literal strings. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Jan 2023 22:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60341 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 60341@debbugs.gnu.org Received: via spool by 60341-submit@debbugs.gnu.org id=B60341.167278637718480 (code B ref 60341); Tue, 03 Jan 2023 22:53:01 +0000 Received: (at 60341) by debbugs.gnu.org; 3 Jan 2023 22:52:57 +0000 Received: from localhost ([127.0.0.1]:47052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCq9Q-0004o0-Rm for submit@debbugs.gnu.org; Tue, 03 Jan 2023 17:52:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCq9O-0004nj-4B for 60341@debbugs.gnu.org; Tue, 03 Jan 2023 17:52:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCq9H-0003qJ-4u; Tue, 03 Jan 2023 17:52:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=IZMM4Xb7P6wIn5tB1YHUqy8icHNQaCglePEdTrHL4Xc=; b=GViRdVZfXYCH5UmEfTQ9 MzIm5DaoDQuQgXFUq5vVxfGIZ/fLfFDU7sATTFtgAMgCN7M6bMEXrfeASr/IdE3MYDdbfsqi9As41 FHnm/fnB1mA0p+LoVC/MOONEe5B8vWubD+HHdu8pqwxgYV9WzgHQaiaPYAmkj24dwOkDAWFKR/cT0 W6QXsQ9TcBwXnoSHmIhR92u1IvCdeFjOE6Sr/b2so7kSv2QADtA2Xb0WZVlk7tlBr63a/XDvHVEi5 W86sy7szTNofgpo6Mf6mJKkjSIz+JgDMkLi5N2Cxc9sSkjIxKPZ5K+AMOH9dPp+1Lm5MSexVyAzUd 8LKKzZqZV4iPIA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCq9G-00077i-P6; Tue, 03 Jan 2023 17:52:46 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221226181938.30003-1-ludo@gnu.org> <87o7rpa6rk.fsf@trop.in> Date: Tue, 03 Jan 2023 23:52:44 +0100 In-Reply-To: <87o7rpa6rk.fsf@trop.in> (Andrew Tropin's message of "Tue, 27 Dec 2022 07:02:23 +0400") Message-ID: <871qob6xj7.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672786406; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IZMM4Xb7P6wIn5tB1YHUqy8icHNQaCglePEdTrHL4Xc=; b=KeOM2j4w6JegQkScMGMOniNspKbgPwWx0NmoIhL1ltYzd2OthugLQ1krZDXbLG9qiBlFep +7vEw5iUn+bgREmkJhy7pmvt4+vP4++xJuWmYF3iuXjJ92QfADlPDkQrIir2lcfiozU8DM tYQmRvKj2ZGYMz635wYoov5/QrgVSsTSMZKnDUECwOMrPNdoOZbxAuES4vEx9NHvE3jCpT fBcjv2W87tC9nc7IwoHoXBZOgcPIOmh16LD5ZQP2CofIrbt3d+e2qN3X9z0z7D3JpyLUoT 6CG9A1vveULQk5pFZI9XEAn48F7etNq3p+eNB4gLDGcwCZXuFhonHOkmXHDz3Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GViRdVZf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672786406; a=rsa-sha256; cv=none; b=sP+Vxj4sBK7Eu4QgH9s4qU9HBPdgjiAO696W9UCEg6H6wRHgeNH3ZRNSK9oRl4zVlVgpx5 PvNbRjtMD0H5kyPohi1fI/gOTRSRMelzK7u+9F2070FSPNTFkdpH59dlXTouCn3b4ZBDMy Jv8EZWcsS925DILg5YC+XIjRxgonQrJhYBli/KHi6JIwp2PIexkoofKbimRfyZPe3oC+/F CpafGkSIb2qU0oWv5zwyZzHE8l+V2wmqoNZKOcxMfwjJaLLcR3zDMxCnVwrsWlw8yaOTRL r3beX4eygymWMZEE7EAz3GzktothNo40vgTob0tGIdzq4PPGJUg4Y6jY3j6djg== X-Spam-Score: -3.96 X-Migadu-Queue-Id: 1599A340C7 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GViRdVZf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -3.96 X-TUID: xcFhkz3KFCqa Hi, Andrew Tropin skribis: > On 2022-12-26 19:19, Ludovic Court=C3=A8s wrote: [...] >> I found that it=E2=80=99s occasionally useful to be able to define shell= variables >> with a value that is to be taken literally, without shell expansion. Th= is >> is what this patch implements. >> >> Thoughts? > > Hi Ludo, > > the code looks good. > > I'm a little conserned that one need to learn a new abstraction to > properly quote the expression instead of just using " or ' inside value > string, but we already have af4c103595a725194318f40fc5aba110772ff417 and > with the current state of the code this change looks rational and > idiomatic. Also, it makes the interface more high-level, which can be > good in some circumstances. Yeah, the shell/Scheme mixture is a bit weird; it=E2=80=99s sort of in-betw= een because you can=E2=80=99t completely ignore that it=E2=80=99s shell code un= der the hood. Looking at , I think we should strive to not generate non-working shell snippets. Automatic quoting and this =E2=80=98literal-string=E2=80=99 construct are a way to achieve that. Ludo=E2=80=99.