unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#61824] [PATCH] gnu: ledger: Update to 3.3.0.
@ 2023-02-26 20:50 jlicht
  2023-02-27 13:25 ` Guillaume Le Vaillant
  2023-02-28  1:21 ` [bug#61824] [PATCH v2] " jlicht
  0 siblings, 2 replies; 5+ messages in thread
From: jlicht @ 2023-02-26 20:50 UTC (permalink / raw)
  To: 61824; +Cc: Jelle Licht

From: Jelle Licht <jlicht@fsfe.org>

* gnu/packages/finance.scm (ledger): Update to 3.3.0.
---

 gnu/packages/finance.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index d2da017091..631985f377 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -311,7 +311,7 @@ (define-public homebank
 (define-public ledger
   (package
     (name "ledger")
-    (version "3.2.1")
+    (version "3.3.0")
     (source
      (origin
        (method git-fetch)
@@ -320,7 +320,7 @@ (define-public ledger
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0x6jxwss3wwzbzlwmnwb8yzjk8f9wfawif4f1b74z2qg6hc4r7f6"))
+        (base32 "09xn5v830lwzkmshhh42ik88gv6hazydb2jxd7kvvhd0k4g7l4yj"))
        (snippet '(begin
                    ;; Remove test that fails due to difference in
                    ;; reported error message (missing leading "./" in the
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#61824] [PATCH] gnu: ledger: Update to 3.3.0.
  2023-02-26 20:50 [bug#61824] [PATCH] gnu: ledger: Update to 3.3.0 jlicht
@ 2023-02-27 13:25 ` Guillaume Le Vaillant
  2023-02-28  1:21 ` [bug#61824] [PATCH v2] " jlicht
  1 sibling, 0 replies; 5+ messages in thread
From: Guillaume Le Vaillant @ 2023-02-27 13:25 UTC (permalink / raw)
  To: jlicht; +Cc: 61824

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi.
Did you try removing the snippet and the line disabling
the BaselineTest_cmd-org test in the 'check-setup' phase?
I tried and all the tests passed on my machine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#61824] [PATCH v2] gnu: ledger: Update to 3.3.0.
  2023-02-26 20:50 [bug#61824] [PATCH] gnu: ledger: Update to 3.3.0 jlicht
  2023-02-27 13:25 ` Guillaume Le Vaillant
@ 2023-02-28  1:21 ` jlicht
  2023-02-28  8:31   ` Guillaume Le Vaillant
  1 sibling, 1 reply; 5+ messages in thread
From: jlicht @ 2023-02-28  1:21 UTC (permalink / raw)
  To: 61824; +Cc: Guillaume Le Vaillant, Jelle Licht

From: Jelle Licht <jlicht@fsfe.org>

* gnu/packages/finance.scm (ledger): Update to 3.3.0.
[source]: Remove snippet.
[arguments]<#:phases>: Re-enable old test.

---

Changes in v2:
- enable now-working tests

 gnu/packages/finance.scm | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index d2da017091..82b20fd331 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -311,7 +311,7 @@ (define-public homebank
 (define-public ledger
   (package
     (name "ledger")
-    (version "3.2.1")
+    (version "3.3.0")
     (source
      (origin
        (method git-fetch)
@@ -320,14 +320,7 @@ (define-public ledger
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0x6jxwss3wwzbzlwmnwb8yzjk8f9wfawif4f1b74z2qg6hc4r7f6"))
-       (snippet '(begin
-                   ;; Remove test that fails due to difference in
-                   ;; reported error message (missing leading "./" in the
-                   ;; file name); started some time after Guix commit
-                   ;; 727f05e1e285aa52f5a19ec923fdc2259859b4b1
-                   (delete-file "test/regress/BF3C1F82-2.test")
-                   #true))))
+        (base32 "09xn5v830lwzkmshhh42ik88gv6hazydb2jxd7kvvhd0k4g7l4yj"))))
     (build-system cmake-build-system)
     (arguments
      `(#:modules (,@%cmake-build-system-modules
@@ -369,10 +362,6 @@ (define-public ledger
              (setenv "TZDIR"
                      (search-input-directory inputs
                                              "share/zoneinfo"))
-             ;; Skip failing test BaselineTest_cmd-org.
-             ;; This is a known upstream issue. See
-             ;; https://github.com/ledger/ledger/issues/550
-             (setenv "ARGS" "-E BaselineTest_cmd-org")
              #t)))))
     (inputs
      (list boost
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#61824] [PATCH v2] gnu: ledger: Update to 3.3.0.
  2023-02-28  1:21 ` [bug#61824] [PATCH v2] " jlicht
@ 2023-02-28  8:31   ` Guillaume Le Vaillant
  2023-03-06 14:09     ` bug#61824: " Jelle Licht
  0 siblings, 1 reply; 5+ messages in thread
From: Guillaume Le Vaillant @ 2023-02-28  8:31 UTC (permalink / raw)
  To: jlicht; +Cc: 61824

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

jlicht@fsfe.org skribis:

> From: Jelle Licht <jlicht@fsfe.org>
>
> * gnu/packages/finance.scm (ledger): Update to 3.3.0.
> [source]: Remove snippet.
> [arguments]<#:phases>: Re-enable old test.

LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#61824: [PATCH v2] gnu: ledger: Update to 3.3.0.
  2023-02-28  8:31   ` Guillaume Le Vaillant
@ 2023-03-06 14:09     ` Jelle Licht
  0 siblings, 0 replies; 5+ messages in thread
From: Jelle Licht @ 2023-03-06 14:09 UTC (permalink / raw)
  To: 61824-done; +Cc: Guillaume Le Vaillant


Pushed to master with an additional small version bump (3.3.0 -> 3.3.1)
that prevented crashes.

- Jelle




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-06 14:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-26 20:50 [bug#61824] [PATCH] gnu: ledger: Update to 3.3.0 jlicht
2023-02-27 13:25 ` Guillaume Le Vaillant
2023-02-28  1:21 ` [bug#61824] [PATCH v2] " jlicht
2023-02-28  8:31   ` Guillaume Le Vaillant
2023-03-06 14:09     ` bug#61824: " Jelle Licht

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).