From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uCVsECduEmShOAAASxT56A (envelope-from ) for ; Thu, 16 Mar 2023 02:17:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4ECdDyduEmQDsQAAG6o9tA (envelope-from ) for ; Thu, 16 Mar 2023 02:17:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFCD03856F for ; Thu, 16 Mar 2023 02:17:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pccEr-0001tx-A4; Wed, 15 Mar 2023 21:17:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pccEp-0001tl-97 for guix-patches@gnu.org; Wed, 15 Mar 2023 21:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pccEo-0001Qa-KC for guix-patches@gnu.org; Wed, 15 Mar 2023 21:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pccEo-0000Fn-5R for guix-patches@gnu.org; Wed, 15 Mar 2023 21:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#60266] [PATCH] gnu: Add form. Resent-From: Antero Mejr Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Mar 2023 01:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60266 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Eric Bavier Cc: 60266@debbugs.gnu.org Received: via spool by 60266-submit@debbugs.gnu.org id=B60266.1678929373904 (code B ref 60266); Thu, 16 Mar 2023 01:17:02 +0000 Received: (at 60266) by debbugs.gnu.org; 16 Mar 2023 01:16:13 +0000 Received: from localhost ([127.0.0.1]:40823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pccE0-0000EV-Ta for submit@debbugs.gnu.org; Wed, 15 Mar 2023 21:16:13 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:58966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pccDx-0000EF-QT for 60266@debbugs.gnu.org; Wed, 15 Mar 2023 21:16:10 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4PcTq52gv4z9skk; Thu, 16 Mar 2023 02:16:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1678929361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QUOOPvRTOr7znoMT8OOc0lfgZuf7Xe0v8nBqj5T3n5w=; b=Q+pflYcQsLGFiaRzhh8PO2eG0BSeYWIIV2XF1NKTRLCsFckYqnwfQDIZvsSO8BpHvFOMhc T3K/8AWceSm47W4RPr6/q8aeg5owTO1mvTfhKk3VKVcH6YWuA4gYouH6dx9Bv6DkKQkaNX yPVPuF8mVyNsLMDAGcTXnpwvXXAJWeUgwR3QfHcm7BqMoXvGulDXNvmLl/6g3a8V2qD3wT JFYb4VmJQloE/CRKLZaslx1dZqf3C8VyWocvJApZb5+T2/xzYAWvo5NQBwieqAsJKHQ+9W /Bf6gGLYMFeCKIutc58t55O0+PH3lzuJGU43OLGNuHMPxVXitmTNnKcJsa1+FQ== In-Reply-To: <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> (Eric Bavier's message of "Mon, 09 Jan 2023 18:01:33 +0000") References: <20221223011551.32708-1-antero@mailbox.org> <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> Date: Thu, 16 Mar 2023 01:15:51 +0000 Message-ID: <871qlpzebc.fsf@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain X-MBO-RS-META: 35ymkcjws83myez6uegbbgiutaj49phm X-MBO-RS-ID: 7058474efd6f7b1ed66 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Antero Mejr X-ACL-Warn: , Antero Mejr via Guix-patches From: Antero Mejr via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mailbox.org header.s=mail20150812 header.b=Q+pflYcQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678929447; a=rsa-sha256; cv=none; b=YfCu0VLM8skjKBNkCHajayZLbmD9zF+7qCSrkCiwJ51t2eZtjNTzPzYj08cblItTTUyP0t P9Km502Ue/I+DvRiGlHEyrIHPg3TckUNenprkzp4aXHNwXGWTlt+AnBdaj11+cneemdHQz emA8uguwVIzGbwr7c33b5q1minO7lP+n7CuLr1n+wAlsbSh7vYQd0I6X55cAPZn8j2gI4W fk4QmRk1zZ5w9BnkcOhXlZ0xQgckJRAXKt3aJqc67rP/SDTOOQywhBqxgBlBysvQJGSQoi qDE/f+vO0jg5zGkNttJVRC6HvIetFOJmsOaFcY7vyI68P2RG1PvARuGJTieoeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678929447; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=QUOOPvRTOr7znoMT8OOc0lfgZuf7Xe0v8nBqj5T3n5w=; b=BfrCO16ZXxzgFUyp2i/lWt0pKwwY4oGWKhilJ7Le4bN58wQiQdkpMFSqiPSKgQo8m3f28B BnQIzKHznUxrjhCUXutRtu4mEU1gIR0kSFL6A8CQBZD6iI1KDle8N5z3BRJsCE4q+gwax+ ZInhqnQmV6CwuGGVMU767CpZM+11JR1bKp4knA+RUcAwDaXpEJTdHoavxa5GP6Hh6nhFVC ZC/HXopPlahpX+/VtSAjsJPR2HS6a53gI2S7NsMxE1QVM9ddNyPaXdvu5aMbd9aAIExyZi UHk4R8/Qo6YGLPAmIRUJSCpCbvTS9R/Es1nz3RS3QFMIZJDKL6PViPZUx7dCow== X-Migadu-Spam-Score: -3.94 X-Spam-Score: -3.94 X-Migadu-Queue-Id: DFCD03856F X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mailbox.org header.s=mail20150812 header.b=Q+pflYcQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: 7o/HlP7WGNvi Eric Bavier writes: >> x86_64 only due to test failures on other platforms. Developers >> say other platforms are not "tier 1" supported: >> https://github.com/vermaseren/form/issues/426 > > This may be better as a comment near the `supported-systems` field, > along with a short summary of which tests fail on other systems. Added comments in v2. > This commit is downstream from the 4.3.0 release, so we should include > in a comment the rationale for not using just the 4.3.0 release > tarball. Added rationale. >> + (snippet #~(substitute* "check/examples.frm" >> + (("#pend_if valgrind\\?") >> + "#pend_if 0"))))) > > This snippet appears to be related to the specifics of this package > build? E.g. if someone were to grab the source with `guix build -S > form`, they would not be able to have valgrind support, correct? If > that's the case, perhaps it would be better to apply this substitution > in a build phase. No, it's disabling a failing test that has a known problem (memory leak). Added a comment with the explanation. > For some other maths packages that have both a serial and MPI versions, > we've usually provided two packages. See e.g. `petsc` and `petsc- > openmpi`. This can be useful if someone does not need a full MPI- > capable version of form, and the separation is easily achieved. Moved the openMPI version to the parform package. > Also, I see the default compilation flags include `-march=native`, > which will most likely cause a problem with build farm substitutes or > `guix challenge`. Could you figure out have to override these flags? > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc. > Bonus points for enabling a "tunable" package (c.f. "Package > Transformation Options"). Disabled --march=native in v2. > Maybe we should use https://www.nikhef.nl/~form/ instead? This is the > URL specified in the included manpage. I used the other homepage so people can skip the weird "license agreement" page at https://www.nikhef.nl/~form/. But I changed it to your suggestion in v2. Thanks for the review.