From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +JzOGZEsVWSIWAEASxT56A (envelope-from ) for ; Fri, 05 May 2023 18:19:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EAnsGJEsVWRTQAEAG6o9tA (envelope-from ) for ; Fri, 05 May 2023 18:19:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D719E47F for ; Fri, 5 May 2023 18:19:29 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puy99-0003m4-Bs; Fri, 05 May 2023 12:19:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puy98-0003lf-QU for guix-patches@gnu.org; Fri, 05 May 2023 12:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puy98-0000H0-IG for guix-patches@gnu.org; Fri, 05 May 2023 12:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puy98-0005KK-12 for guix-patches@gnu.org; Fri, 05 May 2023 12:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 May 2023 16:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.168330349920421 (code B ref 63215); Fri, 05 May 2023 16:19:01 +0000 Received: (at 63215) by debbugs.gnu.org; 5 May 2023 16:18:19 +0000 Received: from localhost ([127.0.0.1]:57313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puy8R-0005JJ-A3 for submit@debbugs.gnu.org; Fri, 05 May 2023 12:18:19 -0400 Received: from mail-qk1-f182.google.com ([209.85.222.182]:45236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puy8M-0005J3-Tw for 63215@debbugs.gnu.org; Fri, 05 May 2023 12:18:17 -0400 Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-74d2597fdb2so94905485a.2 for <63215@debbugs.gnu.org>; Fri, 05 May 2023 09:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683303489; x=1685895489; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=o/JqXkJZswTFCJj9auh1RKRV0IUVAwQ+6lpvNaFo3QY=; b=GFYvHhFaAwey08k+fE1q2eqG6hUxLgQaiMe7pe74Rxqlyhs7tNlY0ys+XyG9qXhIov HVaytC4VIPZpAxogFpvSOs16lhRZheikLrzwRj5xH9NLmA1FwrnC/KmNS+D6uXztIvdO AO8bbKVb5snLa3JM8BtjTbcnZ0MrHDeOWkO0zKFb+jd7Z8H5/beEE9j/go6JEXn55D0q oSQ1CrvXHuOe0Ox/0YS3vjSQ3raYmaGrGb/Z/JiNBKbvfboMamie3OCVkF/ZnKe7lxpp 6vPMdRYOttXisR6CProh3CgqQOpYRHFMjA7rNspkNUDrSJkzvRfmZvaTy4lfztx4CK6G Y7TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683303489; x=1685895489; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o/JqXkJZswTFCJj9auh1RKRV0IUVAwQ+6lpvNaFo3QY=; b=lRxonsOWoQuKhoq9HL1lD6P8scPwfUnWxobWjSiIb1uyh3vly+EFcFZmuDJZ0Kqk+l YVtJFIiy/EZcSpv1rYgK/j+D8NoT/2wAAmcKuSXnY5zSyyyb56r+amTLrEMbPYja2Mx6 9YzNySN52ROM2jrAfTaBMQoTR9JCWJK/R/YAJKOB6+8sxxP1pHa//BjzptcmX9qrlbdU vU4mmJ4jLnWrvALg+17lnXUIGaJBjbIgRK8VSggrssChLVpOYeVomfNbk/jLJhBcJrvJ HDPPBSbFNkoRqJz6P5ybbuZ6ERKAjTOfCIGLxyQm+zNjPxFmoPjHkDeHwuxOOurwykSt VDPQ== X-Gm-Message-State: AC+VfDyMsdF7E64aRRi4aAQ1TZTCAoQPdpkgOpaf/gbqIvdIUDmefiqf 90SyOL0KXhGQ2gkDhP+x+yrVy6We3Jk= X-Google-Smtp-Source: ACHHUZ50hClgMC4lXJ1wlYo46EZi5NUUGHFGNr/Yiz/0ge3gSO2uRj58N2Yeic/zAEBDg6OCCGZP4A== X-Received: by 2002:a05:622a:452:b0:3ef:3402:dda4 with SMTP id o18-20020a05622a045200b003ef3402dda4mr2910620qtx.32.1683303488909; Fri, 05 May 2023 09:18:08 -0700 (PDT) Received: from hurd (dsl-205-236-230-162.b2b2c.ca. [205.236.230.162]) by smtp.gmail.com with ESMTPSA id ch7-20020a05622a40c700b003e3860f12f7sm717416qtb.56.2023.05.05.09.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 09:18:08 -0700 (PDT) From: Maxim Cournoyer References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> <87jzxnbkqt.fsf@systemreboot.net> <87a5yic3mw.fsf@systemreboot.net> Date: Fri, 05 May 2023 12:18:07 -0400 In-Reply-To: <87a5yic3mw.fsf@systemreboot.net> (Arun Isaac's message of "Fri, 05 May 2023 14:24:39 +0100") Message-ID: <871qju4urk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683303569; a=rsa-sha256; cv=none; b=PAWWSQSCh2J4Z5uTmJ5Fysmnlwfp0WHnxCN+dOGRoDCIBfeoDHme3TpJlGLndbvajOTfWe ABp5A5hoRzPE4RwHMI4a6fIZgYIiCUg9b64zQ8mpKuv3Lnwu5OwrgSJcPg1yu5IDqk2/C6 uJGSdWALxLk97uVx/VJUzrXNEZHa8p/J9b/0dSD+ePNPxiV/VJ0CZ4eTGsgb3yRa6bLGG0 FgWTL10JSIw4DWsCJ9nVC/MYhrumNn4zn4moqdtiKfzj8XegloBIQhWl+iotlXPfKv91PA J0eVt1GpGlpZDzPEHFKsMqU1WHgmutUJnY57nXi73AB3R4hA7E2b3yiAxyNKKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=GFYvHhFa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683303569; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=o/JqXkJZswTFCJj9auh1RKRV0IUVAwQ+6lpvNaFo3QY=; b=DrYds98x+uxAWJQqfVLxHYVXJGydEMjlgs1kolNVb/Hy7UrV5HMOM10v+Z9NS/Xrnd/jGo 056sT5E56Qci96wL/R6fCmzUmoDT/xnNj1t4rbZx0X/xBY/GWxNHERLjezI2Ncysrxd1Al jQ0lYMs0H8EU/rqxUNyIuor725+Q+S8vcz1pZmmThyrgih29F+pUYJCaVCs+XRTJRLC+eN NY/XBEeP4XIXK1ZU2jqwpu2qbm4BNweMr311Uqb4NrvIbiZbPvliLP8ArI7T1XIV5WLN5A zMFvKQmYCUXINXXFnzlLfYKlg/mbUGNkgppkmHEZ1SiNow5uoB4OWOud1uVZXA== X-Migadu-Spam-Score: -2.60 X-Spam-Score: -2.60 X-Migadu-Queue-Id: 1D719E47F X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=GFYvHhFa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: oDEOgZS2/Q+8 Hi Arun, Arun Isaac writes: >> Yes, that makes sense! I will send a new patchset. According to >> https://www.debian.org/Bugs/Reporting#xcc , if we want to send copies to >> multiple addresses, we should put them in as a comma-separated list in >> the same X-Debbugs-Cc header. teams.scm seems to be putting in multiple >> X-Debbugs-Cc headers. Maybe we should change that? > > I just realized that using comma-separated lists calls for the > functionality of teams.scm to be moved into `mumi send-email'. If > teams.scm and `mumi send-email' remain separate, they will each produce > a separate comma-separated list of X-Debbugs-Cc addresses, and we will > be back to square one with multiple X-Debbugs-Cc headers. > > WDYT? What is the best way forward? If you meant that it's mumi instead of git that should call etc/teams.scm, it makes sense. I'm not sure the functionality of teams.scm proper should be moved wholesale into mumi, as it's useful outside of mumi (for plain git users, say). Mumi could invoke etc/teams.scm to produce the list of team members for the changes involved, add any missing collaborators retrieved from the message data to the set (avoiding duplicates), then format the 'X-Debbugs-CC' header with comma-separated values. It should then invoke git with the '--no-header-cmd' option to avoid teams.scm being called again. Note that our teams.scm script currently generate distinct X-Debbugs-CC header for each participant. The Debbugs copy used by GNU is the one hosted at [0], which doesn't mention the comma-separated requirement/suggestion, so I think that's currently OK, although I'm not too confident in my reading of the 'process' Perl script [1]. At any rate it'd be easy to adjust in teams.scm. The email specification mentions that some special fields such as To and Cc should be separated by commas, but says nothing about custom fields [2], so in my opinion both forms should be supported by Debbugs (and probably are, although it's hard to say without trying). [0] https://gitlab.com/npostavs/debbugs/-/tree/gnu-reconstruction?ref_type=heads [1] https://gitlab.com/npostavs/debbugs/-/blob/gnu-reconstruction/scripts/process [2] https://datatracker.ietf.org/doc/html/rfc5322#section-3.6 -- Thanks, Maxim