From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SFrhKzDwuGR2oQAASxT56A (envelope-from ) for ; Thu, 20 Jul 2023 10:28:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0LIaKzDwuGRkmQAAG6o9tA (envelope-from ) for ; Thu, 20 Jul 2023 10:28:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 462F23BF60 for ; Thu, 20 Jul 2023 10:28:32 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="L/JmGNkR"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689841712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=D+/cNyUnXy8mxWjbtFG6FUAwOkjoEdHLkF9/HJtXnW0=; b=DI4kx/xvyM4aU4Rpw+oxLsUyJKjWMfmo5f4I4BGECSp6QQ54yEEWZZ/4FVxUhVn/dXZScg FhJJOnXLG102SteiYrtZgVsCQKq3eCkbDH5TALRFCBVLkTnzukrTYrk4nf+wbs64ME1zec fx3eyh25EGnjSFXCYxV6XqWKV4ROT4ZvTP4Z6TIAxGwVgu1VoE+5jxPcalIPLKbsQkmp9x G0eCsbO2/jPWSikWkiMyxUlhxIyWjKOEubHRci8X8dE3Hqcj3n3e40sgdy5usF0nU72lTP hCGwsokrGfR8O2iO2JLgLw5oLZszyPT82P/qZf+PsrtQqYBZUX4abZTrqydv5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689841712; a=rsa-sha256; cv=none; b=Z8g0utJDtONXZ9iugKHmP4mENGOwTgaWJDYeypTTLuQok4rQd6atADfRAtZ5YiwEISNgDl DHYKpTk2iyVGkzSoJr/NPKq8vrywelKpMqvk+Q8NUXb6JI8KFTbf4U6oomu08slhNY61s9 yqPxb+d4ie6prp2TEvhhGp6yeu+S/WVzeUz3EGaRYt3KIcaNac28mWjpmqQNT0GkHFf1Mr ODwEnPNgDoZftAU3uD5YKBFylOzLlymaeogZnTIMpnKbGgBZoRK3ab/5I/ghHW51rjctgY dspLV0vkBKwYZwYMUidHIEubevR1Xyfg6KDjvxzyCzCe2JtXWDAq1sDigDfrAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="L/JmGNkR"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMP1A-0005K9-6C; Thu, 20 Jul 2023 04:28:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMP11-0005JU-15 for guix-patches@gnu.org; Thu, 20 Jul 2023 04:28:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMP10-0004ab-Oy for guix-patches@gnu.org; Thu, 20 Jul 2023 04:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMP10-0006RG-8H for guix-patches@gnu.org; Thu, 20 Jul 2023 04:28:02 -0400 Subject: bug#64711: [PATCH 00/45] Fix builds and skip failing tests for the Hurd. Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 20 Jul 2023 08:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 64711-done@debbugs.gnu.org Mail-Followup-To: 64711@debbugs.gnu.org, janneke@gnu.org, janneke@gnu.org Received: via spool by 64711-done@debbugs.gnu.org id=D64711.168984164624680 (code D ref 64711); Thu, 20 Jul 2023 08:28:01 +0000 Received: (at 64711-done) by debbugs.gnu.org; 20 Jul 2023 08:27:26 +0000 Received: from localhost ([127.0.0.1]:57636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMP0P-0006Q0-O8 for submit@debbugs.gnu.org; Thu, 20 Jul 2023 04:27:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMP0L-0006Pe-Fh for 64711-done@debbugs.gnu.org; Thu, 20 Jul 2023 04:27:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMP0F-0004W5-9l; Thu, 20 Jul 2023 04:27:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=D+/cNyUnXy8mxWjbtFG6FUAwOkjoEdHLkF9/HJtXnW0=; b=L/JmGNkRZXeoXAADWLDO o+AXIowcJZ/QlcTF1gKuB8HMLbBXstmF2iStZB76TGamsErYzGkakegbGqT/AlzYlieBYIjy/dsHU HpYWJjhIUCO9Fb8zdr3k838syPjOGyAkFDn1FXgDR7kofWrhu8Z81ketkKFgCPBx7WLfmBsdoWeUG dk7IeG1ESSCq85L3QISkc4q2+9jiruSarr/DHa6VwkTRTQtA3JtfA+bzX3trsVfeutK7wIgRoonQr dIzM6FLNGmyu7VamCV6vAteMavvTmD9sbCzjBEg73f37/voA36ODtQXm5LjEFkjcRCLrTuoat0y4c Sin/OvX2PIiTew==; Received: from 2a02-a462-da03-1-aeb0-2f5e-e96a-dccb.fixed6.kpn.net ([2a02:a462:da03:1:aeb0:2f5e:e96a:dccb] helo=drakenpad.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMP0E-0002Iu-Sh; Thu, 20 Jul 2023 04:27:15 -0400 From: Janneke Nieuwenhuizen Organization: AvatarAcademy.nl References: <87cz0pge0c.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Thu, 20 Jul 2023 10:27:10 +0200 In-Reply-To: <87cz0pge0c.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 18 Jul 2023 22:29:07 +0200") Message-ID: <871qh3ugwx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -5.34 X-Spam-Score: -5.34 X-Migadu-Queue-Id: 462F23BF60 X-TUID: hXC6g7Ejssp7 Ludovic Court=C3=A8s writes: Hi, > Janneke Nieuwenhuizen skribis: > >> Also, most probably problematic tests in the guile test suite were fixed= on >> guile master. As I understand, Josselin is working on this, so way may = want >> to skip the patch for guile (or apply it anyway and revert it later). >> >> Because many patches are almost trivial and similar, you may want to giv= e some >> specific comments to the non-trivial patches and possibly some general >> comments for the trivial ones instead of a LGTM on every individual patc= h? > > So modulo the few comments I sent, I think this looks good. \o/ > There=E2=80=99s a couple of things to check (which I haven=E2=80=99t do): > > =E2=80=A2 Make sure x86_64-linux derivations (for instance) are unchang= ed. > That is, =E2=80=98./pre-inst-env guix build libreoffice -d=E2=80=99 s= hould produce > the same thing before and after this patch series, on x86_64-linux. > (Pro tip: replace =E2=80=98-d=E2=80=99 with =E2=80=98-n=E2=80=99; if = there are substitutes, it means > it hasn=E2=80=99t changed. :-)) Ah, that's a nice trick. Checked! What I did, was after developing each patch (only) check that x86_64 package didn't get rebuilt. > =E2=80=A2 Make sure =E2=80=98guix build sed --target=3Di586-pc-gnu=E2= =80=99 still works. > Probably the derivation should be unchanged, but maybe it=E2=80=99s O= K if it > changes (sometimes avoiding a cross-rebuild would require extra > boilerplate that we=E2=80=99d rather not have). Checked! (It changed, of course). > =E2=80=A2 And well, =E2=80=98guix build sed -s i586-gnu=E2=80=99 should= work as well, but > that=E2=80=99s the whole point of this series! Checked! -- but here I cheated a bit, I've only checked this before rebasing. > Thanks a lot for all the work! Thank you (and other reviewers) for all the help! Pushed to master as 6547d3852b11966271535962110d9e68f50c95fc Janneke --=20 Janneke Nieuwenhuizen | GNU LilyPond https://LilyPond.org Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade= my.com