From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: "Sergio Pastor Pérez" <sergio.pastorperez@outlook.es>
Cc: 64957@debbugs.gnu.org
Subject: [bug#64957] [PATCH v2] gnu: Add fontmake.
Date: Mon, 31 Jul 2023 15:25:38 +0800 [thread overview]
Message-ID: <871qgoa6fh.wl-hako@ultrarare.space> (raw)
In-Reply-To: <DU2P193MB21325E442346CEE15890963BF304A@DU2P193MB2132.EURP193.PROD.OUTLOOK.COM>
On Mon, 31 Jul 2023 06:22:17 +0800,
Sergio Pastor Pérez wrote:
>
> * gnu/packages/fontutils.scm (fontmake): New variable.
> ---
[...]
> Regarding your concern for the version bump, its currently not possible to
> update to `fontamke@3.6.1', this is blocked by the versions of the dependencies;
> for example, the latest versions we have available on the official guix channel
> of `python-glyphslib' is 6.0.7 and `fontmake@3.6.1' requires
> `python-glyphslib@6.2.5'.
Ah, I see. A newer python-ufolib2 is also required, which requires a
newer python-attrs. I'll look into updating python-attrs.
I'm not sure if an old version will be accepted, so you may have to
wait a bit. ;)
> + (inputs (list python-attrs
> + python-fontmath
> + python-fonttools-minimal
> + python-glyphslib
> + python-ufo2ft
> + python-ufolib2))
Most of the dependencies here have been propagated by python-glyphslib
and its dependencies. It's sufficient to keeping only
`python-fontmath' and `python-glyphslib'.
But you can also keep them all if you prefer, in which case I'd
suggest replacing `python-fonttools-minimal' with `python-fonttools',
since the latter has been propagated by python-glyphslib.
> + (synopsis
> + "Compile fonts from sources (UFO, Glyphs) to binary (OpenType, TrueType)")
> + (description
> + "Fontmake compiles fonts from various sources (.glyphs, .ufo,designspace)
> +into binaries (.otf, .ttf). You can use it to create static instances and
> +variable fonts.")
"@code{.glyphs}, @code{.ufo}, @code{designspace}" and so on.
How about changing "You can use it" to "It can be used" ?
> + (license license:asl2.0)))
> +
> (define-public psautohint
> (package
> (name "psautohint")
>
> base-commit: c173819c8e5235ce02d60b79bd88b10023a7c614
> prerequisite-patch-id: c56db9fa7fc4e07452dea53f2d450bd83abbbc1a
> prerequisite-patch-id: 3e6318d61f2efa01f4435152f2139eef8f72572c
> prerequisite-patch-id: 1b23c59bab92820a1e102137909922f4d71ed8f9
> prerequisite-patch-id: 78a291411f8d86beabbf6d49df0cc78702ad4e65
> prerequisite-patch-id: 579224b39cae7869ce11e2e8dba046b5eef606c7
> prerequisite-patch-id: f1f62fd5d83d603ca35c17071e615352e90753e3
> prerequisite-patch-id: 1843bca37f83e494be67c24e975727fb1fe1248c
> prerequisite-patch-id: 5cc0d6cd16ae2ab21c444ed9cabfeea5615e8cda
> prerequisite-patch-id: 92a3fab6e4174a4d4877fc5b426752df81e4df39
> prerequisite-patch-id: ebf3fd3a8bb02f7dc5cdf504f63d5028b29fe69e
> --
> 2.39.2
Overall LGTM, except for the version thing.
Thanks
next prev parent reply other threads:[~2023-07-31 7:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 15:35 [bug#64957] [PATCH] gnu: Add python-fontmake Sergio Pastor Pérez
2023-07-30 15:45 ` [bug#64957] [PATCH vREVISION] " Sergio Pastor Pérez
[not found] ` <hako@ultrarare.space>
2023-07-30 18:06 ` Hilton Chain via Guix-patches via
2023-07-30 22:22 ` [bug#64957] [PATCH v2] gnu: Add fontmake Sergio Pastor Pérez
2023-07-31 7:25 ` Hilton Chain via Guix-patches via [this message]
2023-07-31 8:29 ` [bug#64957] [PATCH v3] " Sergio Pastor Pérez
2023-07-31 16:39 ` Hilton Chain via Guix-patches via
2023-08-01 7:05 ` [bug#64957] [PATCH v4] " Sergio Pastor Pérez
2023-09-06 4:52 ` bug#64957: [PATCH] gnu: Add python-fontmake Maxim Cournoyer
[not found] ` <handler.64957.D64957.16939759387992.notifdone@debbugs.gnu.org>
2023-09-06 5:25 ` [bug#64957] " Maxim Cournoyer
2023-09-06 17:22 ` Sergio Pastor Pérez
2023-09-06 18:43 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qgoa6fh.wl-hako@ultrarare.space \
--to=guix-patches@gnu.org \
--cc=64957@debbugs.gnu.org \
--cc=hako@ultrarare.space \
--cc=sergio.pastorperez@outlook.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).