From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: aurtzy <aurtzy@gmail.com>
Cc: 65031@debbugs.gnu.org
Subject: [bug#65031] [PATCH] gnu: Add syncplay.
Date: Tue, 05 Sep 2023 10:54:43 -0400 [thread overview]
Message-ID: <871qfck6vg.fsf@gmail.com> (raw)
In-Reply-To: <20230803061517.27336-1-aurtzy@gmail.com> (aurtzy@gmail.com's message of "Thu, 3 Aug 2023 00:35:28 -0400")
Hi,
aurtzy <aurtzy@gmail.com> writes:
> * gnu/packages/networking.scm (syncplay): New variable.
> ---
> gnu/packages/networking.scm | 52 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 488d015107..10eb19e980 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -60,6 +60,7 @@
> ;;; Copyright © 2023 Bruno Victal <mirai@makinata.eu>
> ;;; Copyright © 2023 Yovan Naumovski <yovan@gorski.stream>
> ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
> +;;; Copyright © 2023 aurtzy <aurtzy@gmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -4644,3 +4645,54 @@ (define-public dropwatch
> recording packets that are dropped by the kernel. It provides the commands
> @command{dropwatch} and @command{dwdump}.")
> (license license:gpl2+)))
> +
> +(define-public syncplay
> + (package
> + (name "syncplay")
> + (version "1.7.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/Syncplay/syncplay.git")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "061kpnb48lad8rr8v58xac33mwpbrixfbhn7d0xa63zpxg43bvsd"))))
> + (build-system gnu-build-system)
> + (arguments
> + (list #:imported-modules `(,@%gnu-build-system-modules (guix build
> + qt-utils)
> + (guix build utils))
> + #:modules '((guix build gnu-build-system)
> + (guix build qt-utils)
> + (guix build utils))
> + #:make-flags #~`("DESTDIR=" ,(string-append "PREFIX="
> + (assoc-ref %outputs
> + "out")))
> + #:phases #~(modify-phases %standard-phases
> + (delete 'configure)
> + (delete 'build)
> + (delete 'check)
> + (add-after 'install 'wrap-qt
> + (lambda* (#:key inputs #:allow-other-keys)
> + (wrap-qt-program "syncplay"
> + #:output #$output
> + #:inputs inputs))))))
> + (inputs (list bash-minimal qtwayland-5))
Is it compatible with Qt 6? To try it, replace qtwayland-5 with
qtwayland, and specify a #:qtbase qtbase argument.
> + (propagated-inputs (list python
> + python-service-identity
> + python-twisted
> + python-pyside-2
> + python-certifi
> + python-idna))
These should be inputs, not propagated-inputs, unless it can be used as
a library? Also, please sort the inputs alphabetically.
> + (home-page "https://syncplay.pl")
> + (synopsis "Client/server to synchronize media playback on many computers")
> + (description
> + "Syncplay is a solution to synchronize video playback across multiple
> +instances of media players over the Internet. When one person pauses/unpauses
> +playback or skips to a position in the video, this is replicated across all
> +media players connected to the same server and in the same \"room\" (viewing
> +session). A built-in text chat for discussing the synced media is also
> +included for convenience.")
> + (license license:asl2.0)))
The rest LGTM. Could you please send a v2?
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-09-05 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 4:35 [bug#65031] [PATCH] gnu: Add syncplay aurtzy
2023-09-05 14:54 ` Maxim Cournoyer [this message]
2023-09-21 19:37 ` [bug#65031] [PATCH v2] " aurtzy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qfck6vg.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=65031@debbugs.gnu.org \
--cc=aurtzy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).