unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#68859] [PATCH] gnu: Add cl-modf.
@ 2024-01-31 23:58 Charles via Guix-patches via
  2024-02-01  0:29 ` [bug#68859] [PATCH v2] " Charles via Guix-patches via
  0 siblings, 1 reply; 3+ messages in thread
From: Charles via Guix-patches via @ 2024-01-31 23:58 UTC (permalink / raw)
  To: 68859
  Cc: Charles, Guillaume Le Vaillant, Katherine Cox-Buday,
	Munyoki Kilyungi, Sharlatan Hellseher, jgart

* gnu/packages/lisp-xyz.scm (sbcl-modf, cl-modf, ecl-modf): New variables.

Change-Id: Ic7e8e4511ca537531a7d9aa134e671aca060aa09
---
I used the quicklisp importer again for this one.

Also guix lint complains about "synopsis should start with an upper-case letter or digit", but I figure it should be fine to start with a @code.

 gnu/packages/lisp-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index ae71c67009..afe9c1bdbb 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -11550,6 +11550,42 @@ (define-public ecl-fset
      ;; Tests fails on ECL with "The function FSET::MAKE-CHAR is undefined".
      '(#:tests? #f))))
 
+(define-public sbcl-modf
+  (let ((commit "dea93fe62c6bf7f66f32f52ac0c555aedbf7abad")
+        (revision "0"))
+    (package
+      (name "sbcl-modf")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/smithzvk/modf")
+               (commit commit)))
+         (file-name (git-file-name "sbcl-modf" version))
+         (sha256
+          (base32
+           "1aap7ldy7lv942khp026pgndgdzfkkqa9xcq1ykinrmflrgdazay"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs
+       (list sbcl-alexandria
+             sbcl-closer-mop
+             sbcl-iterate))
+      (native-inputs
+       (list sbcl-stefil))
+      (home-page "https://github.com/smithzvk/modf")
+      (synopsis "@code{setf} like macro for functional programming in Common Lisp")
+      (description "This library simplifies functional programming in Common
+Lisp by making it easier to make new data structures with specified changes in
+place.")
+      (license license:bsd-3))))
+
+(define-public cl-modf
+  (sbcl-package->cl-source-package sbcl-modf))
+
+(define-public ecl-modf
+  (sbcl-package->ecl-package sbcl-modf))
+
 (define-public sbcl-cl-cont
   (let ((commit "fc1fa7e6eb64894fdca13e688e6015fad5290d2a")
         (revision "1"))

base-commit: 73d8e5a9352304a5192b22e04ef022234488e0da
prerequisite-patch-id: 45d179497c5c23d36ba555ff93d47a18276835ab
prerequisite-patch-id: 57958f0ec7271916a336f2d490f8edeabb429322
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#68859] [PATCH v2] gnu: Add cl-modf.
  2024-01-31 23:58 [bug#68859] [PATCH] gnu: Add cl-modf Charles via Guix-patches via
@ 2024-02-01  0:29 ` Charles via Guix-patches via
  2024-02-05 13:37   ` bug#68859: " Guillaume Le Vaillant
  0 siblings, 1 reply; 3+ messages in thread
From: Charles via Guix-patches via @ 2024-02-01  0:29 UTC (permalink / raw)
  To: 68859
  Cc: Charles, Guillaume Le Vaillant, Katherine Cox-Buday,
	Munyoki Kilyungi, Sharlatan Hellseher, jgart

* gnu/packages/lisp-xyz.scm (sbcl-modf, cl-modf, ecl-modf): New variables.

Change-Id: Ic7e8e4511ca537531a7d9aa134e671aca060aa09
---
I just saw that you change the git-file-name to use the package name, so I updated this patch to do the same.

 gnu/packages/lisp-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index b764d6b885..8c9ee783a4 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -11552,6 +11552,42 @@ (define-public ecl-fset
      ;; Tests fails on ECL with "The function FSET::MAKE-CHAR is undefined".
      '(#:tests? #f))))
 
+(define-public sbcl-modf
+  (let ((commit "dea93fe62c6bf7f66f32f52ac0c555aedbf7abad")
+        (revision "0"))
+    (package
+      (name "sbcl-modf")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/smithzvk/modf")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1aap7ldy7lv942khp026pgndgdzfkkqa9xcq1ykinrmflrgdazay"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs
+       (list sbcl-alexandria
+             sbcl-closer-mop
+             sbcl-iterate))
+      (native-inputs
+       (list sbcl-stefil))
+      (home-page "https://github.com/smithzvk/modf")
+      (synopsis "@code{setf} like macro for functional programming in Common Lisp")
+      (description "This library simplifies functional programming in Common
+Lisp by making it easier to make new data structures with specified changes in
+place.")
+      (license license:bsd-3))))
+
+(define-public cl-modf
+  (sbcl-package->cl-source-package sbcl-modf))
+
+(define-public ecl-modf
+  (sbcl-package->ecl-package sbcl-modf))
+
 (define-public sbcl-cl-cont
   (let ((commit "fc1fa7e6eb64894fdca13e688e6015fad5290d2a")
         (revision "1"))

base-commit: bf7991a8c767abd32cfb2c92e3d57665a7cabf00
prerequisite-patch-id: bcaf8eb7f369a54bf47e9c7ef7b94fda2295de4a
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#68859: [PATCH v2] gnu: Add cl-modf.
  2024-02-01  0:29 ` [bug#68859] [PATCH v2] " Charles via Guix-patches via
@ 2024-02-05 13:37   ` Guillaume Le Vaillant
  0 siblings, 0 replies; 3+ messages in thread
From: Guillaume Le Vaillant @ 2024-02-05 13:37 UTC (permalink / raw)
  To: Charles; +Cc: 68859-done

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Charles <charles@charje.net> skribis:

> I just saw that you change the git-file-name to use the package name, so I updated this patch to do the same.

Usually when packaging the xyz Common Lisp package, we use "cl-xyz" as
name for the sources instead of "sbcl-xyz" to indicate that the sources
are not specific to sbcl (as they are also used for the cl-xyz and
ecl-xyz packages).

Patch applied as 87f5876e60922a032b253c43964d2e455d14955a.
Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-05 13:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-31 23:58 [bug#68859] [PATCH] gnu: Add cl-modf Charles via Guix-patches via
2024-02-01  0:29 ` [bug#68859] [PATCH v2] " Charles via Guix-patches via
2024-02-05 13:37   ` bug#68859: " Guillaume Le Vaillant

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).