From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id MLnFAKNw3GVhKgEAqHPOHw:P1 (envelope-from ) for ; Mon, 26 Feb 2024 12:06:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id MLnFAKNw3GVhKgEAqHPOHw (envelope-from ) for ; Mon, 26 Feb 2024 12:06:11 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708945570; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=O4CZRTdtT1lMiN1z2fxYptCONXyNla8R6OeQbfhinDo=; b=sAKqrb/cO3dYkGkCWdxuvBWUXFrEbSBnpifRYUzV7lc2ksSBmd+r2NNJEex4gsthH1IB77 CQrjCob0wwByeP9FiBJlc2U0NYlMqj3fkL6eVnC/HNPwFvm0wyL7pnqphVtE8yDVAIfPpB /43ycwzIY1E0XbdrYu8TbMkp4Tne77AZQgQ7WaL/W4Ooz4WWOBkc6YLPacP5UHHqexn4ac AD1RpUR72dT8A5mGGzX8fotZjE0XBQgjxt6CGRZJDLoWI726fxyRCHf21wuMKEX3badSo4 WimAYuutqOuByN3qo4+OMStUAT3r7JWwJNUfEflvPqSYh3w/RpfZjtwQoyEvJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708945570; a=rsa-sha256; cv=none; b=fcymieJOyT19jKKMoqnsvfkg3JMG0IVJbi0BGYzFz/NWkxx6pG5n5/XPlfjm3RbcO5Fy1Y QC0YbYaXwLNhisv7bBhtotK9lqyVP2DjflUmRd2j+9nqB+x7W5uaa+6maexWiFLySk9p0o rlTXtda8UBjzYiMlqzunU4w6qKpihkYeBNffkYaIhz4QaD9wHw9rJkrcL0bTCaizDTOgOu dYtMj9yHSkYvdtOlQcF0xlcpRabeyPxSDR1o3mHF5zbjMtARd3mZYIT0YvQYeOSzcKnvmJ 6vBIpTJoKp9bCciWHgBiBzrAzlototazIIQqg/Pahid8wh6KzkFrslWu8c9Yqg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D9D361DCEE for ; Mon, 26 Feb 2024 12:06:10 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reYnk-00041G-MD; Mon, 26 Feb 2024 06:05:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reYnh-00040b-6V for guix-patches@gnu.org; Mon, 26 Feb 2024 06:05:37 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reYng-0006yo-U8 for guix-patches@gnu.org; Mon, 26 Feb 2024 06:05:36 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1reYo5-00033z-Pg for guix-patches@gnu.org; Mon, 26 Feb 2024 06:06:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69292] [PATCH 6/6] store: database: Rename a couple of procedures. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Feb 2024 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69292 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 69292@debbugs.gnu.org, Christopher Baines Received: via spool by 69292-submit@debbugs.gnu.org id=B69292.170894555811761 (code B ref 69292); Mon, 26 Feb 2024 11:06:01 +0000 Received: (at 69292) by debbugs.gnu.org; 26 Feb 2024 11:05:58 +0000 Received: from localhost ([127.0.0.1]:55141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reYo2-00033b-FF for submit@debbugs.gnu.org; Mon, 26 Feb 2024 06:05:58 -0500 Received: from mira.cbaines.net ([212.71.252.8]:43166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reYnz-00033L-5R for 69292@debbugs.gnu.org; Mon, 26 Feb 2024 06:05:56 -0500 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id E580D27BBE2; Mon, 26 Feb 2024 11:04:58 +0000 (GMT) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id a7bdadfd; Mon, 26 Feb 2024 11:04:58 +0000 (UTC) References: <4b6a268daab5e0b307dff2229d551a47c9fe1ebc.1708457946.git.mail@cbaines.net> <12f872394c84039fa553e50381d040de24f24d3e.1708457946.git.mail@cbaines.net> <87zfvrdtcw.fsf@gnu.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Christopher Baines Date: Mon, 26 Feb 2024 11:03:04 +0000 In-reply-to: <87zfvrdtcw.fsf@gnu.org> Message-ID: <871q8z8p0n.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.83 X-Spam-Score: -6.83 X-Migadu-Queue-Id: D9D361DCEE X-TUID: JX9kJn7Yc8zk --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> These names should be more descriptive. >> >> * guix/store/database.scm (path-id): Rename to select-valid-path-id. >> (sqlite-register): Rename to register-valid-path. >> (register-items): Update accordingly. >> >> Change-Id: I6d4a14d4cde9d71ab34d6ffdbfbfde51b2c0e1db > > OK for =E2=80=98register-valid-path=E2=80=99. > > For =E2=80=98path-id=E2=80=99 my preference would be =E2=80=98valid-path-= id=E2=80=99 or keeping > =E2=80=98path-id=E2=80=99; =E2=80=98select=E2=80=99 looks odd as nothing= =E2=80=99s being =E2=80=9Cselected=E2=80=9D here in the > non-SQL sense of the word. The main thing I'm trying to do here is make the procedures that directly interact with the database stand out (similar to the ! suffix convention). Maybe the procedure taking the db as an argument is enough, but to me path-id/valid-path-id look too much like record accessors. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmXccFhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeODA/+P0cbrvuITjA3nD1phTqlKCrJQqQX+i+9 mJ7viwHgbsn0+xoxNRBVkqNW9v5QOGc8PdLoSwbCO6n9i0f/sPD44NVwDQGNyZjO S0vWBPx3GSoqGkpoSN2GlHqCVK5/tQ2XeP2qoFIszkPYHo53BMPUDTfg1+jj465J goLQxSiPIi9ZOtXHlToAfRQPH2Cw/bGqOOocJlhN99M943uwYOpwkB4G2utZjmui rXjneDW0uVKpawo1RisFV9QD6wHSXzJbUImJ+WSsdyUIGTBVp0goafyYyhRkbbsU j7RsyCow8ONPmVsQG+nax8YnCjDIrNhimEdCSjKc73bvUyC66HYIUZsy9AzLaXtm 5eIxht2nbaRkjxCioId6gH8TTcEAbvy9Nnd0YAWRlTpUgou4Sg1bpr3wGgJH+FlS YvlCl4zJ5JTapt6kxPqmePZ8BfmIW8HFvqzKFfsrH40Dk2/9SM66icDktFNUMLV4 xtGlAri/42KNrxb8DtljrICYHsYFzDp/En49it5Rl+pCoiihOWO2TjOHBEuFZcRb 1zqsA0OX/0Wh0EzkNo9sg6IfE/mtN8dfuHxDlbOSUjOqHaioIe1RIQZWjAhLLkiV DhdTCAnSyfQnkU8TSLauVFEZ0byqr0jWASQutYJTjtKFlRcycM+sChegEVgGEVJO H0hw4IVP0rI= =7zfH -----END PGP SIGNATURE----- --=-=-=--