From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yPO4F52q3WWn4gAA62LTzQ:P1 (envelope-from ) for ; Tue, 27 Feb 2024 10:25:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id yPO4F52q3WWn4gAA62LTzQ (envelope-from ) for ; Tue, 27 Feb 2024 10:25:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=rRP0e4ic; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709025949; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=a8yE+TSEAW7XgLoWTRRcy8Vp02u1QIhIza8IjgcEVQo=; b=El7JQBlCkbQKY3cQQ2jpQRyEhdLh6Kdm7fGWMCtrBdXxYfAqV6Ji4+XPgaX3fugls+q4I6 Pz/8CHLzzKDezrnyo+L9acTV4DBFWF988r3xW7Bg16/XcI48GZE9oECExOnsODxoYjaI74 b/LWLKjWPpkHst7QKdeB2SPdTvkgFCrBR39SgWVvJL/C05nIQmt6N6X1sNm7ySWmYwnZVQ QxJ6AjvYcUBhBNvsokAoU6ElyQtbrpMAR5AMfga20l/IsWNJRRAolNzApc98MKn0M7+m8N fLwb6/YfJaMFs4ITErGU9ZxhpwsO1AKNN6aUThrzxnd2ok6cLqHPxkEB2FM+0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=rRP0e4ic; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709025949; a=rsa-sha256; cv=none; b=gCI5llClPT+lDU3cMkGNh7LmsbEcSX4dl2wXInj92vV3a7dWMK4E62TUnD0vkfsMQhR14F g6yqh+k30JhmqgQ0PGRM0I00G9Y5AXwKZROwdtp5qmAI1lkLA3Ghq823rQn4L4tOTLELrM 2o5GDaz9MZcIFuOR20Q0D9ZfCxNskNndtnd+LR5sJV+8GjeNIgwaUKpBSXQN9PGOTpA6S9 lbD+Awz/cGQAjatcBcaI8sBZ7YZPMNh6t9Vn0dCqH6auIswxKjPjbZZFUuNZ8pqh8v3vsc muMibwznKEbfSfHVVfKf9+vf+rtv4xcD2CDUrrUThCYNUxYwgW8koDugXLAjeQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD9698B36 for ; Tue, 27 Feb 2024 10:25:48 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1retiV-0006b1-E4; Tue, 27 Feb 2024 04:25:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1retiT-0006Zx-Vn for guix-patches@gnu.org; Tue, 27 Feb 2024 04:25:38 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1retiT-0004y5-Kg for guix-patches@gnu.org; Tue, 27 Feb 2024 04:25:37 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1retis-0005XY-Da for guix-patches@gnu.org; Tue, 27 Feb 2024 04:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69292] [PATCH 6/6] store: database: Rename a couple of procedures. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Feb 2024 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69292 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 69292@debbugs.gnu.org, Christopher Baines Received: via spool by 69292-submit@debbugs.gnu.org id=B69292.170902590721125 (code B ref 69292); Tue, 27 Feb 2024 09:26:02 +0000 Received: (at 69292) by debbugs.gnu.org; 27 Feb 2024 09:25:07 +0000 Received: from localhost ([127.0.0.1]:37405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rethz-0005Uf-2Y for submit@debbugs.gnu.org; Tue, 27 Feb 2024 04:25:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rethw-0005Ty-F4 for 69292@debbugs.gnu.org; Tue, 27 Feb 2024 04:25:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rethP-0004ZF-3V; Tue, 27 Feb 2024 04:24:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=a8yE+TSEAW7XgLoWTRRcy8Vp02u1QIhIza8IjgcEVQo=; b=rRP0e4icgm1ImjtQobEJ 9p/fhlncqtCZe6Nn83gCNaFVECXPj0W1eq/xBclpYKfbSvn3cG5L5BqWkruc9tRxO7WvtApyDN5dQ vyh7zV9AOSiCSrdQJAWG5WK1ZxmhWRHH/SKgPXZJ1AcIkUOOeIjK/bOlELVKn5xyD+TIAsfP9Uerg 2EEq7XmPXev2zB7UpqENgFDIjFsNZW5/BoBdLeIoxOYfHZ97+m0/ScIIPTLF0jT+B5Q+hsqZjvTCe m9MsTlsjoh81ytn/u1gbuTWF3kn7EbUejm00d3rHl0cB0GgINsQVY+C4sXlOGxfdVqUhSzSF8+/2+ PK9y3GhsWOX25g==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <871q8z8p0n.fsf@cbaines.net> (Christopher Baines's message of "Mon, 26 Feb 2024 11:03:04 +0000") References: <4b6a268daab5e0b307dff2229d551a47c9fe1ebc.1708457946.git.mail@cbaines.net> <12f872394c84039fa553e50381d040de24f24d3e.1708457946.git.mail@cbaines.net> <87zfvrdtcw.fsf@gnu.org> <871q8z8p0n.fsf@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 9 =?UTF-8?Q?Vent=C3=B4se?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Marsault X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 27 Feb 2024 10:24:25 +0100 Message-ID: <871q8yl0om.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -3.68 X-Spam-Score: -3.68 X-Migadu-Queue-Id: CD9698B36 X-TUID: /HAoYjkQdzZJ Christopher Baines skribis: > Ludovic Court=C3=A8s writes: > >> Christopher Baines skribis: >> >>> These names should be more descriptive. >>> >>> * guix/store/database.scm (path-id): Rename to select-valid-path-id. >>> (sqlite-register): Rename to register-valid-path. >>> (register-items): Update accordingly. >>> >>> Change-Id: I6d4a14d4cde9d71ab34d6ffdbfbfde51b2c0e1db >> >> OK for =E2=80=98register-valid-path=E2=80=99. >> >> For =E2=80=98path-id=E2=80=99 my preference would be =E2=80=98valid-path= -id=E2=80=99 or keeping >> =E2=80=98path-id=E2=80=99; =E2=80=98select=E2=80=99 looks odd as nothing= =E2=80=99s being =E2=80=9Cselected=E2=80=9D here in the >> non-SQL sense of the word. > > The main thing I'm trying to do here is make the procedures that > directly interact with the database stand out (similar to the ! suffix > convention). Maybe the procedure taking the db as an argument is enough, > but to me path-id/valid-path-id look too much like record accessors. I=E2=80=99d say that having an explicit =E2=80=98db=E2=80=99 argument is en= ough (similar to procedures that take a =E2=80=98store=E2=80=99 argument). Ludo=E2=80=99.