From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id kwhiEg28E2bvgwAAe85BDQ:P1 (envelope-from ) for ; Mon, 08 Apr 2024 11:42:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id kwhiEg28E2bvgwAAe85BDQ (envelope-from ) for ; Mon, 08 Apr 2024 11:42:37 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=mQ4bosQu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712569357; a=rsa-sha256; cv=none; b=XGWN7NPsGxQ7SGHBACpYk4H5vkpct7uEiRNzLmbqgx/orNsG2KnJM/jIdikXDzbDEXVl0m qeSvueZILFDmD0IEScWx8J1jadfEkJM+kQRR+0PgxGZEO+q5SwyaoPSj/jAHJfTDP5D8D7 5abwnCczg00sQQcK3GFkhwjGSsWcn5ZJz7Rw+BY+fNYXQNEymmoqHKC0OfPEiElg606ElT h7KYcRSfiHJskwoUnR4jtqWsjhBzgh3d7L96eHdovlUBIb6PUqUmmecSpq0GmJa8C6gC0A 1z2dtcyQnTQFkV+IzAS7tYTuWUXiu7gMuQH/VfMhh+t8kW6WYHZ3DWj2nrwfbA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=mQ4bosQu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712569357; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Zp+/VEXQqjBsw/TiwbvwjnRfGoPEvSPo7PAI6h4Urlo=; b=fx4XvLVFMIRSmUE30c17bRVYt4x/10MoU5FaiIkZ5/6fAKyWqIUfQYHlCfurwyAV/fCWgu rc0g58wJHtjBoJygnwECzyvHVSIME//o8XJtzk1QkSQqMUOf9EcjX8xjlZERZNEXKrThlN 546TciElO6j+dolbGJt8SjgVKUblaB96NTnlJ5n/eDKQHFef3m/Z05cfX6bT1rg4QiYGPU DOBpy7X/HYLICyraVEt/8epLK8U4TMHdTI3fAH6x3dk+BCVlkGDYkAahUeLjHbd1YTgH+d dnJgEnCP7DoFRuD+BDtoydzfIC9/evPkUhdgNEzOh8IA2DD1MInGjFwnI82+Fg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 01B2E732B7 for ; Mon, 8 Apr 2024 11:42:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtlW1-0001Ty-4B; Mon, 08 Apr 2024 05:42:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtlVk-0001Sv-Kf for guix-patches@gnu.org; Mon, 08 Apr 2024 05:42:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtlVk-0004fO-BH for guix-patches@gnu.org; Mon, 08 Apr 2024 05:41:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtlVr-0003Ke-Ke for guix-patches@gnu.org; Mon, 08 Apr 2024 05:42:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70169] [PATCH v2 09/12] maint: Remove %%CreationDate from generated EPS files Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Apr 2024 09:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70169 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: 70169@debbugs.gnu.org Received: via spool by 70169-submit@debbugs.gnu.org id=B70169.171256928912654 (code B ref 70169); Mon, 08 Apr 2024 09:42:03 +0000 Received: (at 70169) by debbugs.gnu.org; 8 Apr 2024 09:41:29 +0000 Received: from localhost ([127.0.0.1]:45302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtlVI-0003I1-Hu for submit@debbugs.gnu.org; Mon, 08 Apr 2024 05:41:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtlVG-0003He-Gs for 70169@debbugs.gnu.org; Mon, 08 Apr 2024 05:41:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtlV3-0004c5-Sp; Mon, 08 Apr 2024 05:41:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Zp+/VEXQqjBsw/TiwbvwjnRfGoPEvSPo7PAI6h4Urlo=; b=mQ4bosQuNflK79Qcm/Dr A3U7jVGgJlPecvjIHr5M9oQcOIJqJ0kzXy/8jgRrAf+p6XA1agGlDwdKb2WYP1wyIMgjwJ+vIONUY tCGiJ06qVEuyZ4m8tiYCBqFaj9pZ5+a5DhMxTbvqKvZTgLvwbPLsUS9mRTEAPOcGY0IK1DPYwCJIR yLbOs0RY5sQIqHFS8AmeEeIrBSK4NSwnya1sVNSSDvcmwnPT6y8aXBVIBmMLlrQl+o2FhMiSPQq1A g1aSpmY7wQQj2w5rLSqZcl3A5LlF6RWYotNnelzG3il0794YGaJ86U/aSgjsp32TyKlryUxUgOcEB jjuyV6W15dy9+g==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <109c05ead54c3e48a8df27794c8df56149343a37.1712437365.git.janneke@gnu.org> (Janneke Nieuwenhuizen's message of "Sat, 6 Apr 2024 23:18:01 +0200") References: <109c05ead54c3e48a8df27794c8df56149343a37.1712437365.git.janneke@gnu.org> Date: Mon, 08 Apr 2024 11:41:11 +0200 Message-ID: <871q7gry2w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -7.07 X-Migadu-Queue-Id: 01B2E732B7 X-Migadu-Spam-Score: -7.07 X-Migadu-Scanner: mx10.migadu.com X-TUID: hkCfx57c77/q Janneke Nieuwenhuizen skribis: > * doc/local.mk (.dot.eps, png.eps): Remove %%CreationDate. Split single = shell > command into separate recipe lines, prefixed by $(AM_V_at). > > Change-Id: I5a03485c19c72f0c46411815c51290e52a8e5399 > --- > doc/local.mk | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/doc/local.mk b/doc/local.mk > index c355bec8d7..60e36091ce 100644 > --- a/doc/local.mk > +++ b/doc/local.mk > @@ -152,12 +152,16 @@ DOT_OPTIONS =3D \ > mv "$(srcdir)/$@.tmp" "$(srcdir)/$@" >=20=20 > .dot.eps: > - $(AM_V_DOT)$(DOT) -Teps $(DOT_OPTIONS) < "$<" > "$(srcdir)/$@.tmp"; \ > - mv "$(srcdir)/$@.tmp" "$(srcdir)/$@" > + $(AM_V_DOT)$(DOT) -Teps $(DOT_OPTIONS) < "$<" > "$(srcdir)/$@.tmp" > + $(AM_V_at)grep -v ^%%CreationDate: "$(srcdir)/$@.tmp" > "$(srcdir)/$@.t= mp2" > + $(AM_V_at)rm -f "$(srcdir)/$@.tmp" > + $(AM_V_at)mv "$(srcdir)/$@.tmp2" "$@" Apparently =E2=80=98dot=E2=80=99 (GraphViz) does not emit a =E2=80=98Creati= onDate=E2=80=99 header. Should we drop this change and add a line like this above the =E2=80=98mv= =E2=80=99 line: @if grep -q CreationDate "$@.tmp"; then false; else true; fi to be on the safe side? > .png.eps: > - $(AM_V_GEN)convert "$<" "$@-tmp.eps"; \ > - mv "$@-tmp.eps" "$@" > + $(AM_V_GEN)convert "$<" "$@-tmp.eps" > + $(AM_V_at)grep -v ^%%CreationDate: "$@-tmp.eps" > "$@-tmp2.eps" > + $(AM_V_at)rm -f "$@-tmp.eps" > + $(AM_V_at)mv "$@-tmp2.eps" "$@" Looking into the code of ImageMagick, I see: --8<---------------cut here---------------start------------->8--- timer=3DGetMagickTime(); (void) FormatMagickTime(timer,MaxTextExtent,date); (void) FormatLocaleString(buffer,MaxTextExtent, "%%%%CreationDate: %s\n",date); --8<---------------cut here---------------end--------------->8--- where =E2=80=98GetMagickTime=E2=80=99 honors =E2=80=98SOURCE_DATE_EPOCH=E2= =80=99. Should we set =E2=80=98SOURCE_DATE_EPOCH=E2=80=99 and avoid the =E2=80=98grep=E2=80=99 tr= ick? OTOH, an argument to keep this patch as-is is that it=E2=80=99ll resist to changes in ImageMagick/GraphViz. So maybe the comments above aren=E2=80=99t that relevant. Ludo=E2=80=99.