unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: rg@raghavgururajan.name, vivien@planete-kraus.eu, 71306@debbugs.gnu.org
Subject: [bug#71306] [PATCH gnome-team] gnu: gtk: Fix build on i686-linux.
Date: Sat, 01 Jun 2024 11:04:07 -0400	[thread overview]
Message-ID: <871q5gln6g.fsf@gmail.com> (raw)
In-Reply-To: <6aa777e0ad96e8cb208b86c1e8450784b0e102e3.1717058246.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Thu, 30 May 2024 10:25:01 +0200")

Hi Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/gtk.scm (gtk)[#:phases]<patch>: Add section dedicated to
> failures on i686-linux.
> ---
>  gnu/packages/gtk.scm | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index d5777ae67b..1c78a969f6 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -1235,7 +1235,20 @@ (define-public gtk
>                  ;; The inscription-markup.ui fails due to /etc/machine-id
>                  ;; related warnings (see:
>                  ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/5169).
> -                (("[ \t]*'inscription-markup.ui',") ""))))
> +                (("[ \t]*'inscription-markup.ui',") ""))
> +              ;; XXX: These failures appear specific to i686 – investigate them.
> +              #$@(if (target-x86-32?)
> +                     #~((substitute* "testsuite/gsk/meson.build"
> +                          (("'empty-(fill|stroke)\\.node',") "")
> +                          (("'fill2?\\.node',") "")
> +                          (("'stroke\\.node',") "")
> +                          (("'fill-fractional-([a-z-]*)-nogl',") "")
> +                          (("\\[ 'path-special-cases' \\],") "")
> +                          (("\\[ '(path|curve)-special-cases' \\],") "")
> +                          (("\\[ 'path-private' \\],") ""))
> +                        (substitute* "testsuite/a11y/meson.build"
> +                           (("\\{ 'name': 'text(view)?' \\},") "")))
> +                    #~())))

Are you sure these are specific to i686 and not to 32 bit architectures
such as armhf also?

-- 
Thanks,
Maxim




  reply	other threads:[~2024-06-01 15:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30  8:25 [bug#71306] [PATCH gnome-team] gnu: gtk: Fix build on i686-linux Liliana Marie Prikler
2024-06-01 15:04 ` Maxim Cournoyer [this message]
2024-06-01 16:20   ` Liliana Marie Prikler
2024-06-03 12:10     ` Maxim Cournoyer
2024-07-06 10:59 ` bug#71306: Close Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q5gln6g.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=71306@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=rg@raghavgururajan.name \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).