From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id mOCQFLyLcWZXbQEA62LTzQ:P1 (envelope-from ) for ; Tue, 18 Jun 2024 13:29:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id mOCQFLyLcWZXbQEA62LTzQ (envelope-from ) for ; Tue, 18 Jun 2024 15:29:32 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=0wjjUeYz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718717228; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qyGrXthtj7TCSAZ4rVzYATMPnVnAyrRMOg1M7iFaGFU=; b=dFjxMRayrtwlWD/aobar8auwRJM3lV69ZM6Uc5vRALwilyHqN2CTaazMhn3wbybxSojbGN pVMjjYsC20w3N9TDuBlAxcoi+fwQxQhZj26Muo4lcNpKUvUeeq6rIaqYqajA6B4Vt7teo5 bC0hloadKvxRU9T0oELGanIC/j44qRLe8U8dYGCinwulXICU+LKofUJBxkdfUOG+YvTO4Z FrqiaUlAmw05wVlIFoTj+VBeiBhJZqNqcbdO8i1rJS+sCHFsYkgbGl1GI8b4AoeorclcEW 9C5BvPtu+fBrbZMzg91KfuJZavkgBeNqX6Dz14tAbvj+A0jtjEjM1B3vsO6NNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718717228; a=rsa-sha256; cv=none; b=OkQLI8NF+kAkyv+CROnT7MrXRUPmrHrvCuSMPZU7NcWERSvQWxVThACNoQLcjr8Qcc+6Y5 zrYhvxB16EJ/FeoXd5vdZsOH0B2qurFMT+bAyYufMfUZ0ql92mEi0MUtWRuG6KtS8Pyv7Z GQNbr951yJYvYw8a34N6hdzhnsXamJKtUoiMyXQQOdJe+3g/xGRJb2kuhQ0ae9PN0DWqk6 0LbLuARlJR9Kdp6aT7SN/eP6Vxlf7NzNZ+0R3Y1tktB7OsU6Dbb1WwVJuru5BwMRwdOauD lbWpTBMmHCP+A3TLES7qnqlOw91yOXocIYq6wdELwVZXAYi5/pFcl1E64uyA0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=0wjjUeYz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E94CF62C4D for ; Tue, 18 Jun 2024 15:27:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJYrU-00006M-Pf; Tue, 18 Jun 2024 09:27:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJYrT-00005s-Hr for guix-patches@gnu.org; Tue, 18 Jun 2024 09:26:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJYrT-0004KW-Ap for guix-patches@gnu.org; Tue, 18 Jun 2024 09:26:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJYrV-00037T-Oo for guix-patches@gnu.org; Tue, 18 Jun 2024 09:27:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71371] [PATCH v2] gnu: svn-fetch: Allow specifying revisions as strings. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jun 2024 13:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71371 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 71371@debbugs.gnu.org, Josselin Poiret , Simon Tournier , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Florian Pelz , Christopher Baines , Matthew Trzcinski Received: via spool by 71371-submit@debbugs.gnu.org id=B71371.171871720811971 (code B ref 71371); Tue, 18 Jun 2024 13:27:01 +0000 Received: (at 71371) by debbugs.gnu.org; 18 Jun 2024 13:26:48 +0000 Received: from localhost ([127.0.0.1]:42238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJYrH-000371-KZ for submit@debbugs.gnu.org; Tue, 18 Jun 2024 09:26:48 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:42586 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJYrF-00036n-6z for 71371@debbugs.gnu.org; Tue, 18 Jun 2024 09:26:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1718717195; bh=jZPR+6G5ylJeT96MLkjWMNKZ0uq/9LDbkoG7XiXKaQg=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=0wjjUeYztaIRMmIShOu3kQC30CFNSrgoKYVERz8xbtELpOrvhR//vTLezMp53GuWx el/3OHa6pqwRJGq1jYxCI1RO+jhn6UdFM+92/sbQ1SgossWo0Vh2tDOe5ybGaA5IEB bnCHRMt2V2LwvJ35MQgSfNB1DUjQNb4CsNl4fbLk= Received: by b221-6.in.mailobj.net [192.168.90.26] with ESMTP via ip-20.mailobj.net [213.182.54.20] Tue, 18 Jun 2024 15:26:34 +0200 (CEST) X-EA-Auth: CRIYXhht8HKj5q0xmyETd9bm7C/xAwdE/dYm4OQ/JJNd9Q2dT2bO/ifk53SloBI8t0Txe+dlR2stCcNNBcMNV/CdlJsULz1INc23fCC5zus= In-Reply-To: <87tthqe9id.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 18 Jun 2024 08:11:06 -0400") References: <4885bc5c95529991846db147ca58f7445d3cd864.1718699410.git.mail@nicolasgoaziou.fr> <87tthqe9id.fsf@gmail.com> Date: Tue, 18 Jun 2024 15:26:18 +0200 Message-ID: <871q4uwfet.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.36 X-Spam-Score: -2.36 X-Migadu-Queue-Id: E94CF62C4D X-Migadu-Scanner: mx11.migadu.com X-TUID: fCzpUU8F2ZeP Hello, Maxim Cournoyer writes: > Nicolas Goaziou writes: > >> * guix/svn-download.scm (): >> (svn-fetch): >> (svn-multi-fetch): >> * guix/build/svn.scm (svn-fetch): Revision can also be a string, not only >> a number. >> * doc/guix.texi (origin Reference): Document changes about REVISION field. >> >> Change-Id: Ibb17b539575fdf3daf895bd1ce39a40dd9b495cb >> --- >> v2: No longer ignore "-r" argument. Instead, allow strings, such as "HEAD". Yes, in practice, it means this relies on the tag being stable, which is the same assumption as for, e.g., tarballs. WDYT? > > While it may be useful to point to volatile references such as HEAD for > internal projects (like I believe is also possible for our git fetcher) > or the likes (with a hash of #f for example), I wouldn't like to see > this used in the Guix tree (I'd consider it a bad practice). I'm not > against merging this, but I think we should add a 'guix lint' rule > that'd warn that some SVN reference should be specified if it wasn't. > > Does that sound reasonable? To be clear, I intend to use it in Guix tree, _in conjunction with a tag_. The purpose of this patch is to put the reference on the human-readable repository tag, not on the revision number. Sure, as already pointed out, some evil repository could modify contents associated to a tag because Subversion allows it. But that would defeat the whole purpose of tags, so I don't think that's common at all. Tags are not meant to be volatile. Again, as also pointed out, we trust tarballs, but the situation is exactly the same for them: one evil project could modify the contents of the tarball without changing its name. The consequence would then be the same: a hash mismatch. Anyway, this patch is there to make my life less miserable while writing a TeX Live updater. It is of no use (to me) if it is restricted to internal projects. I'm not putting pressure on anyone though, if it isn't accepted, I'll find other, probably more tedious, ways to complete the updater. Regards, -- Nicolas Goaziou