unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#71824] [PATCH] import: go: Fix indentation in help message.
@ 2024-06-28 16:14 Richard Sent
  2024-06-29  1:08 ` jgart via Guix-patches via
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Richard Sent @ 2024-06-28 16:14 UTC (permalink / raw)
  To: 71824
  Cc: Richard Sent, Christopher Baines, Josselin Poiret,
	Katherine Cox-Buday, Ludovic Courtès, Mathieu Othacehe,
	Sharlatan Hellseher, Simon Tournier, Tobias Geerinckx-Rice

* guix/scripts/import/go.scm (show-help) <recursive>: Indent second line.

Change-Id: Iad096231e26ed4e0e1c584f92e43f2695a2d8682
---
 guix/scripts/import/go.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/scripts/import/go.scm b/guix/scripts/import/go.scm
index f1970d3543..b90c6ac72f 100644
--- a/guix/scripts/import/go.scm
+++ b/guix/scripts/import/go.scm
@@ -51,7 +51,7 @@ (define (show-help)
   -h, --help             display this help and exit"))
   (display (G_ "
   -r, --recursive        generate package expressions for all Go modules
-that are not yet in Guix"))
+                         that are not yet in Guix"))
   (display (G_ "
   -p, --goproxy=GOPROXY  specify which goproxy server to use"))
   (display (G_ "

base-commit: 78b881722f08325c76096557313a0faee847c66f
-- 
2.45.1





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#71824] [PATCH] import: go: Fix indentation in help message.
  2024-06-28 16:14 [bug#71824] [PATCH] import: go: Fix indentation in help message Richard Sent
@ 2024-06-29  1:08 ` jgart via Guix-patches via
  2024-07-01 20:53 ` Sharlatan Hellseher
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: jgart via Guix-patches via @ 2024-06-29  1:08 UTC (permalink / raw)
  To: 71824; +Cc: Richard Sent


I'll let someone else comment on this since I'm not sure what our policy
is on indentation at the moment.

all best,

jgart




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#71824] [PATCH] import: go: Fix indentation in help message.
  2024-06-28 16:14 [bug#71824] [PATCH] import: go: Fix indentation in help message Richard Sent
  2024-06-29  1:08 ` jgart via Guix-patches via
@ 2024-07-01 20:53 ` Sharlatan Hellseher
  2024-07-01 20:55 ` Sharlatan Hellseher
  2024-07-01 20:59 ` bug#71824: " Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Sharlatan Hellseher @ 2024-07-01 20:53 UTC (permalink / raw)
  To: 71824

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]


Hi,

The change looks reasonable while comparing other importer' help:

--8<---------------cut here---------------start------------->8---
(guix/linux-gnu)[sharlatan@guxtil ~/code/guix]$: guix import cran --help
Usage: guix import cran PACKAGE-NAME
Import and convert the CRAN package for PACKAGE-NAME.

  -a, --archive=ARCHIVE  specify the archive repository
  -h, --help             display this help and exit
  -r, --recursive        import packages recursively
  -s, --style=STYLE      choose output style, either specification or variable
  -p, --license-prefix=PREFIX
                         add custom prefix to licenses
  -V, --version          display version information and exit

Report bugs to: bug-guix@gnu.org.
GNU Guix home page: <https://guix.gnu.org>
General help using Guix and GNU software: <https://guix.gnu.org/en/help/>
(guix/linux-gnu)[sharlatan@guxtil ~/code/guix]$: guix import pypi --help
Usage: guix import pypi PACKAGE-NAME
Import and convert the PyPI package for PACKAGE-NAME.

  -h, --help             display this help and exit
  -r, --recursive        import packages recursively
  -V, --version          display version information and exit

Report bugs to: bug-guix@gnu.org.
GNU Guix home page: <https://guix.gnu.org>
General help using Guix and GNU software: <https://guix.gnu.org/en/help/>
(guix/linux-gnu)[sharlatan@guxtil ~/code/guix]$: guix import go --help
Usage: guix import go PACKAGE-PATH[@VERSION]
Import and convert the Go module for PACKAGE-PATH.  Optionally, a version
can be specified after the arobas (@) character.

  -h, --help             display this help and exit
  -r, --recursive        generate package expressions for all Go modules
that are not yet in Guix
  -p, --goproxy=GOPROXY  specify which goproxy server to use
  --pin-versions         use the exact versions of a module's dependencies

Report bugs to: bug-guix@gnu.org.
GNU Guix home page: <https://guix.gnu.org>
--8<---------------cut here---------------end--------------->8---

--
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#71824] [PATCH] import: go: Fix indentation in help message.
  2024-06-28 16:14 [bug#71824] [PATCH] import: go: Fix indentation in help message Richard Sent
  2024-06-29  1:08 ` jgart via Guix-patches via
  2024-07-01 20:53 ` Sharlatan Hellseher
@ 2024-07-01 20:55 ` Sharlatan Hellseher
  2024-07-01 20:59 ` bug#71824: " Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Sharlatan Hellseher @ 2024-07-01 20:55 UTC (permalink / raw)
  To: 71824

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]


And after applying patch locally:

--8<---------------cut here---------------start------------->8---
> ./pre-inst-env guix import go --help
Usage: guix import go PACKAGE-PATH[@VERSION]
Import and convert the Go module for PACKAGE-PATH.  Optionally, a version
can be specified after the arobas (@) character.

  -h, --help             display this help and exit
  -r, --recursive        generate package expressions for all Go modules
                         that are not yet in Guix
  -p, --goproxy=GOPROXY  specify which goproxy server to use
  --pin-versions         use the exact versions of a module's dependencies

Report bugs to: bug-guix@gnu.org.
GNU Guix home page: <https://www.gnu.org/software/guix/>
General help using Guix and GNU software: <https://guix.gnu.org/en/help/>
--8<---------------cut here---------------end--------------->8---

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#71824: [PATCH] import: go: Fix indentation in help message.
  2024-06-28 16:14 [bug#71824] [PATCH] import: go: Fix indentation in help message Richard Sent
                   ` (2 preceding siblings ...)
  2024-07-01 20:55 ` Sharlatan Hellseher
@ 2024-07-01 20:59 ` Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Sharlatan Hellseher @ 2024-07-01 20:59 UTC (permalink / raw)
  To: 71824-done

[-- Attachment #1: Type: text/plain, Size: 72 bytes --]


Pushed as 69089674bb9fb2cc7b3285b73fb7dda7d99a2550 to master.

--
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-07-01 21:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-28 16:14 [bug#71824] [PATCH] import: go: Fix indentation in help message Richard Sent
2024-06-29  1:08 ` jgart via Guix-patches via
2024-07-01 20:53 ` Sharlatan Hellseher
2024-07-01 20:55 ` Sharlatan Hellseher
2024-07-01 20:59 ` bug#71824: " Sharlatan Hellseher

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).