* [bug#73438] [PATCH] Better error message in checkStoreName
@ 2024-09-23 11:21 Brennan Vincent
0 siblings, 0 replies; only message in thread
From: Brennan Vincent @ 2024-09-23 11:21 UTC (permalink / raw)
To: 73438
When trying to pass a local-file beginning with a dot to something like
home-files-service-type, one gets an error message like:
guix home: error: invalid name: `.vimrc'
which does not explain what went wrong. This update should make it more clear.
Change-Id: I045a663bc6cd9844677c65b38a31d3941cf212b5
---
nix/libstore/store-api.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nix/libstore/store-api.cc b/nix/libstore/store-api.cc
index 781fb9e693..38a1403a71 100644
--- a/nix/libstore/store-api.cc
+++ b/nix/libstore/store-api.cc
@@ -61,7 +61,7 @@ void checkStoreName(const string & name)
/* Disallow names starting with a dot for possible security
reasons (e.g., "." and ".."). */
if (string(name, 0, 1) == ".")
- throw Error(format("invalid name: `%1%'") % name);
+ throw Error(format("invalid name: `%1%' (can't begin with dot)") % name);
foreach (string::const_iterator, i, name)
if (!((*i >= 'A' && *i <= 'Z') ||
(*i >= 'a' && *i <= 'z') ||
base-commit: 6ea75bb9bcc52521f0bb3f121799745fdc17f1c9
--
2.46.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-09-23 11:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-23 11:21 [bug#73438] [PATCH] Better error message in checkStoreName Brennan Vincent
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).