unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 75026@debbugs.gnu.org
Subject: [bug#75026] [PATCH core-updates 1/7] gnu: gnutls: Update to 3.8.8.
Date: Tue, 24 Dec 2024 15:50:02 +0100	[thread overview]
Message-ID: <871pxx5e5h.fsf@gnu.org> (raw)
In-Reply-To: <15d3101d6383ecf47a655610199699fb910674ab.1734882716.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Mon, 23 Dec 2024 01:00:59 +0900")

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> * gnu/packages/tls.scm (gnutls): Update to 3.8.8.
> [source]: Delete patches.
> [arguments]: Mark failing tests via XFAIL_TESTS make flag.
> * gnu/packages/patches/gnutls-skip-trust-store-test.patch: Delete file.
> * gnu/local.mk (dist_patch_DATA): De-register it.
>
> Change-Id: I6519b789896dba00de6a1af7a6f772906ce660c1

[...]

> --- a/gnu/packages/patches/gnutls-skip-trust-store-test.patch
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -Version 3.5.11 added a test to check that the default trust store is readable.
> -It does not exist in the build environment, so pretend everything is fine.
> -
> -diff a/tests/trust-store.c b/tests/trust-store.c
> ---- a/tests/trust-store.c
> -+++ b/tests/trust-store.c
> -@@ -61,7 +61,7 @@
> - 	} else if (ret < 0) {
> - 		fail("error loading system trust store: %s\n", gnutls_strerror(ret));
> - 	} else if (ret == 0) {
> --		fail("no certificates were found in system trust store!\n");
> -+		success("no trust store in the Guix build environment!\n");


[...]

> +           #~(list (string-append
> +                    "XFAIL_TESTS="
> +                    ;; This test checks that the default trust store is
> +                    ;; readable; expect it to fail since the trust store
> +                    ;; doesn't exist in the build environment.
> +                    "trust-store "

This suggests that the patch above was still useful, after all?  (The
patch still applies apparently:
<https://ci.guix.gnu.org/build/6753571/log>.)

Also, lack of the patch might trigger failures in the test suites of
dependents.  What does ‘guix build -P1 gnutls’ say?

> +                    ;; This one fails only inside the build environment, for
> +                    ;; reasons unknown (see:
> +                    ;; <https://gitlab.com/gnutls/gnutls/-/issues/1634>).
> +                    "tls13/compress-cert-neg2 "))

This is weird, would be interesting to investigate, maybe stracing the
test to see why it would fail in the build environment and not outside
of it?

Ludo’.




  reply	other threads:[~2024-12-24 15:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-22 15:52 [bug#75026] [PATCH core-updates 0/7] Update gnutls and curl Maxim Cournoyer
2024-12-22 16:00 ` [bug#75026] [PATCH core-updates 1/7] gnu: gnutls: Update to 3.8.8 Maxim Cournoyer
2024-12-24 14:50   ` Ludovic Courtès [this message]
2024-12-22 16:01 ` [bug#75026] [PATCH core-updates 2/7] gnu: gnutls: Enable zstd compression Maxim Cournoyer
2024-12-22 16:01 ` [bug#75026] [PATCH core-updates 3/7] gnu: gnutls: Streamline mips64el conditionals Maxim Cournoyer
2024-12-22 16:01 ` [bug#75026] [PATCH core-updates 4/7] gnu: brotli: Update to 1.1.0 Maxim Cournoyer
2024-12-22 16:01 ` [bug#75026] [PATCH core-updates 5/7] gnu: libidn: Update to 1.42 Maxim Cournoyer
2024-12-22 16:01 ` [bug#75026] [PATCH core-updates 6/7] gnu: curl: Update to 8.11.1 and ungraft Maxim Cournoyer
2024-12-22 16:01 ` [bug#75026] [PATCH core-updates 7/7] gnu: curl: Enable zstd support Maxim Cournoyer
2024-12-23 19:45 ` [bug#75026] [PATCH core-updates 0/7] Update gnutls and curl Ludovic Courtès
2024-12-24  2:15   ` Maxim Cournoyer
2024-12-24 14:52     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pxx5e5h.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=75026@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).