unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 42019@debbugs.gnu.org
Subject: [bug#42019] [PATCH 1/1] website: Add integrity to JSON sources.
Date: Sat, 27 Jun 2020 19:41:59 +0200	[thread overview]
Message-ID: <86y2o8be3c.fsf@gmail.com> (raw)
In-Reply-To: <87zh8ol9qp.fsf@gnu.org>

Hi Ludo,

Thank you for the review.

On Sat, 27 Jun 2020 at 19:05, Ludovic Courtès <ludo@gnu.org> wrote:

>> -             `(("url" . ,(list->vector
>> +             `(("urls" . ,(list->vector
>>                            (resolve
>>                             (match uri
>>                               ((? string? url) (list url))
>
> Is this change OK for Repology?  Or should we keep “url” in addition to
> “urls”?

From what I understood of their API [1] when I checked it, I may say yes. :-)
Well, I do not think that repology parses the field 'sources'.

1: https://repology.org/addrepo


> There’s no guarantee that ‘%guix-version’ is a commit ID, so perhaps we
> should do something like:

Thanks for the tip, I did not know.  I will sent a v2 with your
suggestion or feel free to update the patch and push it. :-)


Cheers,
simon




  reply	other threads:[~2020-06-27 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 15:13 [bug#42019] [PATCH 0/1] sources.json compliant with SWH loader zimoun
2020-06-23 15:21 ` [bug#42019] [PATCH 1/1] website: Add integrity to JSON sources zimoun
2020-06-27 17:05   ` Ludovic Courtès
2020-06-27 17:41     ` zimoun [this message]
2020-06-29 17:01       ` zimoun
2020-06-29 20:41         ` Ludovic Courtès
2020-06-29 23:28           ` zimoun
2020-07-01 19:35             ` Christopher Baines
2020-07-01 20:29               ` zimoun
2020-06-29 16:50 ` [bug#42019] [PATCH v2] " zimoun
2020-07-06 10:20   ` bug#42019: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y2o8be3c.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=42019@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).