From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +CgeAh8R4l9OKQAA0tVLHw (envelope-from ) for ; Tue, 22 Dec 2020 15:30:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id hnCEOR4R4l/8ZQAAB5/wlQ (envelope-from ) for ; Tue, 22 Dec 2020 15:30:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9B54C9406A1 for ; Tue, 22 Dec 2020 15:30:38 +0000 (UTC) Received: from localhost ([::1]:34914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krjcT-0003Ba-Ht for larch@yhetil.org; Tue, 22 Dec 2020 10:30:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krjbw-00035f-9e for guix-patches@gnu.org; Tue, 22 Dec 2020 10:30:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krjbw-0003Rv-1f for guix-patches@gnu.org; Tue, 22 Dec 2020 10:30:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krjbv-0001nV-Tu for guix-patches@gnu.org; Tue, 22 Dec 2020 10:30:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45327] [PATCH] git: Periodically delete least-recently-used cached checkouts. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Dec 2020 15:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45327 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45327-submit@debbugs.gnu.org id=B45327.16086509736792 (code B ref 45327); Tue, 22 Dec 2020 15:30:03 +0000 Received: (at 45327) by debbugs.gnu.org; 22 Dec 2020 15:29:33 +0000 Received: from localhost ([127.0.0.1]:50725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krjbQ-0001lT-Jl for submit@debbugs.gnu.org; Tue, 22 Dec 2020 10:29:33 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:43179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krjbO-0001kx-5e for 45327@debbugs.gnu.org; Tue, 22 Dec 2020 10:29:31 -0500 Received: by mail-wr1-f51.google.com with SMTP id y17so14889908wrr.10 for <45327@debbugs.gnu.org>; Tue, 22 Dec 2020 07:29:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=l+P+0NzSXPGUudbAS7i5n1FFvQlBSzzscTF4m4gmFEA=; b=WwAMZvPfGQVDUaBalGUMpcP0s05l7Qvc1YS7uBY0BUI04Ww/w7i04IU4+zi87utDP/ tgQay7ZW9KUWwdxwdZX8yQm6Ak6x4DdGwJUeutLaXeJ/8nhQ/lczUvLhFmvB3JosMAc8 cvH/icbsVRSkGnTKjvhFMl/r1XhCBfSPGkfp4uXCWvs/CHXML136A6d1VaLUmLKZD9Sb SMqJ23yuLxNU/3biNVTrYOUMTcNGhYFiI5dn+TqXPNOTW4iVZy1ogiXSDfMwEzjEjoVT b5BODp+tcNfvnTYH5aIbUnUvQq69xAyRHdEtTzzfoVrZ/8BSUjxdWTYmnTvgPGxBvLs1 OMug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=l+P+0NzSXPGUudbAS7i5n1FFvQlBSzzscTF4m4gmFEA=; b=owVLhrTxKJ//mcmXD4sRYLUMVPsZNHmOmeVMUi68MSh6xDv/ltZ4Fmyac2BA3rrQWn snzJV2u3AWG6Lgbk6iWokq/PbcIncx6gDlSnQhZ4uta5EUzu3es3fQ6glHscM4mddcFq 7HFF0IdbaLpN052p3455/S2/Kyak9jpbZ1LTKYIihMZEQbEcsBjp8GFhWYpDHdHH28go t41S5oypycCIXCsJMgfq0dKbprRn19gXqIWoKGk1CKD4Ch9RaeZdFUhm+mIEFinzdUXV udEuncRaP+uF4nxbFbnTQGWXFZM705cIeJqZ578UaqvLQCMFpXW5FkUyscK0USqbMcIS e9SQ== X-Gm-Message-State: AOAM531dWme+SkjaQh/q1irEFY2JD9lIRWUzhytP7E0R8Wu8dEOquhg7 XRPg9de1+TI3CicWaxDW7eeb1NVFEUw= X-Google-Smtp-Source: ABdhPJxR+eGuTus2k+eIGMoW9YrnJi43Ng/CMU0BoPoaufG2yjG8WKcBkKtstAMTmQ4hT2xVlj3EwA== X-Received: by 2002:a5d:4491:: with SMTP id j17mr24302759wrq.78.1608650963840; Tue, 22 Dec 2020 07:29:23 -0800 (PST) Received: from lili (oul69-1-82-232-2-3.fbx.proxad.net. [82.232.2.3]) by smtp.gmail.com with ESMTPSA id h14sm31720828wrx.37.2020.12.22.07.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Dec 2020 07:29:23 -0800 (PST) From: zimoun In-Reply-To: <87blem2ceq.fsf@gnu.org> References: <20201219220630.24605-1-ludo@gnu.org> <86a6u7bgle.fsf@gmail.com> <87blem2ceq.fsf@gnu.org> Date: Tue, 22 Dec 2020 16:19:29 +0100 Message-ID: <86wnx97try.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45327@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=WwAMZvPf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9B54C9406A1 X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: NIqBkQ+60+vt Hi, On Tue, 22 Dec 2020 at 14:33, Ludovic Court=C3=A8s wrote: > The difference you=E2=80=99d see is if you pull from a few channels, but = less > than once per month. In that case, the =E2=80=98guix=E2=80=99 channel wo= uld remain in > cache (because cache cleanup happens after the cached checkout has been > updated), but the other channels would be deleted just to be cloned > again soon after that. > > Does that make sense? All make sense. Thanks for explaining. As said, my preference of such thing is =E2=80=9Cguix gc=E2=80=9D and not = =E2=80=9Cguix pull=E2=80=9D. But since =E2=80=9Cguix pull --delete-generations=E2=80=9D is already here= =E2=80=A6 it pulls by deleting. :-) Anyway, it is =E2=80=9Cguix pull=E2=80=9D. However, I still do not like the =E2=80=9Cautomatic=E2=80=9D part. Persona= lly, I would prefer something like: guix pull --delete-generations=3D2m deleting the cache older than 2 months, in addition to the old profiles. Because, with your patch, if I want to change the expiration or the period, it is not convenient: via channels.scm, maybe. Sometime, I am one or two months off (vacation). And I am sure to forget to tweak the channels.scm when I am back. Well, I have 3-4 channels.scm files; for example I am not pulling guix-past each time I pull. Therefore, I should have these 3-4 channels.scm duplicated with the expiration+period tweaked for when I am back from long breaks. Well, if the automatic is the default, a way to turn off could be nice, at the CLI level or even globally. IMHO. Cheers, simon