unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: pukkamustard <pukkamustard@posteo.net>
To: raingloom <raingloom@riseup.net>
Cc: 51565@debbugs.gnu.org
Subject: [bug#51565] PATCH: Update Yggdrasil to new protocol (important breaking changes)
Date: Mon, 15 Nov 2021 14:10:46 +0000	[thread overview]
Message-ID: <86wnl9lcj3.fsf@posteo.net> (raw)
In-Reply-To: <20211102065917.082a2e55@riseup.net>


Thanks for this!

Some minor changes may be needed to make the linter happy:

raingloom <raingloom@riseup.net> writes:

[..]

> [3. text/x-patch; 0002-gnu-Add-go-github-com-rivo-uniseg.patch]...

Linter complains that a line is too long:

gnu/packages/golang.scm:8885:0: go-github-com-rivo-uniseg@0.2.0: line 8885 is way too long (93 characters)

>
> [4. text/x-patch; 0003-gnu-Add-go-github-com-mattn-go-runewidth.patch]...

Linter complains about the synopsis. Maybe: "Go functions for getting
fixed width of characters or strings"?

Does seem like a bit of a duplication of the description...

> [5. text/x-patch; 0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch]...
>
> [6. text/x-patch; 0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch]...
>
> [7. text/x-patch; 0006-gnu-Add-go-github-com-arceliar-ironwood.patch]...

Lines in descriptions are too long and should be wrapped.

A synopsis is required. Maybe: "Ironwood is a Go network routing library
using cryptographic keys as addresses"?




  reply	other threads:[~2021-11-15 14:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02  6:59 [bug#51565] PATCH: Update Yggdrasil to new protocol (important breaking changes) raingloom
2021-11-15 14:10 ` pukkamustard [this message]
2021-11-22 21:13   ` raingloom
2021-11-28 20:47     ` raingloom
2021-12-01 15:27     ` Ludovic Courtès
2021-12-01 16:03       ` raingloom
2021-12-02  9:15         ` Ludovic Courtès
2021-12-01 16:04 ` bug#51565: " Ricardo Wurmus
2021-12-02  9:16   ` [bug#51565] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wnl9lcj3.fsf@posteo.net \
    --to=pukkamustard@posteo.net \
    --cc=51565@debbugs.gnu.org \
    --cc=raingloom@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).