From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MIPHFsxdf2NEXAEAbAwnHQ (envelope-from ) for ; Thu, 24 Nov 2022 13:04:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AAbyFsxdf2OUAgAA9RJhRA (envelope-from ) for ; Thu, 24 Nov 2022 13:04:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DD7B112ADB for ; Thu, 24 Nov 2022 13:04:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyAxj-0005k6-KA; Thu, 24 Nov 2022 07:04:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAxE-0005hI-VA for guix-patches@gnu.org; Thu, 24 Nov 2022 07:04:00 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyAwY-0004yQ-2P for guix-patches@gnu.org; Thu, 24 Nov 2022 07:03:12 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyAwX-0000ZP-UR for guix-patches@gnu.org; Thu, 24 Nov 2022 07:03:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Nov 2022 12:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Christopher Baines Cc: 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.16692913772175 (code B ref 59513); Thu, 24 Nov 2022 12:03:01 +0000 Received: (at 59513) by debbugs.gnu.org; 24 Nov 2022 12:02:57 +0000 Received: from localhost ([127.0.0.1]:57600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyAwS-0000Yz-Uf for submit@debbugs.gnu.org; Thu, 24 Nov 2022 07:02:57 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:45905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyAwM-0000YR-JM for 59513@debbugs.gnu.org; Thu, 24 Nov 2022 07:02:51 -0500 Received: by mail-wr1-f50.google.com with SMTP id d1so2131168wrs.12 for <59513@debbugs.gnu.org>; Thu, 24 Nov 2022 04:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=U+Gd2/HinAr+Bg1OVpfcbph4giVvyfimyodWFFBNZMk=; b=cQVZjqmiaPC7rcCQPmPbji6P16vaE0oZzgnyp/KOLbJ98FJVx/5A1uyoT/ZfymeDOR thCF7l0L7keV07ff8loRNZDPGINFmGb2hVbR5X8A0zG/Ik4BNukGozarNij/ImA/mq4S ogP+38CAZkH5UcYpXxvaPqV9ECpoyPOkYWF40depRZuDUtG6OSNW+gGf0lOoHVZZOrsl 0HrBCd3uLlnQl8OB99ix2E1zjVxTy3yOHHqGMuq3VBfmxa2ueP7uvnIWm9sPxpvYRU/c pudgyW8H93vZJOkKjYhSqKNY/uF5Ag3z9WBdf+ItpUr+hkd0l9LBDIc11A8/VKzxq1zz 0aUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U+Gd2/HinAr+Bg1OVpfcbph4giVvyfimyodWFFBNZMk=; b=edc95tATVfWNuAYi4ttKnEv/p4hDpeI7ZjZ/vAce9D2TMRQ37ymR7Rs0sVapShtRl6 Jm/NNGkMCmvJtY6Zv6MsRACo4ZQA53awRBq5ddhhnpTgO6E4c1VZe1htEER0Pbs6XjQ8 miOAC/6LHSwYF2iwbJPcqCVzL2raUrY2pz89p47Azg0O2hXkBjuWf9NVNIEyKvNmQXoF 3PPTLRyqcEHD5GBbzO/XSK9lex0Wryg9V0NswzadczKkuOMV5iY/mJM0qF8rfM2g5cTm EFgg/EKvFoUiE6xTzplT48qriDCKRS3Bf+Gn4IAj7MtJ6nP5rCuZFTB+3maQOSyFfu7m 6dEA== X-Gm-Message-State: ANoB5pmUo9khuqqo9xo8Bo330BRgTeW0AueaA7ib7S3WIP8WXqUVhwv9 gzwQNOE0aviHP469vATA4/HUknQ7RwQ= X-Google-Smtp-Source: AA0mqf6k3kl8b5Y2wca/ohlpIsc1GKXis5GEvOnFh1D+ejrPqXzbFJJmzz4IL2REzYpqsGBdUBqxnQ== X-Received: by 2002:a5d:50d0:0:b0:241:753d:6018 with SMTP id f16-20020a5d50d0000000b00241753d6018mr13996522wrt.67.1669291364938; Thu, 24 Nov 2022 04:02:44 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id t13-20020a05600c198d00b003cf54b77bfesm6380703wmq.28.2022.11.24.04.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 04:02:44 -0800 (PST) From: zimoun In-Reply-To: <871qps20fa.fsf@cbaines.net> References: <20221123104946.29480-1-mail@cbaines.net> <86tu2pfmbv.fsf@gmail.com> <871qps20fa.fsf@cbaines.net> Date: Thu, 24 Nov 2022 12:59:26 +0100 Message-ID: <86wn7kd0m9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669291468; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=U+Gd2/HinAr+Bg1OVpfcbph4giVvyfimyodWFFBNZMk=; b=DNHlrUDWSEh97xDoBCk9UbST7huGLE9fJjV0iTPsmrsTEPbIfj8bVF0xCXgMRf5K673k3I Za4DxYrTTUJtTfgHzuUzvuSqxo0kLMA2U/ND8AdT+c4adMHLwNBHYsOSaw978i9pKAAw/L ZZ11y52+zRG3gHuINrGiC7UoIDOUhxlQY/lzKobHXPhxGOpGamnnSRYVu5q7XXqNZkxEtK Iwa4FXfCoO4ptrGPO8o8KmIwS2jW+xN5u62Hun9f54K7tpZdUhN0Fu1J1Ld2HPtmpyLlhp L9PlL8pLcFEbbaKcMv2iPsywzH8lO6H567H/8bUv4mM4jdb2ZisJ7MzieLMjyg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669291468; a=rsa-sha256; cv=none; b=qSX8UP2ltrI79QJus7OpsUOqhdLdkx7RrF1B0q9LJ/NYuyUqddzX0QL8IXel/YNByyPj3G QERD06hnWOCdTwvs9iwR1fm626drrQMrJYnLXKYkrPvaw68UzeMEjtoW5k/dnnwSMQCVr9 7HBXVOdrNX8z2DoBwn74gGhki6reVrLcj0bT0GZXYp0BzY0J+qu+4tOVS/O6wReFCWaFMu w6+yq9IBSnDVBK1oAmmmpoamzQE9RuyCsRM0a2KN78v8L0JXxKXSsh0F1ATcCQ4LUjK69k DVxFhEMR9kjhp5pcaZYMWQckiRnUOFKrKFD8lPr2IDghhwUiufdcj3pKP08WCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cQVZjqmi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cQVZjqmi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DD7B112ADB X-Spam-Score: 6.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: UgE1NyFjKj6w Hi, On Thu, 24 Nov 2022 at 08:40, Christopher Baines wrote: >> On Wed, 23 Nov 2022 at 10:49, Christopher Baines wrot= e: >> >>> +For a minority of changes, it can be appropriate to push them directly >>> +without sending them for review. This includes both trivial changes >>> +(e.g. fixing typos) but also reverting problomatic changes and >> -^ >>> +addressing regressions. To be sure you have not missed the typo here. :-) s/problomatic/problematic >> =E2=80=A6 changes), and if you're confident (which means you >> successfully built it in a chroot setup, and have done a >> reasonable copyright and license auditing), it=E2=80=99s OK to c= ommit. > > chroot setup doesn't really make sense to me, I'm not sure why that > needs specifying (like do we not want things for the Hurd pushing, since > the guix-daemon doesn't support build isolation there yet)? Good point about chroot. :-) > Also, this guidance is very general, and I think it should be applicable > to all changes. We already trust people with commit access to know what > needs doing, I see this documentation as more about how, so I'd prefer > not to try and put a list here. Yes, we trust people. But a public and explicit policy reinforces the trust, IMHO. It also documents what commit access means. It is not because people with commit access already know what they need doing that all people know, I guess. >> and I would keep the =C2=ABtwo weeks=C2=BB instead of the =C2=ABone week= except=C2=BB. > > My reason for changing this is that I think waiting two weeks after > sending a simple patch is unreasonable. The value from the automated > testing will come after one to two days, I just put a week to avoid > changing it too much, but maybe the lower bound should be two days. Who is verifying the impact of a change? :-) Just a recent example to fix the ideas. The same situation is happening more than often but not that often neither. :-) (It is an example and no blame here. Or blame on me only, for not taking enough care of Julia packages.) Patch#58644 [1] submitted on 19 Oct and pushed on 8 Nov; which is 22 days. Unfortunately, this patch breaks julia-documenter [2], so it means many Julia packages are currently broken; since 17 days. Commit 83ede5a02e1fc531d912eb92eb0a22a4b897997c, gnu: git: Update to 2.38.1. Fixes CVE-2022-39253 and CVE-2022-39260. * gnu/packages/version-control.scm (git): Update to 2.38.1. Co-authored-by: Ludovic Court=C3=A8s 1 file changed, 3 insertions(+), 3 deletions(-) gnu/packages/version-control.scm | 6 +++--- from v2.38.0 to v2.38.1 seems inoffensive. :-) But, --8<---------------cut here---------------start------------->8--- $ ag 'inherit git' gnu/packages/version-control.scm 613: (inherit git) 676: (package/inherit git-minimal $ guix refresh -l git git-minimal | cut -f1 -d':' Building the following 292 packages would ensure 658 dependent packages are= rebuilt --8<---------------cut here---------------end--------------->8--- (The one at line 676 is not impacted by the change, IIRC.) Who does check these 292 packages? For instance, this patch has an impact on Julia packages, --8<---------------cut here---------------start------------->8--- $ guix refresh -l git git-minimal | cut -f2 -d':' | sed 's/ /\n/g' | grep= julia julia-geometrybasics@0.4.1 julia-configurations@0.16.4 julia-pyplot@2.10.0 julia-recipespipeline@0.3.4 julia-quadmath@0.5.5 julia-plotthemes@2.0.1 julia-infinity@0.2.4 julia-testimages@1.5.0 julia-optim@1.6.0 julia-referencetests@0.9.7 julia-imagemagick@1.2.1 --8<---------------cut here---------------end--------------->8--- As part of the Julia team, maybe I could have a look. Well, I had not had the time in these 2 weeks to fix it yet. For two reasons: 1. Because I noticed the failure just a couple of days ago. 2. Because I was busy elsewhere. About #1, I can follow a RSS feed by Cuirass. But somehow, it is too late then either I am working in a rush to minimize the breakage or either the package is broken=E2=80=A6 as today. I have not yet carefully looked at the new QA (neat!). Is it possible to follow some notifications? About #2, two weeks let the time to check the impact of a change. And even, depending on my schedule, sometime it is short. :-) But hey, I agree that the things need to move forward. :-) My point is: Considering leaf packages, yeah once submitted, the review can be fast (couple of days) especially with the new QA. Considering all the other packages, who is checking the impact of a change? Otherwise, we have again and again some broken packages. For sure, the QA is helping *a lot* for improving! Well, on one hand, I understand the willing to merge faster and, even I am not convinced that from two weeks to one week would be detrimental. On the other hand, using Guix, I replaced the pressure when running =E2=80=9Capt-get upgrade=E2=80=9D by a= n eternal annoyance of broken packages popping here or there. Somehow, should be always all green and faster the Git tree moves, harder it is to achieve, IMHO. 1: https://issues.guix.gnu.org/58644 2: >> I think it is also useful to provide the information about commit >> notifications (guix-commits mailing list). > > Why though? What do we expect people with commit access to do when they > read about that here? Maybe it is a niche, I used it a couple of time. For instance, to comment a change already merged, see [3] I guess. 3: Cheers, simon