unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 50632@debbugs.gnu.org
Subject: [bug#50632] [PATCH] graph: Add '--max-depth'.
Date: Tue, 21 Sep 2021 11:19:45 +0200	[thread overview]
Message-ID: <86v92ub80e.fsf@gmail.com> (raw)
In-Reply-To: <87a6k6nwr1.fsf@gnu.org>

Hi Ludo,

On Tue, 21 Sep 2021 at 10:44, Ludovic Courtès <ludo@gnu.org> wrote:

> True, it’s a separate program, but it’s mentioned since
> c2b2c19a7b8b75ef6dd153ca121dd8765cdcd746 because it’s more convenient
> IMO.

Ah, I should have missed this.  However, it does not work out of the
box:

--8<---------------cut here---------------start------------->8---
$ guix environment --ad-hoc xdot
$ guix graph coreutils | xdot -
Traceback (most recent call last):
  File "/gnu/store/gm49bvwdgjpx23wlcfrm8mbf8n75a77n-xdot-1.1/bin/.xdot-real", line 11, in <module>
    load_entry_point('xdot==1.1', 'gui_scripts', 'xdot')()
  File "/gnu/store/gm49bvwdgjpx23wlcfrm8mbf8n75a77n-xdot-1.1/lib/python3.8/site-packages/xdot/__main__.py", line 70, in main
    win = DotWindow(width=width, height=height)
  File "/gnu/store/gm49bvwdgjpx23wlcfrm8mbf8n75a77n-xdot-1.1/lib/python3.8/site-packages/xdot/ui/window.py", line 546, in __init__
    self.dotwidget = widget or DotWidget()
  File "/gnu/store/gm49bvwdgjpx23wlcfrm8mbf8n75a77n-xdot-1.1/lib/python3.8/site-packages/xdot/ui/window.py", line 67, in __init__
    self.connect("draw", self.on_draw)
TypeError: <window.DotWidget object at 0x7f465dd1f400 (xdot+ui+window+DotWidget at 0x17b50f0)>: unknown signal name: draw

(.xdot-real:5940): Gtk-WARNING **: 11:09:08.420: A floating object was finalized. This means that someone
called g_object_unref() on an object that had only a floating
reference; the initial floating reference is not owned by anyone
and must be removed with g_object_ref_sink().
guix graph: error: fport_write: Broken pipe
Segmentation fault
--8<---------------cut here---------------end--------------->8---

That’s why I suggest to keep examples in the manual as simple as
possible.  From my point of view, this package should be mentioned but
should not be part of the example.

The core of the comment is when releasing.  Examples involving a complex
stack are harder to fix.  And from my point of view, release broken
examples in the manual is not acceptable*; for an instance of this, see
<http://issues.guix.gnu.org/issue/47097>.

*not acceptable: well, it is not GNU high standard; even if we can live
 with them. ;-)

Cheers,
simon




  reply	other threads:[~2021-09-21  9:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17  8:18 [bug#50632] [PATCH] graph: Add '--max-depth' Ludovic Courtès
2021-09-20 15:00 ` zimoun
2021-09-21  8:44   ` Ludovic Courtès
2021-09-21  9:19     ` zimoun [this message]
2021-09-21 13:49       ` Ludovic Courtès
2021-09-21 13:45 ` bug#50632: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86v92ub80e.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=50632@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).