unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sarah Morgensen <iskarian@mgsn.dev>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 50614@debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#50614] [PATCH] build: utils: Add ‘list-when’ macro.
Date: Fri, 17 Sep 2021 12:19:16 -0700	[thread overview]
Message-ID: <86tuijggcr.fsf@mgsn.dev> (raw)
In-Reply-To: <08db559a4e24a409d332b3552d6a176de6353166.1631867018.git.public@yoctocell.xyz> (Xinglu Chen's message of "Fri, 17 Sep 2021 10:26:41 +0200 (10 hours, 45 seconds ago)")

Hi,

Looking at this again I have a couple more comments.

Xinglu Chen <public@yoctocell.xyz> writes:
> +@cindex miscellaneous build utilities
> +This section documents some miscellaneous utilities that are useful to
> +have.

"that are useful to have" is implied by its presence in the manual, so
it's unnecessary to write it.

Also, you might consider adding a rule to .dir-locals.el:

  (eval . (put list-when 'scheme-indent-function 1))

which would cause it to be indented like this:

  (list-when expr1
    expr2
    expr3)

(I pointed out a couple other minor grammar corrections in the last
review--did you see those?)

--
Sarah




  parent reply	other threads:[~2021-09-17 19:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16  7:11 [bug#50614] [PATCH core-updates] build: utils: Add ‘optional’ macro Xinglu Chen
2021-09-16 16:21 ` Liliana Marie Prikler
2021-09-17  0:37 ` Sarah Morgensen
2021-09-17  8:26 ` [bug#50614] [PATCH] build: utils: Add ‘list-when’ macro Xinglu Chen
2021-09-17 17:55   ` Liliana Marie Prikler
2021-09-17 19:15     ` Sarah Morgensen
2021-09-17 19:31       ` Liliana Marie Prikler
2021-09-18 14:41     ` Maxime Devos
2021-09-19 13:38     ` Xinglu Chen
2021-09-17 19:19   ` Sarah Morgensen [this message]
2021-09-19 13:41     ` Xinglu Chen
2021-09-19 13:50   ` [bug#50614] [PATCH core-updates v2] " Xinglu Chen
2021-09-19 14:35     ` Maxime Devos
2021-09-20 11:03     ` [bug#50614] [PATCH core-updates] build: utils: Add ‘optional’ macro zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tuijggcr.fsf@mgsn.dev \
    --to=iskarian@mgsn.dev \
    --cc=50614@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).