From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iDOhB/XKnGEOKAAAgWs5BA (envelope-from ) for ; Tue, 23 Nov 2021 12:05:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cPVGA/XKnGGxBAAAbx9fmQ (envelope-from ) for ; Tue, 23 Nov 2021 11:05:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BAB043F2DD for ; Tue, 23 Nov 2021 12:05:24 +0100 (CET) Received: from localhost ([::1]:49810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpTc3-00046p-3O for larch@yhetil.org; Tue, 23 Nov 2021 06:05:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpTbj-00046g-0T for guix-patches@gnu.org; Tue, 23 Nov 2021 06:05:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpTbi-0004Ka-OJ for guix-patches@gnu.org; Tue, 23 Nov 2021 06:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpTbi-000395-Fn for guix-patches@gnu.org; Tue, 23 Nov 2021 06:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v2 10/26] gnu: node-llparse-builder-bootstrap: Use #:absent-dependencies. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 Nov 2021 11:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 51838@debbugs.gnu.org Cc: Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163766549212072 (code B ref 51838); Tue, 23 Nov 2021 11:05:02 +0000 Received: (at 51838) by debbugs.gnu.org; 23 Nov 2021 11:04:52 +0000 Received: from localhost ([127.0.0.1]:50124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpTbY-00038e-HO for submit@debbugs.gnu.org; Tue, 23 Nov 2021 06:04:52 -0500 Received: from mail1.fsfe.org ([217.69.89.151]:43316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpTbW-00038V-Ns for 51838@debbugs.gnu.org; Tue, 23 Nov 2021 06:04:51 -0500 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1637665488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j60BIbJDK2epTa9wOXyv0+27FtnEnPK4dGFIEpdrjtI=; b=FoMbfGJ1miW37o7ZLqn6WrLNwFMEehRSPLyL3ew95fIs3nZzUTqpBmWJViTjQe/ns5WTxM 3jrnUB0JE9l5UaMwZAagQK85wtLJHvffxA1kGwY5E1RFis4n1bLlSI9WjSCpS5Yiq30fLd ig+owB8NVj+C7GiHkFi8Xm17AXrVc1A= In-Reply-To: <20211120043406.952350-10-philip@philipmcgrath.com> References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <20211120043406.952350-1-philip@philipmcgrath.com> <20211120043406.952350-10-philip@philipmcgrath.com> Date: Tue, 23 Nov 2021 12:04:47 +0100 Message-ID: <86tug39lps.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637665524; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=j60BIbJDK2epTa9wOXyv0+27FtnEnPK4dGFIEpdrjtI=; b=D/cIt+2MS28iWmDjr3fI6VGQOz4ERdH4R4sO1C2q8fNn549dz99W9Vf7dEqvDZyNpsa44G /MYmcKydFNj4qd6OtqtEYQMWEzwxJA4yNuQlg1TEMe/xeJhpLwr+JnusvwOH0Gi59OP/h1 UTCCJVHLXESleK54KFbrhZEanXaxZEHr9ZCxAVzk1Wxgs/mV9ju/ib+z49hEIMDKleMWn7 5k1ODOpOfZR2e9SZtO/bmmHEVDCwgSkjzz6cdgk+Tid+w1e+Bf9exIA/ir/bhcGGzMQg1f 3BftRs7o2jZfJsvyp+M85GmUp/Xv/DexBr57NQxfVJuXGVJBdhF7gSIOnGrxvw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637665524; a=rsa-sha256; cv=none; b=Qzikadp6J3GwRgE2oPNMIk6A92CAzxdV39Hzd2HyObFsvyp3P+oLX28t4GtGr+VFVj6otF t20Abiv+QHZsBiItX+Ss/k/Lnap3DepZts3sME7CRneLaSjddBQrAJHQOAKyPF0pWMbCZF 0uWX9ie/Cm0ptT3F3lYhG5fuBAu+bSeCx/aAHqR24tguI/wCjvZpJBLdHS2x7zaa5ghmXJ RbvFe1UFl/YmpeWe4JdbCwVZkmCLuD845ewsSZJuyR6f4dUo0K2l2J9BrwYf3jlwD3qwP5 Pf/QwLlKva2xPF73ZuUryTo9hDikYg1MR5EGInv/GyO1LzLu4FWNYoCsrhgF6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=FoMbfGJ1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.78 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=FoMbfGJ1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BAB043F2DD X-Spam-Score: -1.78 X-Migadu-Scanner: scn1.migadu.com X-TUID: BinNryyKYLQm Hey Philip, Philip McGrath writes: > gnu/packages/node.scm (node-llparse-builder-bootstrap)[arguments]: Add > `#:absent-dependencies`. Stop deleting the `'configure` phase. > Add a new phase `#:delete-package-lock` to remove the > problematic "package-lock.json". > --- > gnu/packages/node.scm | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm > index 98a51276e7..9d4903a8ca 100644 > --- a/gnu/packages/node.scm > +++ b/gnu/packages/node.scm > @@ -479,9 +479,21 @@ (define-public node-llparse-builder-bootstrap > (arguments > `(#:node ,node-bootstrap > #:tests? #f > + #:absent-dependencies > + `("@types/mocha" > + "@types/node" > + "mocha" > + "ts-node" > + "tslint" > + "typescript") > #:phases > (modify-phases %standard-phases > - (delete 'configure) > + (add-before 'configure 'remove-package-lock > + ;; Having package-lock.json seems to cause npm > + ;; to look for things on the internet in the configure phase, > + ;; even if we have them properly installed. package-lock.json lists exact versions _and integrity hashes_; since it seems unlikely that after node-build-system's finaggling we end up with an identical hash, we will always have a mismatch and fetch 'proper' sources online accordingly. As far as npm + package-lock.json are concerned, we don't have them properly installed. >From what I have seen package-lock.json offers us no benefits (because we track exact dependency information via the guix store) and can (as you have seen) prevent builds from working. My 2c: always remove it in a phase in the build system. It's simply a preference though, so your please go with what you think is the right choice. You might want to update the comment nonetheless so it's clear we know what's going on. > + (lambda args > + (delete-file-recursively "package-lock.json"))) > (replace 'build > (lambda* (#:key inputs #:allow-other-keys) > (let ((esbuild (string-append (assoc-ref inputs "esbuild") > -- > 2.32.0