From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yNp2O34J0GSWgAEASxT56A (envelope-from ) for ; Sun, 06 Aug 2023 22:58:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SPV8O34J0GSaYQEA9RJhRA (envelope-from ) for ; Sun, 06 Aug 2023 22:58:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B84B37743 for ; Sun, 6 Aug 2023 22:58:38 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b="mqL+c6/F"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691355518; a=rsa-sha256; cv=none; b=shWaX8xlQYqbdo8rFrxu5ZTYaa51hD4vF9dJLUGQgu09jj5IAgXJKt3SnsKIXf7cXqVEZP n66RmrRIEdPFNLbh/Ma6MIScGTj2jFpyuv61FWNIW5p5kd9h6jk7zhOIW7vnfKv8pAQNVy GBEQHi0bsYv3cUfZq4BJWhuon+232QVe7aWCV2dCUeMGGwC3CM5VmMYTN8kcMCkDkd3dKy 9xSKWuflSKJE4rLF9R6te5xfTDT4TAczjaLAl2gl+i+u9/xCfYsWdFyz26FjEhg5vXu18K VghZbhaxI+SJX5h3b9CNNQoFXtXEoGydHQVfdxM1NPL8cm+6DqMXD0RmdMeE7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691355518; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Y0NrJYxPcRW4DHf+NVO52tthzkwgr+AKbjHWWcNdOJI=; b=iVCwTI+bgiER8+lIljOrd+o7MtJJfxsWLEsaJBGw6eNMbvDams+ScTJJgr8OMQtmart5S+ mNVw4lVTXuGgTepVBx0d50UOeHnAey8cJqWBo94kp/7aIVYvbB0QyEP6pzLYcHlyvrqs0j AFG6yebzGAgocfUO+MMbH6fuFu9RveAs99m7nnOq3+sC3CPXgdpXDxfT6b2Alk7tU3e+zF roMoAeGFbX5YxHknDP+zyx/Eow43Q75cKOUKZOHc8SX45EQPt4a2jD27P4NvKNqvp5S1lD PHSAhRLoKrsKr5X74g4/vgLyxVY0snf+L5jNShidpmMZJ1E0phm2WApaS2l3Vw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b="mqL+c6/F"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSkdd-0002DN-Pk; Sun, 06 Aug 2023 16:46:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSkdW-0002Cy-WD for guix-patches@gnu.org; Sun, 06 Aug 2023 16:46:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSkdW-0006X9-GJ for guix-patches@gnu.org; Sun, 06 Aug 2023 16:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSkdW-00054X-Bg for guix-patches@gnu.org; Sun, 06 Aug 2023 16:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64209] [PATCH 00/14] Add ocaml-lsp-server and its dependencies Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Aug 2023 20:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64209 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Benjamin Cc: Julien Lepiller , 64209@debbugs.gnu.org Received: via spool by 64209-submit@debbugs.gnu.org id=B64209.169135475119478 (code B ref 64209); Sun, 06 Aug 2023 20:46:02 +0000 Received: (at 64209) by debbugs.gnu.org; 6 Aug 2023 20:45:51 +0000 Received: from localhost ([127.0.0.1]:60094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSkdK-000546-U1 for submit@debbugs.gnu.org; Sun, 06 Aug 2023 16:45:51 -0400 Received: from mout02.posteo.de ([185.67.36.66]:48373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSkdF-00053o-Lm for 64209@debbugs.gnu.org; Sun, 06 Aug 2023 16:45:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 83FC7240104 for <64209@debbugs.gnu.org>; Sun, 6 Aug 2023 22:45:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1691354739; bh=BQi+zqtvfIH+zzxnKN9SsDSRXKd8vTIkmSLZi1xZTNc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=mqL+c6/FPgWEF30+NJqeqlRAnhE58Py/hgSTe0ATv4mA8x/U9OaCKr4nOMSJ9jMmr no7bp8hX1MBb0LJW1nhiNWA1rOB2cnXzHntNPAWCuG3YJ84e753bx4T4WJtlunlAjK rs1ebqC8amqWO4zS3Tg6QGxU3O8vjqdqBtw8KH/+S6IZeN0dGftSDbSlVOBZO7j47a 39okOTYyZFd2AEawUiWt4QAFOfEvWsw2lyMfmQx+kpuXJvnn8kceJ/b73y5iwcbGa9 rvURvbrvBrgQlCnErzVwbH9TmYqRqPrVTOnxKg/9dL/Z/ghKzjweEDDSYDeOIkoa4o /4fTg/rsW0xTQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RJs0f4RNRz9rxF; Sun, 6 Aug 2023 22:45:38 +0200 (CEST) References: From: pukkamustard Date: Sun, 06 Aug 2023 20:25:55 +0000 In-reply-to: Message-ID: <86tttb99xq.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.74 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 3B84B37743 X-Spam-Score: -3.74 X-TUID: hwTZAFFaY/Cl Hi, Thanks for the patches! Couldn't look at everything yet, just some initial remarks. Benjamin writes: > Hello, > > These patches add ocaml-lsp-server package. > > ... > > Benjamin (14): > gnu: Fix ocaml-dune-build-info Lgtm, this patch would fix #63947. > gnu: Add ocaml-dune-rpc. There seems to be an issue with the ordering of the patches. I can not build ocaml-dune-rpc, as it requires ocaml-ordering which is only available a couple of commits later. In general, try to make things build at every commit. In this case it requires re-ordering the commits. Could you explain why the 'remove-vendor phase is needed? It seems like if code is vendored it should maybe also be removed in the `dune` package? As Ludo mentioned, the description and synopses could use a little bit of improvement. For example descriptions should be full sentences. > gnu: Add ocaml-chrome-trace. We need a more descriptive description. I guess the descriptions come from OPAM. Unfortunately Guix has stricter requirements than OPAM...:) -pukkamustard