From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YPhFAtGUvmRmkgAASxT56A (envelope-from ) for ; Mon, 24 Jul 2023 17:12:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +GkoAtGUvmTJeQAAauVa8A (envelope-from ) for ; Mon, 24 Jul 2023 17:12:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9341E31165 for ; Mon, 24 Jul 2023 17:12:16 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=rdLBVJF6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690211536; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=LdFXCzXCrfhsqdRyZCEynlrCulJls/BKcKILB9cGdmA=; b=scEzkhRYvBeJKF/sRgEBNf2Peb8VcczOxnfK9Dn74902EtRflUY824EKjSFZn1VxLJ/1HV F9ukgiFClas5wZghasD9uIj5awSZmHxSNMufjoXAh0OU+94K4Rs8cTr/RRissehRvu2G4k D1jrmI8+tW4Yk6rHWY6YhQp9OLr3Iu6SPdPSuxRBk3+lc9YYzn8kh9hEQ44UB43qwVT8ER LHDSb9sWDPva3DyhnLuzwfMYNjpMnf0svfgU3a1efGbdr9uf0Xed/TExA9PBPAXN9wboO+ VDDyKmAzj1hD3Dc8kp2+No3Nwuzr6B1Bg2yNkLWrtVrHjPzUeyxduKiLWFnOAg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690211536; a=rsa-sha256; cv=none; b=p8/0fKfps0sWLTKlsw9+MsCVT7lB3L4XEpMhJhcIo4mAmbzJ8cuEcj7rZvitNh8Gd5EB5m wwTmOh31WMr6EWhJUEmtQJ35z4G5LD7gZ3DHUXHi0ddY0d/Le8gyGoIyRjppmc1gSmKs+2 skJQJo2OgovrZ7hxW0RXVmHOE3A1+86sOtNuJ4zcj6WNTbRahOiFL9LXJ5V+p1JEj6hOsB Ax83il5J2ABoqLsx9x8k8/VChzFBPHDwemXWcBykE+UOgTbJOHALlQ1knb8YLPOO/Ihfoi W/V4KAzK6+3jPCbC2iRh8SvbEwsusZV8OVXDF06L/+tI7vbjEn+FWd0fcWO6Ew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=rdLBVJF6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNxED-00054u-Cx; Mon, 24 Jul 2023 11:12:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNxEA-00054e-T5 for guix-patches@gnu.org; Mon, 24 Jul 2023 11:12:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNxEA-0006uN-Kx for guix-patches@gnu.org; Mon, 24 Jul 2023 11:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNxEA-0002WJ-GE for guix-patches@gnu.org; Mon, 24 Jul 2023 11:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64249] [PATCH ocaml-team v3 2/6] gnu: coq: Update to 8.17.1. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Jul 2023 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64249 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: DABY-SEESARAM Arnaud , 64249@debbugs.gnu.org, Josselin Poiret Received: via spool by 64249-submit@debbugs.gnu.org id=B64249.16902115109665 (code B ref 64249); Mon, 24 Jul 2023 15:12:02 +0000 Received: (at 64249) by debbugs.gnu.org; 24 Jul 2023 15:11:50 +0000 Received: from localhost ([127.0.0.1]:43788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNxDx-0002Vo-JA for submit@debbugs.gnu.org; Mon, 24 Jul 2023 11:11:50 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNxDu-0002VV-NB for 64249@debbugs.gnu.org; Mon, 24 Jul 2023 11:11:48 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1E5B2240027 for <64249@debbugs.gnu.org>; Mon, 24 Jul 2023 17:11:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690211500; bh=b6GCDCO7oQe2jtYkdwe+DbC/J4j1kEzGyaRzEAbxfDw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=rdLBVJF6v04WAJq5X3+ZeQcNShNSsZ0ZtaSEr7NZoMzMEXxOVwgwzjqumrxtWtSz5 XMpmT8/2Q0qIik2i/GLuHdsh3RjNAxEqzJApVmrAJ3k6aSKBD+u3kaAMM/6uBCP98i ZHvFYInH7VniEGOV4N3MEdNFR6ZgylzemZcX8iOLR++FDkEgyXlTYrwEpj47jCfsZa INKPOCwwuKKvF7MFAF3SvtC5k0HGsj2XjWvTEsVfIv0Suky4ylOhrVtA3H9l/wMTW5 N/Odm78TTNjqacUYtzG27HjpM56k3v/ioD9l3NOfFFICoVK/azb4n2OPcmuH470gm9 r/KijPnBnsSbQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R8kCG5Qqqz9s41; Mon, 24 Jul 2023 17:11:38 +0200 (CEST) References: <858ebb8d740c7bfd0d55eaaf8a67db2298d4081a.1689682321.git.pukkamustard@posteo.net> <20230719201843.31b30208@lepiller.eu> From: pukkamustard Date: Mon, 24 Jul 2023 14:54:05 +0000 In-reply-to: <20230719201843.31b30208@lepiller.eu> Message-ID: <86sf9dny39.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: 4.16 X-Spam-Score: 4.16 X-Migadu-Queue-Id: 9341E31165 X-TUID: RXEobjaQbITp Hi, Julien Lepiller writes: > I'm not sure why, but this is breaking all coq dependents, with > messages similar to: > > cannot guess a path for Coq libraries; please use -coqlib option or > ensure you have installed the package containing Coq's stdlib > (coq-stdlib in OPAM) If you intend to use Coq without a standard > library, the -boot -noinit options must be used. > > I think this is because coq-stdlib is mostly empty for some reason. A couple of build failures later this is where I'm at: - Coq 8.17.1 includes considerable changes to the build system. - Some `dune` files are autogenerated with `make dunestrap` (which runs the OCaml program `tools/dune_rule_gen/gen_rules.ml`. - In the v3 patches I submitted `make dunestrap` was not being run, resulting in missing dune files and a quite empty `coq-stdlib` package. - The 8.17.1 generated dune files for `coq-stdlib` reference things in `coq-core` directly with relative paths instead of letting dune/findlib find them (with entries in the `libraries` stanza in dune files). This makes building `coq-core` and `coq-stdlib` seperately more tricky. I've asked in #coq for ideas on how `coq-stdlib` and `coq-core` can be built seperately/kept in separate packages. Nothing yet. What do you think about merging `coq-core`, `coq-stdlib` and `coq` into a single package? Not as nice as the current situation, but maybe a way to go without too many custom patches/hacks? CC: Arnaud and Josselin who might be interested in Coq stuff. Thanks, pukkamustard >> * gnu/packages/coq.scm (coq-core, coq-stdlib, coq): Update to 8.17.1 >> and remove test-target argument. >> --- >> gnu/packages/coq.scm | 24 +++++------------------- >> 1 file changed, 5 insertions(+), 19 deletions(-) >> >> diff --git a/gnu/packages/coq.scm b/gnu/packages/coq.scm >> index 09ca4030ea..3332707a71 100644 >> --- a/gnu/packages/coq.scm >> +++ b/gnu/packages/coq.scm >> @@ -53,7 +53,7 @@ (define-module (gnu packages coq) >> (define-public coq-core >> (package >> (name "coq-core") >> - (version "8.16.1") >> + (version "8.17.1") >> (source >> (origin >> (method git-fetch) >> @@ -63,7 +63,7 @@ (define-public coq-core >> (file-name (git-file-name name version)) >> (sha256 >> (base32 >> - "0ljpqhh5lfsim29fcfp2xfcvm3j84pf1mb0gnpdr8vcqqw7mqwpf")) >> + "0gg6hizq0i08lk741b579cbswhy6qvkh6inc3d3i5a2af98psq63")) >> (patches (search-patches "coq-fix-envvars.patch")))) >> (native-search-paths >> (list (search-path-specification >> @@ -83,8 +83,7 @@ (define-public coq-core >> (native-inputs >> (list ocaml-ounit2 which)) >> (arguments >> - `(#:package "coq-core" >> - #:test-target ".")) >> + `(#:package "coq-core")) >> (properties '((upstream-name . "coq"))) ; also for inherited >> packages (home-page "https://coq.inria.fr") >> (synopsis "Proof assistant for higher-order logic") >> @@ -101,19 +100,7 @@ (define-public coq-stdlib >> (inherit coq-core) >> (name "coq-stdlib") >> (arguments >> - `(#:package "coq-stdlib" >> - #:test-target "." >> - #:phases >> - (modify-phases %standard-phases >> - (add-before 'build 'fix-dune >> - (lambda _ >> - (substitute* "user-contrib/Ltac2/dune" >> - (("coq-core.plugins.ltac2") >> - (string-join >> - (map (lambda (plugin) (string-append >> "coq-core.plugins." plugin)) >> - '("ltac2" "number_string_notation" "tauto" >> "cc" >> - "firstorder")) >> - " ")))))))) >> + `(#:package "coq-stdlib")) >> (inputs >> (list coq-core gmp ocaml-zarith)) >> (native-inputs '()))) >> @@ -123,8 +110,7 @@ (define-public coq >> (inherit coq-core) >> (name "coq") >> (arguments >> - `(#:package "coq" >> - #:test-target ".")) >> + `(#:package "coq")) >> (propagated-inputs >> (list coq-core coq-stdlib)) >> (native-inputs '())))