From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id /nd/Dxkt3F9vHgAA0tVLHw (envelope-from ) for ; Fri, 18 Dec 2020 04:16:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wNq+Chkt3F8ABAAA1q6Kng (envelope-from ) for ; Fri, 18 Dec 2020 04:16:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C6C909403AA for ; Fri, 18 Dec 2020 04:16:24 +0000 (UTC) Received: from localhost ([::1]:45698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kq7Bn-0007qD-Kk for larch@yhetil.org; Thu, 17 Dec 2020 23:16:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kq7BY-0007q3-6e for guix-patches@gnu.org; Thu, 17 Dec 2020 23:16:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kq7BS-0000Ir-6S for guix-patches@gnu.org; Thu, 17 Dec 2020 23:16:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kq7BS-0006Ck-0f for guix-patches@gnu.org; Thu, 17 Dec 2020 23:16:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45221] [PATCH] guix: qt-build-system: Wrapped executables honor user's envvars. References: <93d83462d1445ffd001039eebb1f2a84e6ccf3a9.1607873941.git.h.goebel@crazy-compilers.com> In-Reply-To: <93d83462d1445ffd001039eebb1f2a84e6ccf3a9.1607873941.git.h.goebel@crazy-compilers.com> Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Dec 2020 04:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45221 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45221@debbugs.gnu.org Received: via spool by 45221-submit@debbugs.gnu.org id=B45221.160826491223793 (code B ref 45221); Fri, 18 Dec 2020 04:16:01 +0000 Received: (at 45221) by debbugs.gnu.org; 18 Dec 2020 04:15:12 +0000 Received: from localhost ([127.0.0.1]:37476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq7Ae-0006Bh-Ag for submit@debbugs.gnu.org; Thu, 17 Dec 2020 23:15:12 -0500 Received: from mail-m975.mail.163.com ([123.126.97.5]:40900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq7AZ-0006BO-6K for 45221@debbugs.gnu.org; Thu, 17 Dec 2020 23:15:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=Nz3u7 qusqGI5v5WRHiG0ng+pj2aKW0XESSn214XcZuE=; b=lv3iH+ssiaLrt4+nh8R1K s/0vVhC1VXIJ4SFvRSD/wL0FjxoA0oKDGSw3sSS5eV7jWlcUda1CrcWoFGm5Dp4z RlikD/eXIlpVdILYg26gweYtlPHh0h5Wg/4Ae7BdHKDc7gbA/aA/zpFPRJPPWdP8 t6Qd5k0SpVtJ8p6RVSLSLo= Received: from asus-laptop (unknown [27.39.89.162]) by smtp5 (Coremail) with SMTP id HdxpCgCXt3u4LNxfjBV9Fw--.35S2; Fri, 18 Dec 2020 12:14:54 +0800 (CST) User-agent: mu4e 1.4.13; emacs 27.1 From: Zhu Zihao Date: Fri, 18 Dec 2020 12:14:44 +0800 Message-ID: <86r1nnzr63.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-CM-TRANSID: HdxpCgCXt3u4LNxfjBV9Fw--.35S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKFy8XF43JryUKF1Uuw1fXrb_yoWxZrX_Kr Z5J3yDWrWjqry3trWakay3CFWfWFyfXr18Wayjga1YgryDXanrXrZ7Cr95Zw1Ygwn7GFn5 C39rtrZ7ZrW3ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUQzV7UUUUU== X-Originating-IP: [27.39.89.162] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbB8Qf+r12MYUJ1sAAAsQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: h.goebel@crazy-compilers.com Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.32 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=163.com header.s=s110527 header.b=lv3iH+ss; dmarc=fail reason="SPF not aligned (relaxed)" header.from=163.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C6C909403AA X-Spam-Score: -3.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: c/VAcTgC6HO+ --=-=-= Content-Type: text/plain Good work! I think this can help solve #45193[1]. And there're still some issues I mentioned in that issues. 1. We may need to fix `wrap-qt-program` in qt-utils.scm. It's implementation is quite weird(See my reply in [1]). Or we can remove this function and make package use (assoc-ref qt-build-system:%standard-phases 'qt-wrap) instead. 2. We should search directories in outputs, now we just search all inputs. Some Qt programs were deployed with a bundle of Qt plugins in their prefix. If we miss these dirs, they won't run. [1]: https://issues.guix.gnu.org/45193 -- Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQTUepyLKuOQW1Y9kTW+QrNSqfaCHwUCX9wstBUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQvkKzUqn2gh9cCgEA+4F+klhZPot+usbQXY2O+rraohi5 A1lP+JD3H8SUt2gBANow0aDvq1bZhH4/kMZuEHt/To9oibkpWD/f8F/0zYAJ =Xd1x -----END PGP SIGNATURE----- --=-=-=--