[bug#50076] [PATCH 1/1] gnu: Add python-flask-debugtoolbar.

[Bonface Munyoki K. <me@bonfacemunyoki.com>]

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

Arun Isaac <arunisaac@systemreboot.net> anaandika:

> Hi Bonface,
>
> Thanks for contributing! :-) Some feedback follows.
>
> 1. Please add a copyright header.

Cool. Thanks for the gentle reminder.

> 2. Could you try packaging the tests? I think tests use
> pytest. Currently, no tests are run during the check phase.
>

Cool. I'll try to work out how to do that.

>> +  (synopsis
>> +    "A toolbar overlay for debugging Flask applications.")
>
> 3. Could you remove the article "A" at the beginning, and the period at
> the end? Quoting from our manual at "(guix) Synopses and Descriptions":
>
>    Synopses must start with a capital letter and must not end with a
> period.  They must not start with “a” or “the”, which usually does not
> bring anything; for instance, prefer “File-frobbing tool” over “A tool
> that frobs files”.
>
>
>> +  (description
>> +    "This extension adds a toolbar overlay to Flask applications containing
>> +useful information for debugging.")
>
> 4. Finally, a nitpick: It would be more consistent with the rest of Guix
> if the synopsis and description started on the same line instead of on
> the next. So, something like this:
>
>     (description "This extension adds a toolbar overlay to Flask applications
> containing useful information for debugging.")
>

Much thanks for the above suggestions! I'll work
on this and submit a revised patch over the
weekend.

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]